Bharat Mediratta
8d030cea64
Fix a bug where simultaneous deletes of the same item can result in it
...
deleting the first item row in the database. The root issue is a bug
in Kohana that's addressed in dca9b5f3fc
but in this change we deal with the fact that reloading an item can
result in an instance of the item that's unloaded. In those cases, we
should just ignore it and move on. Fixes #1489 .
2010-11-18 09:52:40 -08:00
Bharat Mediratta
add586bbb1
Create a task to clean up tag counts and delete tag with no associated
...
items. Fixes #1488 .
2010-11-14 15:53:30 -08:00
Bharat Mediratta
bf333aa762
Merge branch 'master' of github.com:gallery/gallery3
2010-11-14 15:48:20 -08:00
Bharat Mediratta
d49a6dcc99
Create a new task to resync tag task counts and delete tags that have
...
no associated items.
2010-11-14 15:45:30 -08:00
Bharat Mediratta
7efa9a5b87
Fix two issues with item deletion:
...
1) We're compacting tags on every deletion which is slow. Since we delete
albums in batch, we should just do one tag compaction at the end. Fixes
#1487 .
2) Issue introduced in 3d952f41c8 where
we trigger an item_related_update in tag::clear_all(). Since
tag::clear_all() is called when we delete an item, this causes
the search module to attempt to index a deleted item. Move that
triggering upstream.
2010-11-14 15:01:29 -08:00
Tim Almdal
86790d4464
Return the admin check as part of the block structure as opposed to printing
...
it directly to the output. I had problems with the admin check messing up the
AJAX calls on the module update page. And it went away after this fix.
2010-11-09 21:08:14 -08:00
Bharat Mediratta
e87c502ede
Tie the image cachebuster to the file mtime instead of
...
Item_Model::$updated since we want the url to be stable whenever
possible. Fixes #1482 .
2010-11-09 12:48:07 -08:00
Bharat Mediratta
f0781a9162
Add an extra line break after the RewriteBase line so that the
...
RewriteBase and RewriteRule lines don't get merged in the resulting
textarea. Fixes #1481 .
2010-11-09 09:17:13 -08:00
Bharat Mediratta
3d952f41c8
Fix a bug in the way that we add tags that causes it to be really slow
...
when adding a tag to lots of items. Tag_Model::save() would call
item_related_update for every tag related to an item upon save which
is an O(N!) operation. Fixes ticket #1412 .
2010-11-08 22:16:57 -08:00
Bharat Mediratta
dae8354491
Updated item::random_query() PHPdoc to include example usage
2010-11-08 19:52:43 -08:00
Bharat Mediratta
945e79b171
Add a pure javascript mechanism for filtering advanced properties. Partial fix for #1478 .
2010-11-08 13:51:51 -08:00
Bharat Mediratta
853a3acc9b
Implement module::clear_all_vars($module_name)
...
Also switch from using ORM to Database_Builder for the SQL because it's
cleaner, and clean up the test. Fixes #1479 .
2010-11-08 11:45:14 -08:00
Bharat Mediratta
35d933cf7f
Dump something in the logs if GalleryEmbed::init() fails.
2010-11-08 10:06:56 -08:00
Bharat Mediratta
359a081f15
Add Malay as 'Bahasa Melayu'
2010-11-07 22:08:20 -08:00
Bharat Mediratta
d503513eca
Create item_before_create and item_before_update events, and make
...
Item_Model::data_file public. This allows us to intercept and tweak
data files before saving the model which enables the max_size module.
2010-11-06 21:54:28 -07:00
Bharat Mediratta
f01fad1cd0
Deal in integers when doing aspect ratio operations. Fixes #1470 .
2010-10-31 12:21:06 -07:00
Bharat Mediratta
dff1a53696
All modules should be named Xxx_Core for extensibility. Fixes #1458 .
2010-10-25 21:05:31 -07:00
Bharat Mediratta
1cc3d130bc
Set the unit test timeout to 5 minutes
2010-10-25 21:04:40 -07:00
Bharat Mediratta
4dc451629c
Allow access to the rest module when the gallery is wholly private. Fixes ticket #1452 .
2010-10-24 17:03:40 -07:00
Bharat Mediratta
db00958cee
Add MJ12bot and Speedy Spider to the robot list.
2010-10-11 21:06:00 -07:00
Bharat Mediratta
c4454f1f07
Copy system/config/user_agents.php over to gallery/config so that we can add to the list
2010-10-11 21:05:39 -07:00
Bharat Mediratta
84731437a7
Identify robots and don't let them save sessions.
2010-10-09 16:24:58 -07:00
Bharat Mediratta
349071f501
Change version to "3.0+ (git)".
2010-10-07 22:16:18 -07:00
Bharat Mediratta
4b4a2f8d8d
Set the version to 3.0 final (woot!).
2010-10-04 23:55:19 -07:00
Bharat Mediratta
3c40476b34
Not sure why digibug::close_window() changed in the listing, but it looks fine here.
2010-10-04 23:42:07 -07:00
Bharat Mediratta
df378fcca8
Don't wrap the action in url::site() -- form::open() will do that for us. Fixes #1417 .
2010-10-03 22:10:05 -07:00
Bharat Mediratta
a153ca0829
Detect the case where there are no more broken images and skip to the end. Fixes #1414 .
2010-10-02 17:04:37 -07:00
Bharat Mediratta
161bbb9ba3
Proxy the BasicAuth authentication header in htaccess_works() so that
...
if the entire Gallery is behind BasicAuth we share the same
credentials as the browser. Fixes #1413 .
2010-10-02 16:44:31 -07:00
Bharat Mediratta
62f1bb06a2
Set the User-Agent field to "Gallery3" by default. Fixes #1408 .
2010-10-02 13:46:47 -07:00
Bharat Mediratta
c0022dc3c3
Fix a bug in the way we set the mime type for protected image renders.
...
Also whitelist the digibug controller so that it's accessible when the
gallery is private, and don't expire old proxies right away since
Digibug may request the full size multiple times for different preview
operations.
Fixes ticket #1410 .
2010-10-01 21:45:45 -07:00
Bharat Mediratta
86981c5afb
Use the "loading" image from themes/wind since it's no longer in gallery3/lib.
2010-10-01 21:09:14 -07:00
Bharat Mediratta
f84782d620
Stop caching all module variables in the vars table using the
...
name=_cache row. If that overflows, it will cause us to be unable to
load variables, and we can't recover from that.
Instead, use the Cache table. Bump the gallery module to v40. Fixes
ticket #1405 .
2010-09-29 20:47:43 -07:00
Bharat Mediratta
ef8751468b
Base64 encode the data result if the encoding param is set to "base64".
...
Fixes #1400 .
2010-09-25 13:27:35 -07:00
Bharat Mediratta
85637a0826
Fix a bug introduced recently in
...
f84c4a6192 where we were generating bad
SQL. If we're checking for a conflict on a new item, the id is null
and we were doing a comparison that resulted in "id <> NULL" which
won't work -- in that case we need "id IS NOT NULL".
Fixes #1393 .
2010-09-23 20:45:27 -07:00
Bharat Mediratta
7116f820ca
Remove the 4 character minimum for group name length. Fixes ticket #1396 .
2010-09-22 21:43:44 -07:00
Bharat Mediratta
790bf4e871
Prioritize using the value in graphics_toolkit_path over the standard
...
path so that if you change that value in Admin > Settings > Advanced
we prefer it over other paths (which may be restricted by
open_basedir). Fixes #1395 .
2010-09-22 21:35:49 -07:00
Bharat Mediratta
3b8475908f
Use alternate path to the CoolIris slideshow that fixes the problem
...
with Adobe not properly signing TextLayout.swz. Fixes #1390 .
2010-09-22 20:55:27 -07:00
Bharat Mediratta
fad1f05203
The Kohana folks removed the cache cleanup code back in
...
http://dev.kohanaframework.org/projects/kohana2/repository/revisions/4605
So now our cache entries don't expire. For now, do cache expiration
whenever we render Admin > Maintenance, since that's the type of place
that users will go when they want their cache to expire anyway.
2010-09-18 17:46:28 -07:00
Bharat Mediratta
a1b1d323af
When looking for G2 urls in the g2_map, try also swapping spaces for +
...
in case the url had spaces in it. Fixes ticket #1388 .
2010-09-18 16:46:15 -07:00
Bharat Mediratta
6bb75f623e
Fix a bug in that last commit where I was treating resource_type as a function.
2010-09-18 16:34:48 -07:00
Bharat Mediratta
77ec061663
Redirect to the root album when there's an empty path and empty id.
...
Fixes ticket #1387 .
2010-09-18 15:12:43 -07:00
Bharat Mediratta
8ee25157ec
Fix a bug in the way that we calculate expiration dates for old
...
comments by using Database_Expression. Fixes ticket #1386 .
2010-09-18 14:29:52 -07:00
Bharat Mediratta
8135429430
Checkpoint.
2010-09-17 13:39:48 -07:00
Bharat Mediratta
3e1743b21f
Add a module variable containing extra paths to search for binaries.
...
Fixes ticket #1384 .
2010-09-16 20:43:48 -07:00
Bharat Mediratta
64dfccc4ed
Preserve the image extension on the temp file that we create for
...
rotating images. Some versions of GD won't work if we don't do this.
Fixes ticket #1375 .
2010-09-16 20:04:22 -07:00
Bharat Mediratta
de2f9baeee
Add a link to
...
http://codex.gallery2.org/Gallery3:Choosing_A_Graphics_Toolkit to help
users choose a graphics toolkit. Fixes ticket #1372 .
2010-09-16 19:34:42 -07:00
Bharat Mediratta
5e316f78c6
Restrict viewing user profile pages to registered users only, but
...
provide a "show_user_profiles_to" setting to allow admins to open it
up to everybody (choices there are "registered_users", "admin_users"
or "everybody"). Fixes ticket #1378 .
2010-09-16 15:17:00 -07:00
Bharat Mediratta
3e3098956c
Convert the guest_url ORM validation failure back to the url form
...
parameter and put in a message requiring a valid url. Fixes ticket
2010-09-16 14:19:28 -07:00
Bharat Mediratta
70f15c6662
Add ability to sort albums by name. Fixes ticket #1377 .
2010-09-14 19:51:43 -07:00
Bharat Mediratta
4b8d6beb5e
Report the graphics toolkit in the platform block.
2010-09-14 19:40:54 -07:00