stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-08-15 11:27:24 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,129 Commits 4 Branches 0 Tags
8d030cea64c0e5934e4dbf5fc56fab87c7e253bb
Commit Graph
6129 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Bharat Mediratta 8d030cea64 Fix a bug where simultaneous deletes of the same item can result in it 
deleting the first item row in the database.  The root issue is a bug
in Kohana that's addressed in dca9b5f3fc
but in this change we deal with the fact that reloading an item can
result in an instance of the item that's unloaded.  In those cases, we
should just ignore it and move on.  Fixes #1489.
 2010-11-18 09:52:40 -08:00
Bharat Mediratta dca9b5f3fc Fix a bug in ORM where calling reload() on an unloaded instance returns the 
first instance in the database, which is super bad.

Kohana ticket:
  http://dev.kohanaframework.org/issues/3397

Related G3 ticket:
  http://sourceforge.net/apps/trac/gallery/ticket/1489
 2010-11-18 09:48:50 -08:00
Bharat Mediratta add586bbb1 Create a task to clean up tag counts and delete tag with no associated 
items.  Fixes #1488.
 2010-11-14 15:53:30 -08:00
Bharat Mediratta bf333aa762 Merge branch 'master' of github.com:gallery/gallery3 2010-11-14 15:48:20 -08:00
Bharat Mediratta d49a6dcc99 Create a new task to resync tag task counts and delete tags that have 
no associated items.
 2010-11-14 15:45:30 -08:00
Bharat Mediratta 7efa9a5b87 Fix two issues with item deletion: 
1) We're compacting tags on every deletion which is slow.  Since we delete
   albums in batch, we should just do one tag compaction at the end.  Fixes
   #1487.

2) Issue introduced in 3d952f41c8 where
   we trigger an item_related_update in tag::clear_all().  Since
   tag::clear_all() is called when we delete an item, this causes
   the search module to attempt to index a deleted item.  Move that
   triggering upstream.
 2010-11-14 15:01:29 -08:00
Tim Almdal 86790d4464 Return the admin check as part of the block structure as opposed to printing 
it directly to the output.  I had problems with the admin check messing up the
AJAX calls on the module update page.  And it went away after this fix.
 2010-11-09 21:08:14 -08:00
Bharat Mediratta e87c502ede Tie the image cachebuster to the file mtime instead of 
Item_Model::$updated since we want the url to be stable whenever
possible.  Fixes #1482.
 2010-11-09 12:48:07 -08:00
Bharat Mediratta f0781a9162 Add an extra line break after the RewriteBase line so that the 
RewriteBase and RewriteRule lines don't get merged in the resulting
textarea.  Fixes #1481.
 2010-11-09 09:17:13 -08:00
Bharat Mediratta 3d952f41c8 Fix a bug in the way that we add tags that causes it to be really slow 
when adding a tag to lots of items.  Tag_Model::save() would call
item_related_update for every tag related to an item upon save which
is an O(N!) operation.  Fixes ticket #1412.
 2010-11-08 22:16:57 -08:00
Bharat Mediratta dae8354491 Updated item::random_query() PHPdoc to include example usage 2010-11-08 19:52:43 -08:00
Bharat Mediratta 945e79b171 Add a pure javascript mechanism for filtering advanced properties. Partial fix for #1478. 2010-11-08 13:51:51 -08:00
Bharat Mediratta 853a3acc9b Implement module::clear_all_vars($module_name) 
Also switch from using ORM to Database_Builder for the SQL because it's
cleaner, and clean up the test.  Fixes #1479.
 2010-11-08 11:45:14 -08:00
Bharat Mediratta 97a5656296 Check for the PHP Ctype extension. Fixes ticket #1474. 2010-11-08 11:09:06 -08:00
Bharat Mediratta 35d933cf7f Dump something in the logs if GalleryEmbed::init() fails. 2010-11-08 10:06:56 -08:00
Bharat Mediratta 359a081f15 Add Malay as 'Bahasa Melayu' 2010-11-07 22:08:20 -08:00
Bharat Mediratta c1bc59fbb5 Force the new geometry in the ImageMagick crop() function. 
Fixes http://dev.kohanaframework.org/issues/3384
 2010-11-07 15:38:45 -08:00
Bharat Mediratta d503513eca Create item_before_create and item_before_update events, and make 
Item_Model::data_file public.  This allows us to intercept and tweak
data files before saving the model which enables the max_size module.
 2010-11-06 21:54:28 -07:00
Bharat Mediratta f01fad1cd0 Deal in integers when doing aspect ratio operations. Fixes #1470. 2010-10-31 12:21:06 -07:00
Bharat Mediratta dff1a53696 All modules should be named Xxx_Core for extensibility. Fixes #1458. 2010-10-25 21:05:31 -07:00
Bharat Mediratta 1cc3d130bc Set the unit test timeout to 5 minutes 2010-10-25 21:04:40 -07:00
Bharat Mediratta 4dc451629c Allow access to the rest module when the gallery is wholly private. Fixes ticket #1452. 2010-10-24 17:03:40 -07:00
Bharat Mediratta db00958cee Add MJ12bot and Speedy Spider to the robot list. 2010-10-11 21:06:00 -07:00
Bharat Mediratta c4454f1f07 Copy system/config/user_agents.php over to gallery/config so that we can add to the list 2010-10-11 21:05:39 -07:00
Bharat Mediratta 84731437a7 Identify robots and don't let them save sessions. 2010-10-09 16:24:58 -07:00
Bharat Mediratta 5d4b683752 Fix for http://dev.kohanaframework.org/issues/3317 -- don't try to implicitly convert a string into an array. 2010-10-09 16:19:45 -07:00
Bharat Mediratta 349071f501 Change version to "3.0+ (git)". 2010-10-07 22:16:18 -07:00
Bharat Mediratta ea5a4e6cfe Updated for 3.0 release. 2010-10-05 00:10:17 -07:00
Bharat Mediratta 4b4a2f8d8d Set the version to 3.0 final (woot!). 2010-10-04 23:55:19 -07:00
Bharat Mediratta 3c40476b34 Not sure why digibug::close_window() changed in the listing, but it looks fine here. 2010-10-04 23:42:07 -07:00
Bharat Mediratta df378fcca8 Don't wrap the action in url::site() -- form::open() will do that for us. Fixes #1417. 2010-10-03 22:10:05 -07:00
Bharat Mediratta 6decb90eaf Oops, forgot to update installer to match change in 
f84782d620
 2010-10-02 17:15:33 -07:00
Bharat Mediratta a153ca0829 Detect the case where there are no more broken images and skip to the end. Fixes #1414. 2010-10-02 17:04:37 -07:00
Bharat Mediratta 161bbb9ba3 Proxy the BasicAuth authentication header in htaccess_works() so that 
if the entire Gallery is behind BasicAuth we share the same
credentials as the browser.  Fixes #1413.
 2010-10-02 16:44:31 -07:00
Bharat Mediratta 62f1bb06a2 Set the User-Agent field to "Gallery3" by default. Fixes #1408. 2010-10-02 13:46:47 -07:00
Bharat Mediratta c0022dc3c3 Fix a bug in the way we set the mime type for protected image renders. 
Also whitelist the digibug controller so that it's accessible when the
gallery is private, and don't expire old proxies right away since
Digibug may request the full size multiple times for different preview
operations.

Fixes ticket #1410.
 2010-10-01 21:45:45 -07:00
Bharat Mediratta 86981c5afb Use the "loading" image from themes/wind since it's no longer in gallery3/lib. 2010-10-01 21:09:14 -07:00
Bharat Mediratta 1c18200940 Protect ".ini" files in the example security stanza. Fixes ticket 2010-09-29 21:34:31 -07:00
Bharat Mediratta f84782d620 Stop caching all module variables in the vars table using the 
name=_cache row.  If that overflows, it will cause us to be unable to
load variables, and we can't recover from that.

Instead, use the Cache table.  Bump the gallery module to v40.  Fixes
ticket #1405.
 2010-09-29 20:47:43 -07:00
Bharat Mediratta ef8751468b Base64 encode the data result if the encoding param is set to "base64". 
Fixes #1400.
 2010-09-25 13:27:35 -07:00
Bharat Mediratta 85637a0826 Fix a bug introduced recently in 
f84c4a6192 where we were generating bad
SQL.  If we're checking for a conflict on a new item, the id is null
and we were doing a comparison that resulted in "id <> NULL" which
won't work -- in that case we need "id IS NOT NULL".

Fixes #1393.
 2010-09-23 20:45:27 -07:00
Tim Almdal d2bf5c9d1f Merge branch 'master' into talmdal_dev 2010-09-22 22:09:56 -07:00
Bharat Mediratta 7116f820ca Remove the 4 character minimum for group name length. Fixes ticket #1396. 2010-09-22 21:43:44 -07:00
Bharat Mediratta 790bf4e871 Prioritize using the value in graphics_toolkit_path over the standard 
path so that if you change that value in Admin > Settings > Advanced
we prefer it over other paths (which may be restricted by
open_basedir).  Fixes #1395.
 2010-09-22 21:35:49 -07:00
Bharat Mediratta 3b8475908f Use alternate path to the CoolIris slideshow that fixes the problem 
with Adobe not properly signing TextLayout.swz.  Fixes #1390.
 2010-09-22 20:55:27 -07:00
Tim Almdal 3a9bdebafd Override the jQuery autocomplete loading indicator with the theme specific small loading icon. 2010-09-21 21:38:32 -07:00
Tim Almdal d52d57b617 Cleanup links to some of the image links. 2010-09-21 19:54:38 -07:00
Tim Almdal 960db6d7e5 Move the image files into the themes. Leave the favicon and logo in lib/images. 2010-09-20 22:36:34 -07:00
Tim Almdal 8b21123493 When the lib/gallery.common.css was combined, the image urls did not point to the correct location. 
So lets fix that up. But first undo the reverts:
93d1a8103e "Revert 'Move the contents of lib/gallery.common.css into themes/wind/css/screen.php and themes/admin_wind/css/screen.php.  Most themers seem to copy the contents into their theme's screen.css anyway.'"
f14290f34f "Revert 'Clean up white space'"
ff8ee5bdfc "Revert 'Add some whitespace.'"
 2010-09-19 07:53:39 -07:00
Bharat Mediratta 93d1a8103e Revert "Move the contents of lib/gallery.common.css into themes/wind/css/screen.php and themes/admin_wind/css/screen.php. Most themers seem to copy the contents into their theme's screen.css anyway." 
This reverts commit 4251704175.
 2010-09-18 17:51:25 -07:00