Bharat Mediratta
b5cf24456f
Forbidden is a 403, not a 503.
2010-01-20 00:51:34 -08:00
Bharat Mediratta
76da85a1a0
Extend Gallery_Unit_Test_Case instead of Unit_Test_Case.
2010-01-19 22:38:19 -08:00
Bharat Mediratta
e39c8df19f
Fix some validation checks to check to see if the original was loaded
...
before deciding whether or not we changed a value.
Change valid_name to be cascading, not parallel.
2010-01-19 21:20:36 -08:00
Bharat Mediratta
6aee6cde25
Move data initialization into the constructor so that it happens
...
before validate() is called, which is important with our two phase web
controllers.
Make valid_parent smarter about moving existing items, vs new items.
2010-01-19 20:53:21 -08:00
Bharat Mediratta
e02675b730
Change "filename" to "name" in the edit album form. I'd rather have
...
consistency between field names than deal with underlying issues with
Forge bitching about the "name" property.
2010-01-19 19:31:01 -08:00
Bharat Mediratta
afe2128bb0
Make video/x-flv a valid movie mime_type
2010-01-19 19:30:18 -08:00
Bharat Mediratta
512910962d
Change "dirname" to "name" in the edit album form. I'd rather have
...
consistency between field names than deal with underlying issues with
Forge bitching about the "name" property.
2010-01-19 19:24:46 -08:00
Bharat Mediratta
c3ed64fc6c
Use property_exists() on our stdClass instead of array_key_exists()
2010-01-19 01:46:45 -08:00
Bharat Mediratta
c590fed132
Change rest::url() to take a module name and a resource. The module
...
does the rest. This function is symmetrical to rest::resolve.
2010-01-19 01:33:57 -08:00
Bharat Mediratta
f95442c314
Rewrite the tests entirely to cover the new REST code.
2010-01-19 01:17:29 -08:00
Bharat Mediratta
069a23e811
Make scope default to direct.
...
Add slug to the post params.
Fix minor output bug.
2010-01-19 01:16:59 -08:00
Bharat Mediratta
a587426cfd
Don't try to set the album cover for the grandparent if we don't have edit permissions for it.
2010-01-19 01:12:09 -08:00
Bharat Mediratta
cb7c263b47
Return arrays instead of calling rest::reply.
2010-01-19 00:36:40 -08:00
Bharat Mediratta
c059a444c7
Updated for model based validation. Fixed
...
change_photo_no_csrf_fails_test() which has been broken since we
deleted Rest_Controller.
2010-01-18 23:49:00 -08:00
Bharat Mediratta
4418993db9
Add slug_is_url_safe_test()
2010-01-18 23:38:39 -08:00
Bharat Mediratta
2687762aec
Update for model validation. Move the url safe tests into Item_Model_Test.
2010-01-18 23:38:18 -08:00
Bharat Mediratta
e06ceebaa6
No longer necessary; all photo and movie helper code is now in the model.
2010-01-18 23:25:09 -08:00
Bharat Mediratta
f021505208
No longer necessary; all relevant album helper code is now in the model.
2010-01-18 23:24:06 -08:00
Bharat Mediratta
c6bd3c5b26
Updated for model based validation.
...
change_album_no_csrf_fails_test() had been broken since we got rid of
REST_Controller, but was poorly written so we didn't realize it. Boo.
2010-01-18 23:23:31 -08:00
Bharat Mediratta
cc61e7a3e0
Update for model based validation. Use test helper. Reduce the code size greatly!
2010-01-18 23:11:02 -08:00
Bharat Mediratta
9eedf5c207
switch to test::starts_with().
2010-01-18 22:55:16 -08:00
Bharat Mediratta
71a8375554
Whitespace.
2010-01-18 22:52:58 -08:00
Bharat Mediratta
dc570aaca9
Switch from ORM_MPTT::$db_builder to db::build().
2010-01-18 22:52:23 -08:00
Bharat Mediratta
cfc0f3d0c0
Minor test cleanup.
2010-01-18 22:51:40 -08:00
Bharat Mediratta
703882f4df
Update valid_parent() to disallow moving an item inside its own hierarchy.
...
Move move_to() inside save()
2010-01-18 22:50:50 -08:00
Bharat Mediratta
efa4e230da
in move_to(), move the lock to before we do any calculations so that we have the latest data.
2010-01-18 21:40:00 -08:00
Bharat Mediratta
b4e6834a28
Added move_album_fails_wrong_target_type_test()
2010-01-18 21:14:43 -08:00
Bharat Mediratta
677fb08002
Updated tests to match what the expected new API for moving items.
...
Now to move an item, you just change its parent_id.
2010-01-18 21:12:26 -08:00
Bharat Mediratta
38c13760af
Switch to using test::random_name() to avoid integer names.
...
Fix up rename_photo_test.
2010-01-18 20:14:09 -08:00
Bharat Mediratta
0e2f4a7a37
Fix renaming in save() by moving the actual rename action under
...
parent::save(). This is consistent with other changes because all
filesystem operations happen after the database change is committed.
Also, inline rename() since it's fairly simple now.
2010-01-18 20:13:46 -08:00
Bharat Mediratta
b93000c0ce
Kohana ticket #2504 is resolved, so this test is no longer necessary.
2010-01-18 17:20:12 -08:00
Bharat Mediratta
1cfee16e38
In valid_name, don't query on the id if it's null.
2010-01-18 13:09:58 -08:00
Bharat Mediratta
92ed5d45e6
In item_rename_fails_with_existing_name_test switch validate() to
...
save() now that Kohana ticket #2504 is resolved.
2010-01-18 12:56:49 -08:00
Bharat Mediratta
ebb909625c
Merge branch 'master' into bharat_dev
2010-01-18 12:54:26 -08:00
Bharat Mediratta
06cabecd76
Coerce some integers to strings now that ORM isn't typecasting anymore.
2010-01-18 12:49:58 -08:00
Bharat Mediratta
a9f07986f6
The root parent id is 0, not null (this deviation exposed by the new lack of typecasting in ORM).
2010-01-18 12:39:42 -08:00
Bharat Mediratta
cf236a228a
Don't assert_same() now that typecasting is gone from ORM.
2010-01-18 12:37:20 -08:00
Bharat Mediratta
cac4692510
Don't use rand() as the name. Now that ORM::load_types() is gone, it
...
won't get coerced to a string, and then we wind up comparing:
12345 != 12345-12321
In the old approach, they'd both be strings so they'd be inequal. But
in the new approach the first value is an integer (sinced it came from
rand()) so the second value is typecast to an integer which drops
everything after the - sign so they appear equal.
2010-01-18 12:35:26 -08:00
Bharat Mediratta
b27907fff7
Merge branch 'master' into kohana_update
2010-01-18 12:22:18 -08:00
Bharat Mediratta
51427d5404
Verified
2010-01-18 12:21:57 -08:00
Bharat Mediratta
284788d964
Switch from stdClass to arrays which works around issues caused in
...
http://dev.kohanaphp.com/issues/2459 -- I don't exactly know why, but
the solutions are equivalent so I'm not going to dig too far.
2010-01-18 12:08:39 -08:00
Bharat Mediratta
41a392611c
Change DENY and ALLOW to "0" and "1" to match the fact that ORM no
...
longer typecasts values as of http://dev.kohanaphp.com/issues/2459
2010-01-18 12:08:05 -08:00
Bharat Mediratta
4eafe97b48
Reload $item after removing view permissions.
2010-01-18 11:57:23 -08:00
Bharat Mediratta
0dc184e99f
Overload url::current() and url::merge() to make the current url XSS
...
safe. Add tests to make sure that it doesn't relapse with future
Kohana changes. Fixes ticket #983 .
Ref: http://gallery.menalto.com/node/93738
2010-01-18 11:10:37 -08:00
Bharat Mediratta
dc286cc2bd
Add a test to verify that bug #2504 is still around. When this test
...
starts failing, the bug is fixed and we can go fix our code that works
around it.
2010-01-18 09:00:14 -08:00
Bharat Mediratta
53735f6b16
Convert a $root to item::root() to fix a test.
2010-01-17 23:50:42 -08:00
Bharat Mediratta
31ecb009ba
Get rid of urls_are_rawurlencoded_test -- it's no longer necessary
...
since we can't have unsafe slugs.
Add basic_validation_test.
2010-01-17 23:47:16 -08:00
Bharat Mediratta
06541f0e2a
Fix item_rename_fails_with_existing_name_test() -- broken because of
...
http://dev.kohanaphp.com/issues/2504
2010-01-17 21:49:48 -08:00
Bharat Mediratta
710e472edc
Fix rename_album_test()
2010-01-17 21:03:15 -08:00
Bharat Mediratta
b35a3c8b81
Fix rename_photo_test().
2010-01-17 20:54:08 -08:00
Bharat Mediratta