Tim Almdal
6dd6224165
Merge branch 'master' into talmdal_dev
2009-11-02 13:53:15 -08:00
Tim Almdal
45a7eb0248
Remove an extra trailing bracket.
2009-11-02 10:02:34 -08:00
Tim Almdal
809e738536
Try an new approach to extending forms. Create an extend_form event. For the first attempt replace the comment_add_form and item_add_form events.
2009-11-01 13:14:11 -08:00
Tim Almdal
376eb5673f
Convert the event handlers for the "identity provider changed" and "user_deleted" events to use ORM or the Kohana query builder to build the database update calls instead of coding the sql directly.
2009-11-01 10:22:56 -08:00
Tim Almdal
488b67014b
Revert "Cleanup typo and change what is passwed into the event. pass the group that the recaptch element should be attached to instead of the whole form. This allows the recaptch event to have no knowledge of the containing form."
...
Revert "Generalize the adding of the recaptcha form by changing the name of the event to recaptch_add. This prevents us from having to keep modifying the recaptch module anytime we add a form that requires recaptcha."
This reverts commits e45ea9359dbfafef95e8
2009-10-31 16:26:20 -07:00
Tim Almdal
903b5f6f67
Add identity_change handlers to resolve the ownership issues of comments, subscription, items and tasks.
2009-10-31 14:23:05 -07:00
Tim Almdal
90465012d1
Patch to clean up loose ends when a user is deleted.
...
* For items and tasks the owner id is set to admin
* For notification subscriptions, the subscription is deleted
* For comments, I've extracted the user name, email and url and set the guest_name, guest_email and guest_url columns while setting the author_id to identity::guest()->id
Fix for ticket #777 .
2009-10-30 14:23:57 -07:00
Tim Almdal
749d17ac16
Use the identity interface admin_user to retreive the admin user.
2009-10-29 11:18:35 -07:00
Tim Almdal
e45ea9359d
Cleanup typo and change what is passwed into the event. pass the group that the recaptch element should be attached to instead of the whole form. This allows the recaptch event to have no knowledge of the containing form.
2009-10-29 09:27:44 -07:00
Tim Almdal
bfafef95e8
Generalize the adding of the recaptcha form by changing the name of the event to recaptch_add. This prevents us from having to keep modifying the recaptch module anytime we add a form that requires recaptcha.
2009-10-29 09:21:07 -07:00
Tim Almdal
7ea13b3869
Normalize capitalization ticket #596
2009-10-28 12:15:52 -07:00
Tim Almdal
6fb116c53b
Merge branch 'master' into talmdal_dev
2009-10-26 06:24:51 -07:00
Chad Kieffer
288e14756d
Moved admin-comments styles from admin theme to module.
2009-10-25 23:50:24 -06:00
Chad Kieffer
76aa4bd1ef
Move comment and recaptcha CSS to their respective modules.
2009-10-25 23:32:49 -06:00
Tim Almdal
3c936d661a
Change the name of identity library from Identity to IdentityProvider. Create a helper class called identity to simplify call the Identity Provider. Move the contents of MY_Session.php to the new helper class and remove the MY_Session class
2009-10-22 13:11:03 -07:00
Tim Almdal
1b530e4680
Merge branch 'master' into talmdal_dev
...
Conflicts:
modules/user/views/admin_users.html.php
2009-10-19 06:27:18 -07:00
Chad Kieffer
5f56cbf997
Wrap all admin views in g-block and g-block content. This provides the means to visually separate the view's title and description from everything else. Primary admin view title should always be h1, and only one h1 per view. Removed some unused admin CSS id's.
2009-10-18 20:22:10 -06:00
Tim Almdal
090c4d016b
Merge branch 'master' into talmdal_dev
...
Conflicts:
lib/gallery.common.css
themes/admin_wind/views/admin.html.php
themes/night_wind/views/sidebar.html.php
themes/wind/views/sidebar.html.php
2009-10-18 09:28:48 -07:00
Chad Kieffer
ad0497a8d2
Drop our g-clearfix in favor of using jQuery UI's ui-helper-clearfix.
2009-10-17 12:58:31 -06:00
Tim Almdal
78ee4193b7
Remove all non Identity API methods from Identity.php. Created an MY_Session class to provide the user state changes in the session and a login.php helper that has the login form.
2009-10-16 10:06:58 -07:00
Tim Almdal
00eacd659f
Start simplifying the interface by moving the static methods from user.php and group.php. Tried creating a identity helper, but the helper identity.php was confused with the library Identity.php. So got around this by making the methods on Identity static and calling the instance within the static methods. Also temporarily moved the user.php and group.php back into the user module.
2009-10-16 08:53:31 -07:00
Chad Kieffer
121fcab5c8
Replaced most clear fix hacks with generic class.
2009-10-07 00:46:02 -06:00
Chad Kieffer
d581bbbd1e
Renamed more CSS selectors from gName to g-name.
2009-10-04 15:53:00 -06:00
Chad Kieffer
3e6ba7acc3
Renamed most, if not all css selectors from gName to g-name. Moved a few shared images from wind to lib. Deleted unused images in the admin_wind. This will likely break a few ajax features.
2009-10-04 00:27:22 -06:00
Chad Kieffer
9145331fd4
Renamed and moved gOdd/gEven CSS classes.
2009-10-03 12:33:53 -06:00
Tim Almdal
a210878725
Merge branch 'master' into talmdal_dev
2009-09-30 07:37:14 -07:00
Tim Almdal
60d35b8992
Use the block_manager to manage site sidebar panels. Fixes ticket #110 .
...
* Extend block_manager to handle sidebar blocks. get_available has become get_available_admin_blocks, get_list becomes get_admin_list.
* Create new functions get_available_site_blocks which will look for gallery_block get_available_site_blocks.
* Refactor sidebar_blocks into a separate function and then call block_manager::get_html(site.sidebar). Convert image_block to use block management instead of theme::sidebar_blocks
* Change the block_manager api so that the theme is passed into the get method. convert info to the new sidebar block approach
* Convert the user module to use the new sidebar block structure. remove the installers for info and image_block modules.
* Convert tag and rss modules to the new sidebar framework. reset the version number to 1 for info and image_block modules.
* Change the get_html method to ignore empty blocks and change the individual handlers to return an empty string if no block is generated
* Add a warning message if no sidebar blocks are active and provide a link to the admin page that configures the sidebar.
2009-09-30 07:31:12 -07:00
Chad Kieffer
72672bda39
Replaced gButtonLink with g-button.
2009-09-30 08:04:49 -06:00
Chad Kieffer
daa3a2b43c
First round of CSS refactor updates. Added calls to gallery.common.css from wind and admin_wind. Replaced basic text align and block float classes. Removed section #2 from both themes screen styles.
2009-09-30 00:32:52 -06:00
Tim Almdal
b310fab1f8
Change the link on the "Be first to comment" link to do a request to the server to get the comment add form. Fixes ticket #699 .
2009-09-22 07:59:26 -07:00
Bharat Mediratta
aed7ce9161
Specify a page anchor for the comments block.
2009-09-13 14:25:17 -07:00
Bharat Mediratta
21d6e17efa
Don't add another comment form every time you click the [Add a
...
comment] button.
2009-09-13 14:19:04 -07:00
Bharat Mediratta
d5cd6a92e7
Rename $comment_model to $comments, this time without stomping on the
...
pre-existing variable.
2009-09-01 20:40:18 -07:00
Bharat Mediratta
eab5d71d06
Revert "Rename $comment_model to $comments."
...
This reverts commit d85a8b20bb
2009-09-01 20:39:08 -07:00
Andy Staudacher
1d30691452
Add missing mark_clean() for t() calls with %attr parameter.
2009-09-01 12:14:23 -07:00
Andy Staudacher
53711225ac
XSS / style fixes for newly detected issues (after fixing XSS scanner)
2009-09-01 01:28:52 -07:00
Andy Staudacher
2bc73e2e36
Fix XSS vectors in HTML attributes (mostly t() calls)
2009-08-31 21:51:57 -07:00
Andy Staudacher
fc294c2777
XSS fixes in admin_comments.html.php
2009-08-30 21:26:23 -07:00
Andy Staudacher
b9bd1681a3
Update all code to use helper method html::clean(), html::purify(), ... instead of SafeString directly.
2009-08-29 22:54:20 -07:00
Andy Staudacher
a5dfc81a8f
Merge commit 'upstream/master'
...
Conflicts:
modules/akismet/views/admin_akismet.html.php
modules/comment/helpers/comment_rss.php
modules/gallery/helpers/gallery_rss.php
modules/gallery/libraries/I18n.php
modules/gallery/views/permissions_browse.html.php
modules/gallery/views/simple_uploader.html.php
modules/info/views/info_block.html.php
modules/organize/controllers/organize.php
modules/organize/views/organize.html.php
modules/organize/views/organize_album.html.php
themes/default/views/album.html.php
themes/default/views/movie.html.php
themes/default/views/photo.html.php
2009-08-29 14:17:48 -07:00
Chad Kieffer
a9fcec755a
Merge branch 'master' of git@github.com:gallery/gallery3
2009-08-29 14:02:29 -06:00
Chad Kieffer
5db0b68a70
Update status message styles. Lighten backgrounds, don't show background on Admin Maintenance rows, and added gModuleStatus class.
2009-08-29 14:01:04 -06:00
Andy Staudacher
c01ac42c46
Refactor all calls of p::clean() to SafeString::of() and p::purify() to SafeString::purify().
...
Removing any p::clean() calls for arguments to t() and t2() since their args are wrapped in a SafeString anyway.
2009-08-29 12:48:40 -07:00
Bharat Mediratta
cd1fd4989f
Add a test for Comment_Model::viewable().
2009-08-29 12:22:00 -07:00
Bharat Mediratta
d85a8b20bb
Rename $comment_model to $comments.
2009-08-29 11:48:49 -07:00
Tim Almdal
38b2efc44c
Fix for 641... extend viewable functionality to comments. Viewable unit test is not working.
2009-08-29 11:43:10 -07:00
Tim Almdal
6de10a54dd
Fix typo in the parameter list
2009-08-29 11:21:30 -07:00
Tim Almdal
1d5262f9c3
Fix ticket #591 : reCaptcha always on the page.
...
1) move creating the "Add a comment" button into the comments.html.php
2) use $.get() to retrieve the comment add form
2009-08-28 13:44:01 -07:00
Bharat Mediratta
4828db003f
Remove 'ENGINE=InnoDB' specification from tables that we create. Use
...
the system's default table specification. Fixes ticket #597 .
2009-08-27 15:47:54 -07:00
Bharat Mediratta
7863aa16f9
Update tags module to notify modules when items related to a tag are
...
affected. Practically speaking this means that we'll reindex items
when tags are added or removed from them.
API change:
Remove item_related_updated_batch event.
Rationale:
While this is an efficient event, it requires module developers to
support two event APIs for staying up to date and increases the
likelihood that they'll forget one and have data corruption. Force
them all through the slower but more reliable pipe, for now. We
can always try to improve efficiency by using the batch_start and
batch_stop events.
2009-08-08 14:30:21 -07:00
