stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-05-21 11:59:13 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,074 Commits 4 Branches 0 Tags
77ec06166320dee631bbffcf3d57b0e2debcb157
Commit Graph

783 Commits

Author SHA1 Message Date
Bharat Mediratta
3e1743b21f Add a module variable containing extra paths to search for binaries. 
Fixes ticket #1384.
 2010-09-16 20:43:48 -07:00
Bharat Mediratta
5e316f78c6 Restrict viewing user profile pages to registered users only, but 
provide a "show_user_profiles_to" setting to allow admins to open it
up to everybody (choices there are "registered_users", "admin_users"
or "everybody").  Fixes ticket #1378.
 2010-09-16 15:17:00 -07:00
Bharat Mediratta
70f15c6662 Add ability to sort albums by name. Fixes ticket #1377. 2010-09-14 19:51:43 -07:00
Bharat Mediratta
1a0d76c43e When moving a single item, just copy its permissions from its parent 
album.  This is totally legal since an items permissions must be the
same as its parent's, and it's much faster for large installs where
a complete recalculation can be very costly.  Should fix #1360.
 2010-09-13 22:23:09 -07:00
Bharat Mediratta
19750cb0d5 When deleting items, choose the first *viewable* peer as the album 
cover.  Normally, all items are equally viewable, but in our unit
tests we occasionally have the scenario where peers have different
viewability settings which is internally consistent although only
possible if you set the fields manually.
 2010-09-13 22:02:19 -07:00
Bharat Mediratta
b08bf26d2d Ignore the private gallery settings if we're in the cli SAPI. It 
breaks the upgrader.  Fixes #1361, thanks to Romain LE DISEZ.
 2010-09-12 14:34:49 -07:00
Bharat Mediratta
a98841613a LOWER() the slug and name in the find_dupes functions since DISTINCT 
is case sensitive, but our dupe validation is not.  Fixes ticket #1367.
 2010-09-12 14:30:25 -07:00
Bharat Mediratta
b4fb11f8d5 Only call $theme->item() if we're in a non admin theme. 2010-09-11 21:40:57 -07:00
Bharat Mediratta
bfd92ac6f2 Use $theme->item() instead of $theme->item, otherwise 
isset($theme->item) may return true even when we don't have an actual
Item_Model in there.
 2010-09-11 21:38:46 -07:00
Bharat Mediratta
cbb6967405 Detect out-of-date modules and put up a message for site admins. 
Fixes ticket #1353.
 2010-09-08 20:59:40 -07:00
Bharat Mediratta
391a90e3ce Detect when a module fails to upgrade properly and put up an 
informative message to help the user know that she needs to get a
newer copy of the module.  Fixes ticket #1189.
 2010-09-08 20:36:22 -07:00
Bharat Mediratta
afeb3bb8c4 Fix typo. 2010-09-07 22:13:30 -07:00
Bharat Mediratta
00c1100d9d Add Macedonian. Fixes ticket #1345. 2010-09-07 21:30:53 -07:00
Bharat Mediratta
fa1fe47b6a Use the absolute site url when logging out of the admin site else we 
wind up with weird url doubling effects.  Fixes ticket #1342.
 2010-09-06 22:13:41 -07:00
Bharat Mediratta
886b88fccf Revert "change the Setswana locale from tn_ZA to tn_BW since it's mostly" 
This reverts commit 2d948cb39f.

Valiant said that tn_ZA is right:
http://gallery.menalto.com/node/97840#comment-352865
 2010-09-06 18:49:37 -07:00
Bharat Mediratta
8a36c24f39 Fix some broken identity APIs: 
- add_user_to_group and remove_user_from_group should take Group_Definition instances
  to be consistent
- add_user_to_group and remove_user_from_group in drivers/IdentityProvider.php should
  not be static
 2010-09-06 18:20:46 -07:00
Bharat Mediratta
2d948cb39f change the Setswana locale from tn_ZA to tn_BW since it's mostly 
Botswana anyway according to @sagemaniac in
http://gallery.menalto.com/node/97840
 2010-09-06 14:05:48 -07:00
Bharat Mediratta
b3b6021b0a Don't bomb on the race condition when we're trying to create the 
gallery/_cache row and it already exists.  Fixes ticket #1338.
 2010-09-06 12:41:27 -07:00
Bharat Mediratta
46b30ce949 Add Setswana (tn_ZA). Fixes ticket #1336. 2010-09-05 22:00:28 -07:00
Bharat Mediratta
ca0c3b3e7f Force "Options +FollowSymLinks" since that's a requirement for 
mod_rewrite to work.  This is surprisingly obscure in the docs.
Thanks to bromide for turning this up in
http://gallery.menalto.com/node/97791!
 2010-09-05 21:25:46 -07:00
Bharat Mediratta
db75ac642a Use the title of the root album as the site title for all RSS feeds. 
Fixes ticket #1307.
 2010-09-04 13:40:39 -07:00
Bharat Mediratta
32d1892068 Follow on to 2a86446249c4782287e1e6e472f422b851c2fb47; fix a bug where 
guest access to admin pages fails because we try to go to the login
page but you can't do that from the admin theme.  Thanks to mamouneyya
for catching this.
2a86446249
 2010-09-02 22:53:06 -07:00
Bharat Mediratta
2a86446249 Handle the case of a completely private Gallery separately and just 
put up a login page, very similar to the way that the maintenance mode
login page works.  Fixes ticket #1056.
 2010-09-02 00:50:02 -07:00
Bharat Mediratta
23b566e592 One more adjustment for ticket #1216. The packaging process forces 
the default email address for admin to be unknown@unknown.com and when
that happens the gallery_event::user_updated() event listener fires
and sets the default values.  This is hard to work around, so let's
just roll with it and use unknown@unknown.com as our default placeholder.

So now, if an admin sets their email address and the current values
are unknown@unknown.com we adopt the admin's email address for the
site's mail_from/reply_to fields.
 2010-09-01 23:52:19 -07:00
Bharat Mediratta
7477f0119c Explain wtf we're doing in user_updated. 2010-09-01 23:39:01 -07:00
Tim Almdal
545177c648 Merge branch 'master' of git@github.com:gallery/gallery3 2010-09-01 23:19:50 -07:00
Tim Almdal
04f6646b06 Hopefully the third and final patch for #1216. Set the default from and reply-to addresses to an empty string. The first time the user model is saved, set the sendmail from and reply-to addresses. Requires an update to gallery version 38. 2010-09-01 23:19:43 -07:00
Bharat Mediratta
70c8572ea1 Make RENAME TABLE operations idempotent so that in case there's a 
failure of some kind we can restart the upgrade and it'll continue.
Fixes ticket #1325.
 2010-09-01 22:19:44 -07:00
Tim Almdal
1f621d9827 Refine the patch for #1216. If the admin user changes their email address update the sendmail from and reply_to fields in advanced settings. Also change this if the identity provider has changed. 2010-09-01 21:24:41 -07:00
Bharat Mediratta
78c590ebae Don't use HTTP_HOST to get the hostname. We force that to 
"example.com" when we are using the CLI so we'll get inconsistent
behavior between CLI and the web interface.

For now hardcode it to be example.com so that it's clear.  But to do
it right we need an after_install step which actually fixes it up.
And probably an after_upgrade step as well.
 2010-08-31 21:07:43 -07:00
Tim Almdal
e09c6dbd5e Patch for ticket #1216. Move the values that were in the sendmail config file and store them as gallery module variables. Requires a version number bump to 37. 2010-08-31 20:45:09 -07:00
Bharat Mediratta
2c717b18d3 Don't concatenate two strings together as an argument for t() or t2(); 
the l10n_scanner cannot parse it properly and drops those from the
localization list.  Fixes ticket #1284.
 2010-08-29 20:04:02 -07:00
Bharat Mediratta
0879a26e1c Put a message in the logs when we find a string that's not 
concatenated.  Concatenating them is not easy because the two strings
can have different quoting (single vs. double quotes) and may have to
be treated separately in the code.

Fixes ticket #1321
 2010-08-29 19:55:21 -07:00
Bharat Mediratta
4c8445852d Bump gallery module to v36 and add a favicon_url variable, which we 
expose in Admin > Appearance > Theme Options and defaults to
lib/images/favicon.ico.

Thix fixes ticket #1312.
 2010-08-29 16:27:32 -07:00
Bharat Mediratta
24b511b44a Move theme::get_edit_form_admin into admin_theme_options since that's 
the only place where it's used and the theme helper is loaded on every
page view.
 2010-08-29 16:03:09 -07:00
Bharat Mediratta
a08cd0db4e Add a "visible_title_length" variable that defaults to 15 and use that 
as the max title length when we do title truncation in the wind theme.
Bump the gallery module to 35.
 2010-08-28 21:58:28 -07:00
Bharat Mediratta
dc80cde379 Add "captcha_protect_form" event that the recaptcha module grabs and 
uses to add a captcha to the end of the first group in the form.  If
there are no groups, it adds the captcha at the end of the form.
Updated user_profile and comment forms to use it.
 2010-08-22 13:00:08 -07:00
Bharat Mediratta
adc4061125 Use better error messages in form validation. 2010-08-22 12:49:01 -07:00
Bharat Mediratta
04add75f6f Get rid of the move dialog and move option. Instead, replace it with 
a call to Organize with the appropriate album open.  I have not yet
figured out how to get the SWF code to highlight the active image, but
that's coming.  Partial fix for #1204.
 2010-08-22 00:27:24 -07:00
Bharat Mediratta
4a01aaddc9 Verify that the ffmpeg path still exists by using file_exists(). This 
is a lightweight way to catch the case where ffmpeg gets deleted.
Fixes ticket #1303.
 2010-08-21 15:10:46 -07:00
Bharat Mediratta
6563ad1393 Return the right content type for album thumbnails (based on the album cover's mime type) 2010-08-14 22:00:53 -07:00
Bharat Mediratta
b562751fdb Don't expose members of an item that are not viewable by the end user. 
This leaks item ids, but no other information about the item.  Fixes
ticket #1292.
 2010-08-14 15:45:16 -07:00
Bharat Mediratta
50e3230d79 Add a key on access_caches.item_id. Without this, the Fix task query 
to find missing access_caches is very slow.  Bump Gallery module to v34.
 2010-08-14 15:10:07 -07:00
Bharat Mediratta
d9f8c8a295 Rebuild access_caches rows if they're missing, as necessary. Fixes ticket #1289. 2010-08-14 14:56:28 -07:00
Bharat Mediratta
3c18762fda Change the way that this works. Now instead of sending back the image 
metadata and the data itself JSON encoded, we just send back the raw
data with the right Content-Type.  This, combined with code in
Item_Model::as_restful_array() that swaps in /rest/data urls as
appropriate, means that the RESTful payload has consistent urls when
permissions are in play.
 2010-08-09 22:54:57 -07:00
Tim Almdal
58bf479f4c Merge branch 'master' of git@github.com:gallery/gallery3 2010-08-08 17:29:29 -07:00
Tim Almdal
1ad1f9517f Fix for ticket #1279. In admin themes sanitize the theme name before checking that theme.info exists. 2010-08-08 17:29:22 -07:00
Bharat Mediratta
acb1faaa59 Cache the group ids for a day to trade off performance for security updates. 
Fixes ticket #1227.
 2010-08-08 17:25:31 -07:00
Bharat Mediratta
6a8c1f5e85 whitespace fix. 2010-08-08 17:19:51 -07:00
Bharat Mediratta
2dda8e22a7 Use the gallery helper date/time functions wherever we format date 
time for the browser.  Fixes ticket #1278.
 2010-08-08 16:54:31 -07:00