Commit Graph
3969 Commits
Author SHA1 Message Date
Bharat Mediratta 349071f501 Change version to "3.0+ (git)". 2010-10-07 22:16:18 -07:00
Bharat Mediratta 4b4a2f8d8d Set the version to 3.0 final (woot!). 2010-10-04 23:55:19 -07:00
Bharat Mediratta 3c40476b34 Not sure why digibug::close_window() changed in the listing, but it looks fine here. 2010-10-04 23:42:07 -07:00
Bharat Mediratta df378fcca8 Don't wrap the action in url::site() -- form::open() will do that for us. Fixes #1417. 2010-10-03 22:10:05 -07:00
Bharat Mediratta a153ca0829 Detect the case where there are no more broken images and skip to the end. Fixes #1414. 2010-10-02 17:04:37 -07:00
Bharat Mediratta 161bbb9ba3 Proxy the BasicAuth authentication header in htaccess_works() so that
if the entire Gallery is behind BasicAuth we share the same
credentials as the browser.  Fixes #1413.
2010-10-02 16:44:31 -07:00
Bharat Mediratta 62f1bb06a2 Set the User-Agent field to "Gallery3" by default. Fixes #1408. 2010-10-02 13:46:47 -07:00
Bharat Mediratta c0022dc3c3 Fix a bug in the way we set the mime type for protected image renders.
Also whitelist the digibug controller so that it's accessible when the
gallery is private, and don't expire old proxies right away since
Digibug may request the full size multiple times for different preview
operations.

Fixes ticket #1410.
2010-10-01 21:45:45 -07:00
Bharat Mediratta 86981c5afb Use the "loading" image from themes/wind since it's no longer in gallery3/lib. 2010-10-01 21:09:14 -07:00
Bharat Mediratta f84782d620 Stop caching all module variables in the vars table using the
name=_cache row.  If that overflows, it will cause us to be unable to
load variables, and we can't recover from that.

Instead, use the Cache table.  Bump the gallery module to v40.  Fixes
ticket #1405.
2010-09-29 20:47:43 -07:00
Bharat Mediratta ef8751468b Base64 encode the data result if the encoding param is set to "base64".
Fixes #1400.
2010-09-25 13:27:35 -07:00
Bharat Mediratta 85637a0826 Fix a bug introduced recently in
f84c4a6192 where we were generating bad
SQL.  If we're checking for a conflict on a new item, the id is null
and we were doing a comparison that resulted in "id <> NULL" which
won't work -- in that case we need "id IS NOT NULL".

Fixes #1393.
2010-09-23 20:45:27 -07:00
Bharat Mediratta 7116f820ca Remove the 4 character minimum for group name length. Fixes ticket #1396. 2010-09-22 21:43:44 -07:00
Bharat Mediratta 790bf4e871 Prioritize using the value in graphics_toolkit_path over the standard
path so that if you change that value in Admin > Settings > Advanced
we prefer it over other paths (which may be restricted by
open_basedir).  Fixes #1395.
2010-09-22 21:35:49 -07:00
Bharat Mediratta 3b8475908f Use alternate path to the CoolIris slideshow that fixes the problem
with Adobe not properly signing TextLayout.swz.  Fixes #1390.
2010-09-22 20:55:27 -07:00
Bharat Mediratta fad1f05203 The Kohana folks removed the cache cleanup code back in
http://dev.kohanaframework.org/projects/kohana2/repository/revisions/4605

So now our cache entries don't expire.  For now, do cache expiration
whenever we render Admin > Maintenance, since that's the type of place
that users will go when they want their cache to expire anyway.
2010-09-18 17:46:28 -07:00
Bharat Mediratta a1b1d323af When looking for G2 urls in the g2_map, try also swapping spaces for +
in case the url had spaces in it.  Fixes ticket #1388.
2010-09-18 16:46:15 -07:00
Bharat Mediratta 6bb75f623e Fix a bug in that last commit where I was treating resource_type as a function. 2010-09-18 16:34:48 -07:00
Bharat Mediratta 77ec061663 Redirect to the root album when there's an empty path and empty id.
Fixes ticket #1387.
2010-09-18 15:12:43 -07:00
Bharat Mediratta 8ee25157ec Fix a bug in the way that we calculate expiration dates for old
comments by using Database_Expression.  Fixes ticket #1386.
2010-09-18 14:29:52 -07:00
Bharat Mediratta 8135429430 Checkpoint. 2010-09-17 13:39:48 -07:00
Bharat Mediratta 3e1743b21f Add a module variable containing extra paths to search for binaries.
Fixes ticket #1384.
2010-09-16 20:43:48 -07:00
Bharat Mediratta 64dfccc4ed Preserve the image extension on the temp file that we create for
rotating images.  Some versions of GD won't work if we don't do this.
Fixes ticket #1375.
2010-09-16 20:04:22 -07:00
Bharat Mediratta de2f9baeee Add a link to
http://codex.gallery2.org/Gallery3:Choosing_A_Graphics_Toolkit to help
users choose a graphics toolkit.  Fixes ticket #1372.
2010-09-16 19:34:42 -07:00
Bharat Mediratta 5e316f78c6 Restrict viewing user profile pages to registered users only, but
provide a "show_user_profiles_to" setting to allow admins to open it
up to everybody (choices there are "registered_users", "admin_users"
or "everybody").  Fixes ticket #1378.
2010-09-16 15:17:00 -07:00
Bharat Mediratta 3e3098956c Convert the guest_url ORM validation failure back to the url form
parameter and put in a message requiring a valid url.  Fixes ticket
2010-09-16 14:19:28 -07:00
Bharat Mediratta 70f15c6662 Add ability to sort albums by name. Fixes ticket #1377. 2010-09-14 19:51:43 -07:00
Bharat Mediratta 4b8d6beb5e Report the graphics toolkit in the platform block. 2010-09-14 19:40:54 -07:00
Bharat Mediratta af24aa5abe The full_name field is required to be NOT NULL. Not really sure why
this is a hard requirement, but for now in User_Model::save() let's
use the empty string if the field itself is null.  Fixes ticket #1371.
2010-09-14 11:47:53 -07:00
Bharat Mediratta 1a0d76c43e When moving a single item, just copy its permissions from its parent
album.  This is totally legal since an items permissions must be the
same as its parent's, and it's much faster for large installs where
a complete recalculation can be very costly.  Should fix #1360.
2010-09-13 22:23:09 -07:00
Bharat Mediratta 19750cb0d5 When deleting items, choose the first *viewable* peer as the album
cover.  Normally, all items are equally viewable, but in our unit
tests we occasionally have the scenario where peers have different
viewability settings which is internally consistent although only
possible if you set the fields manually.
2010-09-13 22:02:19 -07:00
Bharat Mediratta b08bf26d2d Ignore the private gallery settings if we're in the cli SAPI. It
breaks the upgrader.  Fixes #1361, thanks to Romain LE DISEZ.
2010-09-12 14:34:49 -07:00
Bharat Mediratta a98841613a LOWER() the slug and name in the find_dupes functions since DISTINCT
is case sensitive, but our dupe validation is not.  Fixes ticket #1367.
2010-09-12 14:30:25 -07:00
Bharat Mediratta 19034d140e Rename the class to Item_Model_Core so that it can be overloaded.
Related to ticket #1368.
2010-09-12 13:35:50 -07:00
Tim Almdal bd532f6c88 Merge branch 'master' of git@github.com:gallery/gallery3 2010-09-12 10:57:41 -07:00
Tim Almdal ac64614d4d Path for ticket #1140. Add a size0 to the tag cloud. 2010-09-12 10:53:06 -07:00
Bharat Mediratta f84c4a6192 Uniqify the name and slug when we move an item to a new location with
a conflict.  This fixes #1364.
2010-09-11 23:37:12 -07:00
Bharat Mediratta 9f11d8ad83 Log the JSON response on errors so that we can figure out what's going
wrong.  This will help diagnose #1364 which appears to be an
ORM_Validation_Exception, except the actual output is getting eaten by
the Organize SWF so we can't see it without snooping network traffic.
2010-09-11 22:38:47 -07:00
Bharat Mediratta cc4a54a3d6 Fix bug introduced in b6fa33faf7. Don't
try to use $(this).data("reload.location") if it hasn't been set,
which can happen if Flash isn't available.  Fixes #1362
2010-09-11 22:18:53 -07:00
Bharat Mediratta b4fb11f8d5 Only call $theme->item() if we're in a non admin theme. 2010-09-11 21:40:57 -07:00
Bharat Mediratta bfd92ac6f2 Use $theme->item() instead of $theme->item, otherwise
isset($theme->item) may return true even when we don't have an actual
Item_Model in there.
2010-09-11 21:38:46 -07:00
Bharat Mediratta c9c4f96100 Tune timeouts to work better on large installs. 2010-09-11 21:36:38 -07:00
Bharat Mediratta 14ae1fde25 Use the actual csrf token, not the placeholder (url::site doesn't
replace that).  Fixes ticket #1361
2010-09-11 10:41:47 -07:00
Bharat Mediratta cef7ca9cf2 Change tag url form to be /tag/{name} from /tags/show/{id}. This is
a much friendlier url format.  Fixes ticket #1363.
2010-09-11 10:26:48 -07:00
Bharat Mediratta 34a71e7cd3 Verified. 2010-09-11 01:48:44 -07:00
Bharat Mediratta 509b647c65 upgrader/index does not require CSRF 2010-09-11 01:48:26 -07:00
Bharat Mediratta 67f45cfa78 Add CSRF protection to the upgrader. And update the CLI output so
that it tells you which modules failed to upgrade properly.  Fixes
ticket #1359.
2010-09-11 01:46:45 -07:00
Bharat Mediratta a88b3f5808 Implement IdentityProvider_Gallery_Driver::admin_user() properly such
that it's not hardcoded to return the user with id 2.  Create
user::admin_user() which finds an appropriate admin and returns it.
Fixes #1358.
2010-09-11 00:47:48 -07:00
Bharat Mediratta 6640bd18ca Merge branch 'master' of github.com:gallery/gallery3 2010-09-10 23:09:52 -07:00
Bharat Mediratta 5892712b23 If the user is not an admin, don't 403 -- instead just redirect them
to the root album.  Fixes ticket #1356.
2010-09-10 23:01:47 -07:00