Commit Graph

176 Commits

Author SHA1 Message Date
Bharat Mediratta
0bc92614d3 Checkpoint 2009-12-22 16:48:18 -08:00
Bharat Mediratta
6601bb29d9 Update. 2009-12-22 16:25:31 -08:00
Bharat Mediratta
a6da027aad The default value for $offset should always be null (according to the
new K24 ORM).

Fix up a bad where tuple in the test.
2009-12-22 16:22:24 -08:00
Bharat Mediratta
71e154b674 Use a Database_Expression to handle the MAX() function. 2009-12-22 16:13:08 -08:00
Bharat Mediratta
fda4227bb1 Latest K24 does not automatically add an id attribute to every form
element with the same value as the name.  Yay!  That was a weird and
unexpected behavior.
2009-12-22 14:00:52 -08:00
Bharat Mediratta
ca293db214 Don't rely on implicit object -> id conversion, that doesn't work with K24's Database_Builder::where() 2009-12-22 13:57:49 -08:00
Bharat Mediratta
9c5df1d31b Fix preambles, and fix the File_Structure_Test to be more lenient
because of preamble variation in K24.
2009-12-21 19:59:44 -08:00
Bharat Mediratta
e0dc520648 Updated for recent K24 Forge changes. 2009-12-21 17:26:24 -08:00
Bharat Mediratta
cc4d7c672c Update database tests for K24. Use a mock database that we load
through the framework so that we're properly testing the
Database_Builder, it's a lot cleaner than what we had before.
2009-12-21 15:47:11 -08:00
Bharat Mediratta
e1f43ad403 Updated for K24 2009-12-21 12:22:19 -08:00
Bharat Mediratta
5df1dc135b Fix some bugs in the cache database driver, and update the tests for K24. 2009-12-21 12:13:25 -08:00
Bharat Mediratta
bfcd99f3f2 Updated for K24 2009-12-21 11:30:34 -08:00
Bharat Mediratta
a22aa4ab05 Forgot to rename the file when I renamed the class. 2009-12-21 11:29:28 -08:00
Bharat Mediratta
0736cf203b In Kohana 2.4, ORM no longer does the find_all() call for us when we
retrieve related ORMs.  If we tack a find_all() on the end, it breaks
the User_Definition interface so create User_Model::groups() and
Groups_Model::users() as glue.
2009-12-17 21:32:53 -08:00
Bharat Mediratta
d5c35210b9 Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev 2009-12-06 21:38:47 -08:00
Tim Almdal
16bed1ffd5 Remove the hidden form variable _method which was used in the no longer rest controllers. 2009-12-06 21:32:27 -08:00
Bharat Mediratta
dee3ee81e2 Database::orwhere() is now Database_Builder::or_where() 2009-11-26 20:25:32 -08:00
Bharat Mediratta
e8fb773b68 Update all portable where clauses to the new Kohana 2.4 format. 2009-11-26 19:33:03 -08:00
Bharat Mediratta
1fd0e14359 Convert all DB where() calls to take 3 arguments.
Convert all open_paren() calls to and_open() or or_open() as appropriate.
2009-11-26 12:09:04 -08:00
Bharat Mediratta
f50dbd992d Merge branch 'master' of git@github.com:gallery/gallery3 into bharat_dev
Conflicts:
	modules/gallery/controllers/rest.php
2009-11-25 13:40:47 -08:00
Bharat Mediratta
2e420522ec Preliminary work to cut over to Kohana 2.4
- Kohana::log() -> Kohana_Log::add()
- Kohana::config_XXX -> Kohana_Config::instance()->XXX
- Implement View::set_global in MY_View
- Updated Cache_Database_Driver to latest APIs
- ORM::$loaded -> ORM::loaded()
- Updated item::viewable() to use K2.4 parenthesization
2009-11-25 13:22:24 -08:00
Tim Almdal
dc67cf6481 Remove the REST_Controller and assorted baggage. Completes ticket #917 2009-11-25 13:02:14 -08:00
Tim Almdal
2d5c232c42 Refactor the album, movie and photo handling to remove the REST_Controller. Partial fix for ticket #917 2009-11-25 12:46:04 -08:00
Tim Almdal
0bf81f0381 Remove a debugging statement 2009-11-25 09:16:49 -08:00
Tim Almdal
454a96f48f Refactor the tags to remove the REST_Controller. Partial fix for ticket #917 2009-11-25 09:08:33 -08:00
Tim Almdal
4c3b9e363a Refactor the comment module as part of ticket: #917 "Remove Rest Controller"
* Remove the methods create, update, delete, get_edit_form as there are not used
* Change the return when a comment is created to return the html for the new comment.
  This saves a second get request to down load the comment.
2009-11-25 08:12:50 -08:00
Bharat Mediratta
3ed7a5af46 Rename I18n to Gallery_I18n to avoid conflict with Kohana 2.4 2009-11-24 19:24:02 -08:00
Bharat Mediratta
52b12725ea Updated. 2009-11-24 16:35:50 -08:00
Tim Almdal
fc41d09134 Revert "Simplify the maintenance of the xss golden file by having each module contibute its own golden file to a consolidated one. This will make it easier for -contrib modules or themes to be included in the xss security test w/o having to keep modifying a central golden file."
This reverts commit 4fe5801c88.
2009-11-18 10:54:01 -08:00
Tim Almdal
4fe5801c88 Simplify the maintenance of the xss golden file by having each module contibute its own golden file to a consolidated one. This will make it easier for -contrib modules or themes to be included in the xss security test w/o having to keep modifying a central golden file. 2009-11-18 10:34:39 -08:00
Tim Almdal
3f600d46e4 Update the xss golden file so tests pass. 2009-11-18 08:53:35 -08:00
Bharat Mediratta
9379308f91 Xss data update 2009-11-15 19:36:02 -08:00
Bharat Mediratta
64ef86a8ee Updated xss data. 2009-11-15 19:27:35 -08:00
Bharat Mediratta
731ff800cd Use 'git ls-files' instead of glob() so that we only check files known
to Git.  This means that local files which we choose to exclude from
git don't have to follow the same permission model.
2009-11-15 19:20:43 -08:00
Bharat Mediratta
5a27ce7e8f Save/restore $_SERVER before/after tests to avoid contamination.
Fix albums/photos tests to make sure we're really getting the
  HTTP_REFERER back.
2009-11-15 19:10:56 -08:00
Tim Almdal
f176bc7299 Correct spacing 2009-11-06 23:19:48 -08:00
Tim Almdal
808fd4d3a0 Update the modified with a local fix for Kohana ticket #2298 2009-11-01 09:32:42 -08:00
Tim Almdal
5212deb5b1 Merge branch 'master' into talmdal_dev 2009-10-24 10:09:57 -07:00
Tim Almdal
607662d66b When an item is renamed or move insure that the target file name doesn't exist. fixes ticket #694 2009-10-24 10:08:48 -07:00
Tim Almdal
d0186436de Merge branch 'master' into talmdal_dev
Conflicts:
	modules/gallery/tests/Albums_Controller_Test.php
	modules/user/helpers/user.php
2009-10-23 10:01:40 -07:00
Tim Almdal
aa85d27eab Initialize the slug field when doing the update tests 2009-10-23 09:52:03 -07:00
Tim Almdal
703f22abcb Only look for tests that are in the active modules. Update the controller golden file to reflect the current location of files. 2009-10-23 09:41:33 -07:00
Tim Almdal
b3e175006c Move the filters that the File_Structure_Test use into a seperate file so other tests. can use them. Add a No_Direct_ORM_Access_Test to find all places that the user or group table are accessed outside of the user module. This test will fail at this point, as it in preparation for the IdentityProvider refactor. 2009-10-23 07:48:07 -07:00
Tim Almdal
36adc11f05 move the direct orm test to the users module. 2009-10-22 13:30:32 -07:00
Tim Almdal
f4176ae97d Rename No_Direct_access_Test and change the require_once to fully qualify the path to Gallery_Filters.php 2009-10-22 13:29:12 -07:00
Tim Almdal
6b51de49c5 Change the modifier on activate and deactivate methods to static as they are in a helper class. 2009-10-22 13:28:23 -07:00
Tim Almdal
3c936d661a Change the name of identity library from Identity to IdentityProvider. Create a helper class called identity to simplify call the Identity Provider. Move the contents of MY_Session.php to the new helper class and remove the MY_Session class 2009-10-22 13:11:03 -07:00
Tim Almdal
b994ea9d62 use the appropriate API's 2009-10-21 11:53:41 -07:00
Tim Almdal
182c8414a1 Add the Gallery File Filters and a test to check that the user/group table is only accessed from the user module. 2009-10-21 11:48:40 -07:00
Tim Almdal
ea2ab0c654 Create a No_Direct_Access test which initially checks to insure there is no direct access to the users and groups table defined by the user module. 2009-10-21 09:32:27 -07:00