stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-05-23 21:09:11 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
2,833 Commits 4 Branches 0 Tags
52ecdcdff2ffd37760c0d0edbe7cd2fcc62a47fc
Commit Graph

60 Commits

Author SHA1 Message Date
Bharat Mediratta
bfca0c7903 Refactor the install/upgrade code to be more flexible. 
Add xxx_installer::upgrade($version) method so that upgrade stanzas
are separate from install stanzas.  In the old code, to do an upgrade
meant that you had to re-evolve everything from the initial install
because we'd step through each version's changes.  But what we really
want is for the initial install to start off in the perfect initial
state, and the upgrades to do the work behind the scenes.  So now the
install() function gets things set up properly the first time, and the
upgrade() function does any work to catch you up to the latest code.
See gallery_installer.php for a good example.
 2009-06-23 12:00:49 -07:00
Bharat Mediratta
1fa05d2f39 Updated to Exifer r4107 2009-06-20 21:41:09 -07:00
Bharat Mediratta
cdb4052b52 Add an id to the exif link anchor. 2009-06-19 09:58:36 -07:00
Bharat Mediratta
c31434ea3c Don't bomb if there are no exif_records for the given item. 2009-06-01 18:03:07 -07:00
Bharat Mediratta
708f27f483 Run p::clean() on any variables that contain data entered by users. 2009-05-31 00:11:48 -07:00
Bharat Mediratta
c4c70c537d Tweak path slightly 2009-05-28 21:18:31 -07:00
Bharat Mediratta
73f348b29e Protect get() against missing records. 2009-05-28 21:07:47 -07:00
Bharat Mediratta
7e5e70548b clean up whitespace errors introduced in last commit 2009-05-26 06:01:04 +00:00
Bharat Mediratta
7aed923908 Restructure the module lifecycle. 
Install: <module>_installer::install() is called, any necessary tables
are created.

Activate: <module>_installer::activate() is called.  Module
controllers are routable, helpers are accessible, etc.  The module is
in use.

Deactivate: <module>_installer::deactivate() is called.  Module code
is not accessible or routable.  Module is *not* in use, but its tables
are still around.

Uninstall: <module>_installer::uninstall() is called.  Module is
completely removed from the database.

Admin > Modules will install and activate modules, but will only
deactivate (will NOT uninstall modules).
 2009-05-26 05:28:59 +00:00
Bharat Mediratta
774e0b3737 Avoid complex inserts in available_tasks() to make admin/maintenance 
run faster.  This fixes ticket #235.

Incidentally, refactor exif and search to use the same patterns
overall so that if you understand one, you understand the other and
they generally use the same strings for localization.
 2009-05-20 06:10:14 +00:00
Bharat Mediratta
54fe2c600e Avoid doing an expensive insert in available_tasks(). Partial fix for ticket #235. 2009-05-20 05:46:34 +00:00
Bharat Mediratta
a1ad048ef2 Update preamble to avoid extra opening php block 2009-05-18 04:00:20 +00:00
Bharat Mediratta
5495037a3d Gee it's May already. Update copyright to 2009. 2009-05-13 20:04:58 +00:00
Bharat Mediratta
c397cc73be Don't divide by zero if there are no photos in the Gallery. 2009-05-12 04:22:05 +00:00
Bharat Mediratta
a2c188ac37 Update exif lib to upstream r3901 which resolves the following tickets: 
http://www.zenphoto.org/trac/ticket/1117
  http://www.zenphoto.org/trac/ticket/1118
 2009-05-11 19:19:13 +00:00
Tim Almdal
11477cbc3e Correct the reference to $item->id 2009-05-11 14:32:18 +00:00
Bharat Mediratta
891930ec2b Don't accept negative capture dates from EXIF, they're probably just crap data. 2009-05-11 04:22:50 +00:00
Bharat Mediratta
977d0da9f3 Refactor the exif module to denormalize the stored data. This way we 
have a single exif_record for each item instead of 1 per key.  It's
about 5x faster to scan photos this way.
 2009-05-11 03:53:44 +00:00
Bharat Mediratta
b706cb69ac Reinstate abortCount code, originally added to exifer in G2: 
http://gallery.svn.sourceforge.net/viewvc/gallery?view=rev&revision=13422

it was commented out in the ZenPhoto version.  Filed upstream ticket
about this:
  http://www.zenphoto.org/trac/ticket/1118
 2009-05-11 02:37:12 +00:00
Bharat Mediratta
6dbd8aa002 Don't use ORM to delete old exif_keys.. it's too inefficient 2009-05-11 02:35:43 +00:00
Bharat Mediratta
8c776ffa6f Add a cache in intel2Moto(). Because of the duplicate nature of the 
calls to this function, this is a 1-2x order of magnitude performance
improvement.
 2009-05-11 01:36:36 +00:00
Bharat Mediratta
cc0fcc8961 Use a clearer query syntax for deleting extra search and exif records (thanks Romain LE DISEZ) 2009-05-10 18:44:03 +00:00
Bharat Mediratta
d1a9138925 Don't try to use mb_detect_encoding if the module isn't loaded. Not sure if this is a great solution, but it'll probably cut down on a big class of errors opportunistically 2009-05-08 19:16:48 +00:00
Bharat Mediratta
85832e2e0f Don't try to use the exif/iptc values if we couldn't extract them cleanly. 2009-05-07 05:04:11 +00:00
Bharat Mediratta
fc6bdbbbc8 Grab photo capture date and captions from EXIF/IPTC data. 
- Add a "captured" column to the items table.
- Pull the DateTime EXIF field and put it into the captured column
- Pull the Caption EXIF & IPTC fields and put them into the description
  field if there was not already a value there
 2009-05-07 01:18:31 +00:00
Bharat Mediratta
13f8a0dd7b Detect input encodings from EXIF/IPTC data and convert to utf-8 as 
appropriate.  This allows us to switch the exif value column back to
varchar and improves the way that we deal with non-utf8 data in our
embedded EXIF/IPTC data.
 2009-05-05 03:30:49 +00:00
Bharat Mediratta
f3caf1eb52 Update upstream to to r3835 which resolves upstream ticket #1108 
svn merge -r20638:20640 vendor/exifer/modified trunk/modules/exif/lib
 2009-04-28 03:28:43 +00:00
Bharat Mediratta
2a5abfdbd4 Update value size to 1536 chars because I had an image which went over 1024 chars 2009-04-27 05:36:32 +00:00
Bharat Mediratta
f118fc0c14 Fix an edge case with GPS data handling that results in this error: 
fread: Length parameter must be greater than 0 in file modules/exif/lib/makers/gps.php on line 197

Filed upstream as:
  http://www.zenphoto.org/trac/ticket/1108
 2009-04-27 03:58:16 +00:00
Bharat Mediratta
f51765a4b2 Drop the item_id key; we don't need this level of strictness in most 
cases and it slows down inserts.
 2009-04-25 22:17:06 +00:00
Bharat Mediratta
bab514a48d Change the value column to varbinary so that we can handle the occasional binary data embedded in places like the EXIF caption field 2009-04-25 22:02:50 +00:00
Bharat Mediratta
3950e7582b Fix status math. 2009-04-25 07:18:39 +00:00
Bharat Mediratta
2819a1b7b4 Extract as many records as we can in a second 2009-04-25 06:53:34 +00:00
Bharat Mediratta
63ce71a32b Add a key on item_id so that our query to find missing exif records is efficient 2009-04-25 06:52:44 +00:00
Tim Almdal
0fdc4639c3 Remove duplicate word from status message 2009-04-21 14:41:06 +00:00
Bharat Mediratta
fabb9fb4bd Don't try to insert exif keys if there aren't any. 2009-04-05 04:07:18 +00:00
Bharat Mediratta
846fc51f61 Optimization: add all exif/iptc keys in a single insert, instead of 
many separate queries.

In the process, rip out the summary column, we weren't using it.
Clean up the test, and drop the exif_records database on uninstall.
 2009-04-05 03:54:08 +00:00
Bharat Mediratta
921f3a2eee Put csrf token into Admin_View and Theme_View by default, then use it 
directly wherever possible instead of access::csrf_token().
 2009-03-27 03:43:21 +00:00
Bharat Mediratta
70390e83f8 Make the exif_key value size 1k 2009-03-13 04:09:28 +00:00
Bharat Mediratta
f32f1697c9 Get rid of Task_Definition types: they're not necessary. This 
incidentally fixes the the problem that admin/maintenance tasks have
been broken.
 2009-03-09 07:02:09 +00:00
Bharat Mediratta
23937ff135 Avoid using default task types. Require task::get_definitions() to 
specify a single type and ask for it appropriately in
admin_maintenance.  Specify a type for every existing task.
 2009-03-05 06:38:11 +00:00
Bharat Mediratta
08d2fcb1f7 Fix some table names 2009-03-05 06:26:15 +00:00
Tim Almdal
c04ff8e02f Change the pattern to identify tables that need prefix substitution to 
mirror the drupal pattern of using braces {}.
 2009-02-28 06:37:28 +00:00
Tim Almdal
fd610589ed This implements table prefix for all the queries in core, user, exif, 
tag, search, comment and notification modules (Ticket #68)
(missed this one)
 2009-02-27 21:09:00 +00:00
Tim Almdal
bd15853708 This implements table prefix for all the queries in core, user, exif, 
tag, search, comment and notification modules (Ticket #68)
 2009-02-27 21:07:18 +00:00
Tim Almdal
960c4248de Replace ORM->select(count(*)) with a call to Database::count_records 2009-02-26 21:23:35 +00:00
Tim Almdal
2042a4914b Implement fix for ticket #103. If there is no exif data, don't 
display the "Show more Information Button".
 2009-02-26 16:57:00 +00:00
Andy Staudacher
e031957354 File structure style fixes 2009-02-24 05:54:19 +00:00
Tim Almdal
b6f0d17565 Change the name of the model from exif_info to exif_record So item 
deletes won't fail.
 2009-02-21 16:41:35 +00:00
Bharat Mediratta
590a4677f3 Tweak EXIF extraction code to be more robust. 
* Create Exif_Record_Model to track whether we've scanned the EXIF
  data for this photo or not.  This allows us to track photos that
  don't have EXIF data (and won't have any Exif_Keys)

* Blow away old Exif_Keys when extracting, else we hit unique
  index constraints.

* exif::_get_stats() -- before it was running the task forever
 2009-02-15 08:08:22 +00:00