stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-07-26 09:43:54 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,370 Commits 4 Branches 0 Tags
412f8f73e33d2f8b02eeedc69bc8a486b2d8e2e8
Commit Graph
864 Commits
Author SHA1 Message Date
Bharat Mediratta 20ae106c22 Display a message in the "Check for Gallery upgrades" block when 
there's a newer version available, even if the user has dismissed the
site status message.  #1605.
 2011-01-17 21:16:43 -08:00
Bharat Mediratta 45caba09f8 Move the code that clears the upgrade_check site status message to the 
upgrader so that it's cleared any time we run an upgrade.  Part of
 2011-01-17 20:03:11 -08:00
Bharat Mediratta 76411d7d6d Rename BUILD_NUMBER to .build_number so it's not so loud. 2011-01-17 17:34:19 -08:00
Bharat Mediratta 29be21bb0d Add BUILD_NUMBER to the security check in .htaccess 
Change BUILD_NUMBER to be .ini format and add a big "do not edit" comment.
 2011-01-17 17:27:16 -08:00
Bharat Mediratta 14ae5d8544 Update version checking code to expect "branch_" as the prefix for 
all branch related lines.  For #1605.
 2011-01-17 17:07:32 -08:00
Bharat Mediratta 66bb496b6c If the logged in user is an admin and it's been more than 7 days since 
the last check and auto upgrade checking is enabled, fire off an XHR
to check for a possible upgrade.  Finishes off #1605.
 2011-01-16 23:14:57 -08:00
Bharat Mediratta 167f635a6c Add arguments to random::int() to match mt_rand(). Follow on to cd48b89f31 
for #1527.
 2011-01-16 23:06:19 -08:00
Bharat Mediratta 70abfb2a20 Upgrade checking code is now here, along with a bump of the Gallery 
module to v46.  There's a new block in the admin dashboard which
controls whether automatic checking happens, and lets you check
immediately.  If a newer version is detected, a site status message
appears for admins providing upgrade instructions.

Automatic checking is not yet implemented (even though the UI claims
that it exists).  This is all for #1605.
 2011-01-16 22:16:09 -08:00
Bharat Mediratta 84d576606d Change the value column of the messages table from a varchar(255) to a 
text.  Fixes #1612.
 2011-01-16 21:46:03 -08:00
Bharat Mediratta b78b109018 Fix indentation. 2011-01-16 17:10:30 -08:00
Bharat Mediratta ac44e9c930 First step in setting up version checking. 
We now have two types of packages (release, git).  Instead of using
constants, we now have gallery::version_string() which returns the
current version string.  If you're on a release package, then the
version string looks like:

  3.0 (Santa Fe)

If you're on a git package, then the version string looks like this:

  3.0.1 (branch 3.0.x build 3)

We track the build number in a new file in the gallery3 root called
BUILD_NUMBER which we will update periodically with the latest
build number for each branch.
 2011-01-16 16:58:58 -08:00
Joe7andBharat Mediratta 0020f87d6a Fixed paging for albums ordered by random. 
MySql has problems when comparing float values against -seemingly same- float input, see http://dev.mysql.com/doc/refman/5.0/en/problems-with-float.html for details.
Fixes #1610
 2011-01-16 16:58:58 -08:00
Bharat Mediratta ee13b934f4 Fix all the head() and admin_head() theme callbacks to return the 
results of the $theme->css() and $theme->script() calls.  This handles
the case where combining scripts/css returns HTML instead of putting
it in the queue for combination.  Fixes #1611.
 2011-01-15 13:14:43 -08:00
Bharat Mediratta ee53744aa7 Two improvements to Joe's fix for #1504: 
1) Trap all exceptions, eg dns or connectivity issues and
   report back in the form (but put the stack trace in the logs)
2) Rename "noconn" to "no_connection"
 2011-01-11 16:59:57 -08:00
Bharat Mediratta f80b5959f1 Merge branch 'Ticket#1504' of git://github.com/Joe7/gallery3 2011-01-11 15:38:03 -08:00
Bharat Mediratta 92db7f4218 Update some comments. 2011-01-11 15:24:40 -08:00
Bharat Mediratta 252aba9eae Merge branch 'fix-viewable2_master' of git://github.com/BigMadWolf/gallery3 2011-01-11 15:17:05 -08:00
Joe7 049f2af1c9 Returning 2 flags from l10n_client::validate_api_key(), 1 to reflect if connection was built up properly (just a boolean, not distuingishing between reasons in case of a failure), the other to reflect API validating success status. 
Using this presenting a slightly more meaningfull error msg to user in case the connection would fail.
Fixes Ticket #1504
 2011-01-12 00:05:11 +01:00
Bharat Mediratta 84e08a6283 Don't resize if the target size is the same as the original. Fixes #1602. 2011-01-11 01:04:10 -08:00
Bharat Mediratta 23eaec7063 Stop using "which" to find binaries. Create system::find_binary() 
which traverses the $PATH and returns any executable binary of the
appropriate name that it can find.  Fixes #1555.
 2011-01-10 15:49:15 -08:00
Bharat Mediratta bd6bd029a7 Fix up the version detecting regex for GraphicsMagick and don't crash 
if the regex doesn't return properly.  Follow on to
3ec0ba956d for ticket #1595.
 2011-01-10 14:04:15 -08:00
Bharat Mediratta 20ba7b6bee Merge branch 'graphics/detect_toolkits()_refactoring' of git://github.com/Joe7/gallery3 2011-01-10 13:54:20 -08:00
Jérémy Subtil 0d7e951aa5 Moved item_Model::get_position() method to the Item helper. It now calls the viewable() method on every query. 2011-01-09 12:14:46 +01:00
Bharat Mediratta 713bd4eb6a Improve gallery::find_file() to do a better job of detecting the modules/themes directories. 
Fixes #1590.
 2011-01-08 18:10:43 -08:00
Joe7 eecb244291 Made t() calls parsable by localization scanner 2011-01-09 02:06:35 +01:00
Bharat Mediratta 92f66058d3 Revert "Warn admins after login if their PHP install has the" 
This reverts commit 612ddd7050.
 2011-01-08 16:58:52 -08:00
Bharat Mediratta e1e1e860cd Use the code version when installing a module that has no installer, 
instead of hardcoding version 1.  Fixes #1589.
 2011-01-08 16:51:25 -08:00
Joe7 7dd63630d8 Minor coding style fix 2011-01-08 19:44:46 +01:00
Joe7 3ec0ba956d Refactored graphics::detect_toolkits() so ImageMagick and GraphicsMagick shares the same loop. Just as premarked as todo. 
Will make https://sourceforge.net/apps/trac/gallery/ticket/1555#comment:3 an even quicker task
 2011-01-08 19:39:23 +01:00
Bharat Mediratta d74aad072d Some small follow on fixes for #1559 and #1568: 
1) Make database changes in gallery_installer::install() instead of
   in installer/install.ql
2) Bump the version number in modules/gallery/module.info
 2011-01-03 12:25:51 -08:00
Joe7andBharat Mediratta e6a5f39b91 case fix 2011-01-03 11:10:31 -08:00
Joe7andBharat Mediratta b26eff7f23 Bugfix: input validation validates description up to length of 65535 chars, but DB trimmed data over 2048 chars. Converting column into TEXT type. 
Note: The effective maximum length of a VARCHAR in MySQL 5.0.3 and later is subject to the maximum row size (65,535 bytes, which is shared among all columns) and the character set used.
In contrast to CHAR, VARCHAR values are stored as a one-byte or two-byte length prefix plus data. The length prefix indicates the number of bytes in the value. A column uses one length byte if values require no more than 255 bytes, two length bytes if values may require more than 255 bytes.
 2011-01-03 11:08:21 -08:00
Bharat Mediratta a8b0254e4a Improve the solution for #1545 by sorting the settings menu properly 
to be naturally ordered and case insensitive.
 2010-12-29 17:31:28 -08:00
Joe7andBharat Mediratta 869bba5e13 Truncating table first againt collides when converting INDEX into Unique 2010-12-28 23:14:04 -08:00
Joe7andBharat Mediratta 440597356d Added changes to installer and upgrader scripts to support INSERT ON DUPLICATE KEY UPDATE SYNTAX in cache lib 2010-12-28 23:14:04 -08:00
Bharat Mediratta b42fcb9cda Use db::expr instead of "new Database_Expression". Resolves #1560. 2010-12-28 23:10:05 -08:00
Bharat Mediratta 11df9f204f Added Croatian as hr_HR. Fixes #1514. 2010-12-24 01:10:17 -08:00
Bharat Mediratta b5ba61fc53 Create a way for controllers to exempty themselves from maintenance 
mode and private gallery mode by setting the following constants in
the controller to true.

  ALLOW_MAINTENANCE_MODE
  ALLOW_PRIVATE_GALLERY

Fixes #1411 and the subsequent refactoring fixes #1551 as well.
 2010-12-23 23:34:04 -08:00
Bharat Mediratta 2b83918efd Fix PHPDoc for composite(). 2010-12-23 23:16:30 -08:00
Bharat Mediratta 032e6fde5f Change MY_url::parse_url to use item::find_by_relative_url. 2010-12-21 20:47:14 -08:00
Bharat Mediratta 98fd1e9957 Implement item::find_by_relative_url with tests. 2010-12-21 20:47:07 -08:00
Bharat Mediratta d9299f3b3f Change item::find_by_path() to check the relative_path_cache first, 
and only fall back the name/level comparison if there's no cached
entry.  Update tests accordingly.
 2010-12-21 19:33:47 -08:00
Bharat Mediratta 2a08cbf76d Return an empty Item_Model when item::find_by_path fails 2010-12-21 16:58:54 -08:00
Bharat Mediratta f493130e59 Tighten up item::find_by_path slightly. Augment the tests to cover 
special characters in the file name ("+" is an edge case differentiator
between rawurlencode and urlencode).
 2010-12-21 16:55:01 -08:00
Kriss AndstenandBharat Mediratta addd384bbd Minor changes to satisfy the G3 code standards. 2010-12-22 08:22:25 +08:00
Kriss AndstenandBharat Mediratta 48640005a4 Packaging + tests of Bharat's find_by_path routine. 2010-12-22 08:22:25 +08:00
Bharat Mediratta 612ddd7050 Warn admins after login if their PHP install has the 
session.use_trans_sid feature enabled, since this will cause random
logouts.  Partial fix for #1316.
 2010-12-18 11:55:04 -08:00
Bharat Mediratta dbb9b8b1c8 Sort the Admin > Settings menu instead of relying on module activation order. 
Requires making Menu::get() return a reference.  Fixes #1545.
 2010-12-17 22:19:46 -08:00
Bharat Mediratta e60edcdeba Include the root in the tree output. 2010-12-17 17:30:00 -08:00
Bharat Mediratta 6e58fced20 Follow on to 16555935ee to clean up the 
style a bit.  Tracked in #1539.
 2010-12-16 21:01:51 -08:00