Commit Graph
61 Commits
Author SHA1 Message Date
Tim Almdal d6648c0aff Fix for ticket #477. Use nl2br method when rendering comment::text and
item::description.  In addition add p::clean or p::purify to places that
xss cleaning had missed (i.e. rss feeds)
2009-07-04 08:17:12 -07:00
Tim Almdal 54ffea2419 Split the clean method into two clean and purify. clean is a light weight
approach using html::specialchars and purify uses HTMLPurifier to intelligently
cleanse the output fields. Use purifier for text and title fields where it is
likely that a user would enter html to format their data.
2009-07-03 21:44:10 -07:00
Tim Almdal 84e98e830c Move the inclusion of photo and movie specific javascript into gallery_theme 2009-06-26 08:25:24 -07:00
Bharat Mediratta 7ad5e9ee2c Move the show_full_size code into gallery/lib so that it's generally
available to themes that want to use it.  It should probably
eventually be generalized away from just being for full sized images,
but it's a step in the right direction.

Fixes ticket #427.
2009-06-16 18:05:23 -07:00
Bharat Mediratta f6e8f34bef Add the real image url to the anchor elements for our full size links
so that right clicking works.

Turn the full size rendering code into a function and call it with
arguments, instead of creating a hacky named data structure to hold
the info.

Further partial fixes for ticket #427.
2009-06-16 17:57:24 -07:00
Bharat Mediratta 51b9873041 Move all the fullsize code into the theme to make it less confusing.
Partial fix for ticket #427.
2009-06-16 17:20:30 -07:00
Bharat Mediratta b30645e36c Localize the 'Add a comment' message 2009-06-05 00:48:18 -07:00
Tim Almdal 0f987880e6 Fix for ticket #320 2009-06-02 12:08:47 -07:00
Bharat Mediratta e30b45be07 Merge branch 'master' of git://github.com/gallery/gallery3 2009-05-31 01:15:11 -07:00
Bharat Mediratta 2e16c9557c Run all variables containing user-entered text through p::clean() 2009-05-31 01:06:51 -07:00
Chad Kieffer f95b51e219 Fix IE issues with gPager, switch gPager from id to class, it's possible that we might want it to appear more than once in views. 2009-05-30 23:04:55 -06:00
Bharat Mediratta 31f0839f9b Don't provide full-size link if the user can't see the full size
image.  There's no security hole here, it's just a bad user
experience.
2009-05-10 20:02:40 +00:00
Bharat Mediratta 7e23ec89d9 Mark resized images with the 'gResize' class to match the 'gThumbnail' class we use in albums 2009-04-06 08:03:31 +00:00
Chad Kieffer a57d0d93a8 Add quick edit pane to resize images, ticket #189 2009-03-31 05:14:40 +00:00
Chad Kieffer 2ab18bbd45 Restored txtright class that I'd deleted and forgotten to restore during debugging 2009-02-23 04:37:16 +00:00
Chad Kieffer 1af62de44c Partial next/last pager fix for IE 6 and 7. Button's width is still foced to 100%. Think this is a jQuery UI CSS issue and I haven't figured out an override for it yet. 2009-02-23 03:39:44 +00:00
Chad Kieffer 1aa21cb2ab Need to have next/previous in place in a disabled state to maintain pager layout. 2009-02-22 08:20:08 +00:00
Chad Kieffer e6836d8a5e Apply button styles to pager buttons and position in consistent locations. 2009-02-22 02:09:48 +00:00
Chad Kieffer c166042313 Apply default link styles to links in dialogs, including the Forgot Password link. 2009-02-06 01:47:42 +00:00
Andy Staudacher e4a9b19bf9 Changing t() placeholder syntax from {{replace_me}} to %replace_me. 2009-01-15 10:02:41 +00:00
Bharat Mediratta 2d7ab6f4da Create Item_Model::thumb_tag() and Item_Model::resize_tag() to provide
an abstraction for when we add movie support.
2009-01-14 07:21:35 +00:00
Chad Kieffer 15c25d85ec Switch the pager to use themeroller's icon sprites. I applied jquery ui css classes to newly added span classes in the pager templates directly, will likely move these out and apply through ui.init.js later. 2009-01-10 21:50:35 +00:00
Andy Staudacher a631fe29f3 i18n refactoring: Rename all _() (reserved by gettext) calls to t().
- And refactor printf to our string interpolation / pluralization syntax
- Also, a slight change to the translations_incomings table, using binary(16) instead of char(32) as message key.
2009-01-08 17:13:06 +00:00
Chad Kieffer e8d10cab9d Applied #gPager to next/last nav, moved up above photo and moved photo title back to below the photo. 2009-01-01 22:56:57 +00:00
Bharat Mediratta cd1d023754 Change the preamble for views in two ways:
1) drop unnecessary semicolon
2) start with <?php for extra security in the case that the server itself doesn't
   have short_tags enabled (the app won't work, but we need to make sure that we're
   still secure)
2009-01-01 00:23:29 +00:00
Bharat Mediratta fc56ebd434 Simplify the next/previous logic in the theme by passing in a null
next/prev sib if one didn't exist.  (that's what we were supposed to
be doing in the first place, anyway)
2008-12-31 07:22:35 +00:00
Bharat Mediratta 23105f1359 PhotoID -> PhotoId for consistency 2008-12-31 07:16:38 +00:00
Bharat Mediratta c1140b5c0a Add Item_Model::url() and use it where appropriate. Cleans up some
grotty looking stuff in themes.
2008-12-31 07:13:34 +00:00
Bharat Mediratta 44c987e89e Add sibling information on photo pages and a very simple next/previous interface. 2008-12-31 07:06:10 +00:00
Bharat Mediratta 672eca5337 Lots of deltas rolled up into a bigger change. Sorry for the mess.
1) Deleted in-place-editing.  We'll be replacing this with a real edit
   system that groups settings together and is more coherent.

2) Tweaked the way that dialog boxes work to get the ajax stuff working
   again.  It's imperfect and does not work properly for uploading images.
   This is going to get redone also, but this is a good resting point.

3) Created edit forms for albums and photos.  Moved _update and _create out
   of Items_Controller and into the individual subclasses.

4) Created access::required which is a shorthand for:
    if (!access::can(...)) {
      access::forbidden();
    }

5) Added validation rules to Items_Model

6) Converted login to use the regular modal dialog approach in the theme.
2008-12-24 00:20:26 +00:00
Bharat Mediratta 2842a1a8be Argh, fix a bad rename. 2008-12-15 01:52:04 +00:00
Bharat Mediratta 1127257f63 Rename default_admin to admin_default. 2008-12-15 01:50:52 +00:00
Chad Kieffer 92102c891c Layout cleanup and simplification. Move view-mode buttons into sidebar, search to header_top. Reduced borders. Started album grid improvements. Minor white space improvements. Still need to handle text/photo alignment in album grid, improve placement of search. 2008-12-13 23:02:16 +00:00
Tim Almdal bd992a97b2 Remove the options menus from the albums and photo pages and move to the site menu 2008-12-11 21:27:16 +00:00
Chad Kieffer 2fbd4c09e6 Checked in jQuery superfish menu plugin, applied to item options menu. Updated album/item view icons. 2008-12-09 06:40:20 +00:00
Bharat Mediratta d086f31ea4 Style cleanups to make File_Structure_Test pass. 2008-12-07 07:42:02 +00:00
Chad Kieffer ba18542527 Yay! Working item upload dialog from the album page! 2008-12-07 07:04:58 +00:00
Chad Kieffer dca3cd2e8d Switch the slideshow link from text to icon. 2008-12-06 17:18:55 +00:00
Chad Kieffer bfd3a21dfd Added album and item view icons (album, hybrid, slideshow, full size). Added "Options" menu placeholder to display item options (add, edit, subscribe, permissions, etc.). Renamed gAlbumHeaderMenu to gItemMenu which can be used on both album and item views. 2008-12-05 06:06:02 +00:00
Bharat Mediratta 26c9ec6d4b Make header buttons, line them up nicely and float them to the right
so that they don't push the album grid down.
2008-11-27 22:08:56 +00:00
Bharat Mediratta 0b86568586 Use the dimensions of the real image 2008-11-27 11:13:24 +00:00
Bharat Mediratta c725a0f16e Move comment listing into the comment module 2008-11-25 02:14:04 +00:00
Bharat Mediratta c6f0cc036d Move all block callbacks from View::block_type() to
$theme->block_type() so that the themer has a consistent interface.
Also added a bunch more callbacks and normalized the names so that the
module author has plenty of options for where stuff gets put on the
page.  Especially renamed album/photo/sidebar to be album_blocks()
photo_blocks() and sidebar_blocks() to make it clear that those are
going to be larger content sections and not just basic insertion
points.

Used __call() to collapse all functions in the theme, which
incidentally makes it trivially easy to add a new insertion point.
2008-11-22 21:46:34 +00:00
Tim Almdal 6ec266faa6 2nd attempt at inserting html by modules. 2008-11-21 20:13:28 +00:00
Chad Kieffer 1b834319f4 Restored most heading styles, still need to restore table and list styles. Removed unused CSS. CSS format updates. Applied jQuery tab styles to gSiteMenu. Removed gBlockHeader, all we need is a good old h3 element for a heading. 2008-11-21 08:35:53 +00:00
Tim Almdal 992cf22c79 Revert module block approach 2008-11-21 07:06:11 +00:00
Tim Almdal b78cee6395 A look at away to allow modules to define html head contents (links and js) and also allow modules to contribute blocks to the layout. 2008-11-20 17:32:58 +00:00
Tim Almdal 223449fcbd slideshow::link() returns the entire anchor element 2008-11-19 23:46:40 +00:00
Tim Almdal c25f21accb Change the album and photo templates to call the slideshow helper to get the slideshow link and button text. The slideshow link will only show up if the slideshow module is installed. 2008-11-19 23:18:41 +00:00
Tim Almdal 32b4a35568 Integrate Piclens lite as the slideshow 2008-11-19 18:45:12 +00:00