Commit Graph
884 Commits
Author SHA1 Message Date
Bharat Mediratta 2c3ab56a42 Move security into the constructor. Protecting the index() call is easily bypassed. 2009-03-16 08:29:35 +00:00
Bharat Mediratta c05a1103e7 Use a query to get the database version. Newer versions of PHP bomb
if you're using mysqli, and it asks for a connection which we can't easily get
from Kohana.
2009-03-16 08:25:49 +00:00
Bharat Mediratta 54e07d0769 Get rid of the extra robust code we had in here to make the
scaffolding work when the Gallery wasn't installed yet.  Now we force
users through the installer.
2009-03-16 08:05:07 +00:00
Bharat Mediratta df5f035ed1 Get rid of obsolete/undefined $block_adder 2009-03-16 08:02:16 +00:00
Bharat Mediratta c3e70ecfa6 Initialize $result in get_html() 2009-03-16 08:01:46 +00:00
Bharat Mediratta f12f535749 Provide an empty sidebar by default 2009-03-16 07:59:28 +00:00
Bharat Mediratta 144b8f4f47 Don't count on the uri having 3 components; that breaks on newer versions of PHP. 2009-03-16 07:45:32 +00:00
Bharat Mediratta 16b1df4f67 Illegal use of $this in static function site(). Replace with $theme. 2009-03-16 07:40:57 +00:00
Bharat Mediratta f25ff87ba9 Remove unnecessary __get() function 2009-03-16 07:17:15 +00:00
Chad Kieffer c377ffc2a5 Ticket #97. Applied button css where missing. Minor form css improvements. 2009-03-16 05:50:05 +00:00
Bharat Mediratta 736d74d05f Clean up the login, maintenance login and required-top-level-login code.
We now have two clear and separate login approaches:
  login/ajax
  login/html

Choose the one that's appropriate.  Totally simplified the maintenance
page to be separate from the theme and dead simple, and use login/html
approach there.  Totally simplified the top level login
(login_page.html.php) to just be a login page, not the rest of the
chrome on the page and use the login/ajax approach there.

Don't use access::required in albums and then catch the exception,
instead use access::can and check the return code.

Improve the text for maintenance mode.
2009-03-16 04:33:45 +00:00
Tim Almdal 0bc64efa4a Thin down the scaffolding code so that all that is there is the test
data creation and the packaging code.  The rest ofthe functionality is
either no longer required, or moved to the developer module (MPTT
Tree).
Also provide checking for the active user to be an admin.
2009-03-16 03:50:57 +00:00
Bharat Mediratta a89541545f Remove automatic load of atom module. 2009-03-15 22:54:19 +00:00
Tim Almdal abdab49aef Move the start/stop translating menu item to the admin menu 2009-03-15 22:45:16 +00:00
Tim Almdal b4f8d824f7 Remove profiling and debugging from the scaffold info screen. 2009-03-15 22:05:38 +00:00
Tim Almdal bf4cd1b813 Move profiling and debugging out of the scaffolding and into the
developer module.
2009-03-15 20:35:24 +00:00
Bharat Mediratta 181737fb12 Remove the word 'album' from phpdoc. 2009-03-15 02:00:21 +00:00
Bharat Mediratta c825ec4ffb Move references to "album" out of ORM_MPTT since it's supposed to be
implementation agnostic.
2009-03-15 01:17:25 +00:00
Bharat Mediratta f9122c7908 Don't use html::image because it forces absolute urls, which we don't want. 2009-03-14 21:24:32 +00:00
Bharat Mediratta 51a16d38b8 style fixes 2009-03-14 18:43:10 +00:00
Bharat Mediratta e658b9895e Default thumb/resizes to relative urls. 2009-03-14 18:31:56 +00:00
Tim Almdal cb3d39fe62 Invert the check for https vs http. 2009-03-14 01:57:37 +00:00
Tim Almdal 2ad27663cb Remove event handlers that are are no longer called (start_batch and end_batch) 2009-03-12 18:16:13 +00:00
Tim Almdal b82b60c91a Rename tag.html.php to dynamic.html.php as part of ticket #115
creating Dynamic Albums.  This name change reflects the usage better
and allows multiple dynamic albums (including tags) to use the same
page template.
2009-03-12 15:40:08 +00:00
Chad Kieffer 5b5893b628 Minor after install message edits, added updated Gallery logo alt description 2009-03-12 04:23:53 +00:00
Tim Almdal 7ade710258 Handle no prefix being set when building key/value table map 2009-03-12 04:00:49 +00:00
Tim Almdal 7dae7dc510 Strip down the loin page (not sure if this is what bharat had in mind) 2009-03-12 03:54:17 +00:00
Tim Almdal d1f181da08 Attempt to reduce the chance of replacing text in sql statements that
is not a table name (but contained in braces) with the database prefix
by building and maintaining a cache of database tables and prefixes.
2009-03-12 03:20:13 +00:00
Tim Almdal 8fe1880e30 Bag the header("Location:", ...);exit() and replace with
url:site(url::abs_file(...))
2009-03-11 20:55:29 +00:00
Tim Almdal 1f848385fa Tried various combinations of url::redirect(...) or
url::redirect(url::file(...))

The only thing that works is this way.
2009-03-11 20:31:29 +00:00
Tim Almdal 4dfc5435ef Fix ticket #69. Rather than giving a better error message when the
gallery3 database is not setup. Just redirect to the installer.
2009-03-11 14:38:52 +00:00
Tim Almdal a521d9177f Force a login if everybody does not have access to the root
item. ticket #118.
2009-03-11 13:58:38 +00:00
Bharat Mediratta 30239ed302 $task_definitions -> $task_def 2009-03-11 03:29:12 +00:00
Tim Almdal 8da729cfa1 Refine the task api but removing the optional parameters on the
task::create method call
2009-03-11 03:14:52 +00:00
Bharat Mediratta 47756db856 Get rid of stray 'type' argument to task::get_definitions() 2009-03-11 02:39:52 +00:00
Tim Almdal ee2407cde2 Fix the test failures. If albums are created manually instead of
calling album::create, then the default sourt column needs to be set
to id.
2009-03-11 00:41:51 +00:00
Tim Almdal 2ce44b6b08 Fix the Var_Test by making sure that the cache is cleared or updated
when a variable is set or cleared.
2009-03-11 00:27:17 +00:00
Tim Almdal c2db5d0fc9 Fix the test, with the addition of the additional fields required by
album sort order change.
2009-03-11 00:17:48 +00:00
Bharat Mediratta 068c44e201 access::allow/deny/reset functions will now throw an exception if you
don't pass in a Group_Model as the argument.  This prevents us from
setting permissions on the wrong group by accidentally passing in a
User_Model.
2009-03-10 20:34:32 +00:00
Tim Almdal 5342578e6d Minor change to the task api with the addition of two optional
parameters. The first allows the specification of a task name.
Non-maintenance tasks are not defined as part of availabl_tasks so we
can't get the name from the task definitions. The 2nd allows the
specification of a context when the task is completed.
2009-03-10 13:53:59 +00:00
Bharat Mediratta 9d4769da87 Add profiling/debugging switches in the Scaffold menu. 2009-03-10 06:45:55 +00:00
Bharat Mediratta 9d8d115387 Show the album edit form for albums, not the photo edit form 2009-03-10 03:28:13 +00:00
Tim Almdal b9ee37f30e Override the ORM_MTTP::children and ORM_MTPP::descendants methods in
the item model and always pass the orderby fields.  This insures that
all children or descendant calls will respect the album sort order.
2009-03-09 14:38:25 +00:00
Tim Almdal ac82e0a9df Change Item_Model::get_position to respect the sort order. This also
forced the next/prev buttons in album navication to respect the sort
order as well.
2009-03-09 13:43:13 +00:00
Tim Almdal c0375db79f Restructure the sort order to maintain the sort column and sort order
as two separate columns in the item table.
2009-03-09 13:30:22 +00:00
Bharat Mediratta 7aea8f0385 Add a 'cancel all' link too 2009-03-09 07:45:38 +00:00
Bharat Mediratta e37faa0008 More tasks cleanup.
Don't join through to the users table; that won't work in embedded
mode.  Instead, add Tasks_Model::owner() that calls user::lookup() and
refer to the object directly in the view.

Add Admin_Maintenance:remove_finished_tasks() so that we can easily do
old task cleanup.

Hide Running / Finished sections if there aren't any running or
finished tasks.
2009-03-09 07:28:19 +00:00
Bharat Mediratta f32f1697c9 Get rid of Task_Definition types: they're not necessary. This
incidentally fixes the the problem that admin/maintenance tasks have
been broken.
2009-03-09 07:02:09 +00:00
Bharat Mediratta 4fed34873a Don't let graphics::resize() upscale images.
Fixes ticket #117.
2009-03-09 06:59:05 +00:00
Bharat Mediratta b8cf195be8 Don't forget to clean up temp files after uploading.
Fixes ticket #120.
2009-03-09 04:11:15 +00:00