stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-05-21 03:49:21 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,355 Commits 4 Branches 0 Tags
29be21bb0deaf70558b1aa02a115e67daefea0bd
Commit Graph

46 Commits

Author SHA1 Message Date
Bharat Mediratta
23eaec7063 Stop using "which" to find binaries. Create system::find_binary() 
which traverses the $PATH and returns any executable binary of the
appropriate name that it can find.  Fixes #1555.
 2011-01-10 15:49:15 -08:00
Bharat Mediratta
bd6bd029a7 Fix up the version detecting regex for GraphicsMagick and don't crash 
if the regex doesn't return properly.  Follow on to
3ec0ba956d for ticket #1595.
 2011-01-10 14:04:15 -08:00
Joe7
eecb244291 Made t() calls parsable by localization scanner 2011-01-09 02:06:35 +01:00
Joe7
7dd63630d8 Minor coding style fix 2011-01-08 19:44:46 +01:00
Joe7
3ec0ba956d Refactored graphics::detect_toolkits() so ImageMagick and GraphicsMagick shares the same loop. Just as premarked as todo. 
Will make https://sourceforge.net/apps/trac/gallery/ticket/1555#comment:3 an even quicker task
 2011-01-08 19:39:23 +01:00
Bharat Mediratta
eb010554ff Replace self::func() with <helper_name>::func() for all public APIs 
and constants to make overloading easier.  Fixes #1510.
 2010-11-28 11:27:25 -08:00
Bharat Mediratta
790bf4e871 Prioritize using the value in graphics_toolkit_path over the standard 
path so that if you change that value in Admin > Settings > Advanced
we prefer it over other paths (which may be restricted by
open_basedir).  Fixes #1395.
 2010-09-22 21:35:49 -07:00
Bharat Mediratta
3e1743b21f Add a module variable containing extra paths to search for binaries. 
Fixes ticket #1384.
 2010-09-16 20:43:48 -07:00
Bharat Mediratta
2c717b18d3 Don't concatenate two strings together as an argument for t() or t2(); 
the l10n_scanner cannot parse it properly and drops those from the
localization list.  Fixes ticket #1284.
 2010-08-29 20:04:02 -07:00
Bharat Mediratta
663f079e85 Properly handle the case where the album_cover_item_id points to an 
invalid (probably deleted) item.  Fixes ticket #1238.
 2010-07-22 14:08:08 -07:00
Bharat Mediratta
c3c2b45280 Update the copyright to 2010. It's only 3 months into the year :-) 2010-03-03 10:15:34 -08:00
Bharat Mediratta
c050acf30a Fix lots of warnings that pop up when we're in E_STRICT mode. They're 
mostly issues around uninitialized variables, calling non-static
functions in a static context, calling Session functions directly
instead of on its singleton, passing non-variables by reference, and
subclasses not using the same interface as the parent class.
 2010-01-31 16:07:41 -08:00
Tim Almdal
a11bf29507 Fix for ticket #972 and more. In Kohana 2.4, ORM::delete_all ignores any where 
clauses and deletes all the entries in the table unless an array of id's are
passed as the parameter.  This fix used the Database_builder to specify any where
conditions. Thanks psvo for find the first one. :-)
 2010-01-09 23:57:16 -08:00
Bharat Mediratta
5a7449f315 Update more database calls. 2009-12-06 19:51:25 -08:00
Bharat Mediratta
d2cb217e20 Convert more database calls over to the new format 
- admin/maintenance page loads, the rebuild thumbs/resizes task works
- Fixed up some conversion bugs in the Cache driver
 2009-12-02 00:34:34 -08:00
Bharat Mediratta
b9a0e09637 Kohana::config_xxx() is now Kohana_Config::instance()->xxx 2009-11-26 21:14:43 -08:00
Bharat Mediratta
1fd0e14359 Convert all DB where() calls to take 3 arguments. 
Convert all open_paren() calls to and_open() or or_open() as appropriate.
 2009-11-26 12:09:04 -08:00
Bharat Mediratta
0121bfd585 ORM::orderby -> ORM::order_by 2009-11-25 19:26:52 -08:00
Bharat Mediratta
2e420522ec Preliminary work to cut over to Kohana 2.4 
- Kohana::log() -> Kohana_Log::add()
- Kohana::config_XXX -> Kohana_Config::instance()->XXX
- Implement View::set_global in MY_View
- Updated Cache_Database_Driver to latest APIs
- ORM::$loaded -> ORM::loaded()
- Updated item::viewable() to use K2.4 parenthesization
 2009-11-25 13:22:24 -08:00
Tim Almdal
294215258a Include the graphics_toolkit_path from the advanced settings in the path when searching for the graphics toolkits directories. Fixes ticket #639 2009-10-30 10:31:47 -07:00
Tim Almdal
b35051ff6f Move the graphics::rotate to gallery_graphics::rotate to be consistent with the other gallery graphics functions. 2009-10-06 18:30:08 -07:00
Chad Kieffer
3e6ba7acc3 Renamed most, if not all css selectors from gName to g-name. Moved a few shared images from wind to lib. Deleted unused images in the admin_wind. This will likely break a few ajax features. 2009-10-04 00:27:22 -06:00
Chad Kieffer
e1e8904e4a Convert gDialog and gCancel over to g-dialog and g-cancel. Refactor CSS id's and classes in the login/reset password dialog. 2009-09-30 22:49:36 -06:00
Tim Almdal
467b74c310 This path requires the upgrader to be run and applies the following changes: 
* moves the composite method back into core
* requires that the operation be fully qualified i.e. gallery_graphics::resize
* caches the graphics rules on each request
 2009-09-27 15:24:51 -07:00
Tim Almdal
e204e18b3c Refactor the graphic rules processing to accomplish 2 goals: First separate the grapics library from module supplied rules and secondly, allow for modules to provide new processing rules callbacks. graphics::generate will now look for <module_name>_graphics::<rule> methods. 2009-09-24 20:28:26 -07:00
Bharat Mediratta
9237ab9bc1 Change graphics::generate() API so that it doesn't return a boolean, 
instead it throws an exception if there's a problem.  The normal case
for graphics::generate is that it's going to succeed.  It'll only fail
if something un-handleable went wrong, so just use the resulting
exception.
 2009-09-02 15:29:00 -07:00
Bharat Mediratta
b9293755c0 Deal with the aftermath of adding sharpen() calls. Since GD does not 
support it, this causes crashes as soon as you try to use it, which
breaks a bunch of our tests.  Also, give the user some idea that
sharpen() is missing in the UI.  Fixes #689.
 2009-09-02 11:57:20 -07:00
Andy Staudacher
8312eb116e XSS review fixes (mostly adding missing html::mark_clean()) calls. 2009-08-31 02:12:01 -07:00
Andy Staudacher
ddb84c84e1 Rename mark_safe() to mark_clean() 2009-08-31 00:42:18 -07:00
Andy Staudacher
e7f5e0a9a3 Merge commit 'upstream/master' 
Conflicts:

	modules/gallery/views/l10n_client.html.php
	modules/organize/views/organize_tree.html.php
	modules/server_add/helpers/server_add_event.php
 2009-08-30 18:27:40 -07:00
Andy Staudacher
effccfd41d Change all instances of SafeString::of_safe_html() to html::mark_safe() in views. 2009-08-30 07:00:56 -07:00
Bharat Mediratta
878b9c91b2 Remove try/catch in resize() since that will swallow any exceptions 
that we generate when resizing.
 2009-08-29 16:38:53 -07:00
Andy Staudacher
b4b638be44 Undo url helper changes - url methods no longer return a SafeString. 
Adding SafeString::of_safe_html() calls where urls are passed as parameters to t() and t2().
 2009-08-29 16:28:30 -07:00
Tim Almdal
0aceba6f48 Fix for ticket #628: 
1) increased gallery module version to 11
2) added image_sharpened parameter to the gallery module
3) sharpen all resizes.
 2009-08-29 15:20:27 -07:00
Bharat Mediratta
c9f5000e65 Improve the graphics toolkit detection code so that properly 
identifies situations where its restricted by open_basedir.

We now track more informatoin about the toolkit including the version
and any errors we encountered while doing the detection so that we can
provide more info downstream.  This makes graphics::detect_toolkits()
a little heavier, but that's ok because it should not be called very
often.

In the process, refactor the controller and view hierarchy so that
it's a little more straightforward in the code.

Fixes ticket #616.
 2009-08-08 20:31:16 -07:00
Bharat Mediratta
f034c6c534 Add new events: 
graphics_resize
  graphics_resize_completed
  graphics_rotate
  graphics_rotate_completed
  graphics_composite
  graphics_composite_completed
 2009-07-31 13:32:07 -07:00
Bharat Mediratta
2a40f48d65 Add /opt/bin as a binary path. 2009-07-14 06:36:48 -07:00
Tim Almdal
a13ddfea8f Suppress the filesize error if the thumbnail is not found so we can get 
an EMPTY_INPUT_FILE exception which we can then log and continue.
 2009-07-02 07:53:24 -07:00
Bharat Mediratta
abbecb9e7e Look in /opt/local/bin for binaries, too. 
Fixes ticket #423.
 2009-06-24 21:19:05 -07:00
Bharat Mediratta
b4ef00c8d4 Use a placeholder image if ffmpeg is missing instead of throwing an 
exception which would get silently swallowed by swfUpload.
 2009-06-16 19:47:52 -07:00
Bharat Mediratta
b70623118a Add /usr/local/bin to PATH before trying to detect binaries. 2009-06-12 00:58:34 -07:00
Bharat Mediratta
c7aafef852 Improve error handling support for corrupt images and report them 
appropriately in g2_import.
 2009-06-07 17:48:42 -07:00
Bharat Mediratta
c8351109fe Add the exception message to the trace string when there's a graphics 
failure.
 2009-06-05 17:37:49 -07:00
Bharat Mediratta
c7f49fd1ec Skip over busted images when rebuilding. Change graphics::generate() 
to return true/false on whether or not it could rebuild the image
properly, then track the broke images in the task and ignore them.

Fixes ticket #344.
 2009-06-04 23:20:54 -07:00
Bharat Mediratta
88a3d43ba9 Update all references to the core application to now point to the 
gallery module.  This type of mass update is prone to some small bugs.
 2009-05-27 16:17:29 -07:00
Bharat Mediratta
28b41056e3 Restructure things so that the application is now just another module. 
Kohana makes this type of transition fairly straightforward in that
all controllers/helpers/etc are still located in the cascading
filesystem without any extra effort, except that I've temporarily
added a hack to force modules/gallery into the module path.

Rename what's left of "core" to be "application" so that it conforms
more closely to the Kohana standard (basically, just
application/config/config.php which is the minimal thing that you need
in the application directory)

There's still considerable work left to be done here.
 2009-05-27 15:07:27 -07:00