Bharat Mediratta
16ccda0f3d
Two fixes:
...
1) Don't call ORM_MPTT::move_to() directly. Use the new
model-based-validation approach of changing the parent_id and saving.
2) Item_Model::parent() can return null; check for it.
2010-01-20 23:49:10 -08:00
Bharat Mediratta
e2b6cfc2d9
Make move_to protected since we don't want folks calling it on
...
Item_Model. If there's a need to make this public, we should override
it in Item_Model and throw an exception there.
2010-01-20 23:47:48 -08:00
Bharat Mediratta
46d4d778ad
Remove debug code.
2010-01-20 23:33:09 -08:00
Bharat Mediratta
949586c254
Oops, bug in save() -- we weren't returning the saved value!
2010-01-20 23:28:29 -08:00
Bharat Mediratta
d3e3bbd713
improve comment.
2010-01-20 23:27:52 -08:00
Bharat Mediratta
8a1c17d869
Use the exception itself to print out a nice text message.
2010-01-20 23:14:51 -08:00
Bharat Mediratta
3f3159d25c
Guard against missing/empty $description.
2010-01-20 23:05:51 -08:00
Bharat Mediratta
382214f3c1
Move the error page to the expected location for K24.
2010-01-20 23:00:39 -08:00
Bharat Mediratta
f6c48d757c
Delete MY_ORM::original(). We did not have proper containment to
...
generate $original when we needed it, resulting in inconsistent
behavior.
2010-01-20 22:56:37 -08:00
Bharat Mediratta
b0ff4418d2
Stop using MY_ORM::original()
2010-01-20 22:55:22 -08:00
Bharat Mediratta
f0780486ee
Fix typo: edit_user -> add_user.
2010-01-20 22:53:51 -08:00
Bharat Mediratta
b23f62259d
Stop using MY_ORM::original().
2010-01-20 22:52:11 -08:00
Bharat Mediratta
feefdfd533
Stop using MY_ORM::original().
2010-01-20 22:51:18 -08:00
Bharat Mediratta
6dc88be6b6
Stop using MY_ORM::original().
2010-01-20 22:50:47 -08:00
Bharat Mediratta
00957f79ba
Throw Kohana_Exception instead of Exception on access denied, since that may bubble all the way up
2010-01-20 22:46:46 -08:00
Bharat Mediratta
995faaa27f
Stop using MY_ORM::original(). It's got very odd semantics and we are
...
not capturing all cases for setting and resetting $original, which
leads to some weird and hard to reproduce behavior.
Instead, if we need the original just reload it from the database.
This may result in a somewhat excessive load in places, but we'll have
to fix that in a later optimization pass.
2010-01-20 22:45:19 -08:00
Bharat Mediratta
2a41e27d49
Add random_tag().
2010-01-20 21:15:57 -08:00
Bharat Mediratta
3a26ace065
Improve robustness in resolve() against bad urls..
2010-01-20 21:15:44 -08:00
Bharat Mediratta
697d84457f
Rewrite and greatly simplify the tests for the new tag_rest implementation.
2010-01-20 21:15:11 -08:00
Bharat Mediratta
3d4a6d6336
Remove unused untagging code from put()
...
Add access permissions to delete()
Remove unnecessary return value from delete()
2010-01-20 21:14:40 -08:00
Bharat Mediratta
210e02f000
Throw Rest exceptions, not regular exceptions.
2010-01-20 21:13:58 -08:00
Bharat Mediratta
8bf73d4b4c
New test for tags_rest.php
2010-01-20 00:52:32 -08:00
Bharat Mediratta
b5cf24456f
Forbidden is a 403, not a 503.
2010-01-20 00:51:34 -08:00
Bharat Mediratta
276d7de5b6
Simplify and update for model based validation.
2010-01-20 00:14:05 -08:00
Bharat Mediratta
5f83da41e4
Rewrite the tests to be simpler and more direct.
2010-01-20 00:08:13 -08:00
Bharat Mediratta
5119d58e7f
Move access key creation into a helper function.
2010-01-20 00:07:03 -08:00
Bharat Mediratta
66fbbab907
Add assert_array_equal_to_json().
2010-01-20 00:06:36 -08:00
Bharat Mediratta
b09450cf5d
Let the Rest_Controller functions throw a Rest_Exception since
...
the Kohana framework will handle it properly.
2010-01-19 23:30:22 -08:00
Bharat Mediratta
c65eca0607
Move rest::send_headers back into Rest_Exception.
2010-01-19 23:30:09 -08:00
Bharat Mediratta
92d96548e9
Make Rest_Exception extend Kohana_Exception so that we can let it
...
bubble to the top and then in sendHeaders have it send the right
response code.
2010-01-19 23:28:18 -08:00
Bharat Mediratta
76da85a1a0
Extend Gallery_Unit_Test_Case instead of Unit_Test_Case.
2010-01-19 22:38:19 -08:00
Bharat Mediratta
a774dc5447
Don't send headers if they're already sent.
2010-01-19 22:38:03 -08:00
Bharat Mediratta
fc4250f5d8
Use $input instead of Input::instance()
2010-01-19 22:37:38 -08:00
Bharat Mediratta
409c4dcc47
Do a better job of guarding against missing images.
2010-01-19 21:27:54 -08:00
Bharat Mediratta
e39c8df19f
Fix some validation checks to check to see if the original was loaded
...
before deciding whether or not we changed a value.
Change valid_name to be cascading, not parallel.
2010-01-19 21:20:36 -08:00
Bharat Mediratta
6aee6cde25
Move data initialization into the constructor so that it happens
...
before validate() is called, which is important with our two phase web
controllers.
Make valid_parent smarter about moving existing items, vs new items.
2010-01-19 20:53:21 -08:00
Bharat Mediratta
b8c09b6d87
Use an appropriate json content type
2010-01-19 19:31:24 -08:00
Bharat Mediratta
e02675b730
Change "filename" to "name" in the edit album form. I'd rather have
...
consistency between field names than deal with underlying issues with
Forge bitching about the "name" property.
2010-01-19 19:31:01 -08:00
Bharat Mediratta
afe2128bb0
Make video/x-flv a valid movie mime_type
2010-01-19 19:30:18 -08:00
Bharat Mediratta
512910962d
Change "dirname" to "name" in the edit album form. I'd rather have
...
consistency between field names than deal with underlying issues with
Forge bitching about the "name" property.
2010-01-19 19:24:46 -08:00
Bharat Mediratta
c3ed64fc6c
Use property_exists() on our stdClass instead of array_key_exists()
2010-01-19 01:46:45 -08:00
Bharat Mediratta
0b5ce9dbc1
Fix a typo: $item -> $tag.
2010-01-19 01:36:15 -08:00
Bharat Mediratta
549b88643a
Fix a typo "tags" -> "tag"
2010-01-19 01:35:59 -08:00
Bharat Mediratta
c590fed132
Change rest::url() to take a module name and a resource. The module
...
does the rest. This function is symmetrical to rest::resolve.
2010-01-19 01:33:57 -08:00
Bharat Mediratta
f95442c314
Rewrite the tests entirely to cover the new REST code.
2010-01-19 01:17:29 -08:00
Bharat Mediratta
069a23e811
Make scope default to direct.
...
Add slug to the post params.
Fix minor output bug.
2010-01-19 01:16:59 -08:00
Bharat Mediratta
a587426cfd
Don't try to set the album cover for the grandparent if we don't have edit permissions for it.
2010-01-19 01:12:09 -08:00
Bharat Mediratta
cb7c263b47
Return arrays instead of calling rest::reply.
2010-01-19 00:36:40 -08:00
Bharat Mediratta
eea9368777
Have the rest calls return an array and print it out in the
...
controller. This is a clearer workflow; controllers generate output,
not helpers. It's also easier to test.
2010-01-19 00:36:19 -08:00
Bharat Mediratta
2c0b0aaebc
Add rest::url() for convenience.
2010-01-19 00:35:32 -08:00
Bharat Mediratta