Commit Graph

513 Commits

Author SHA1 Message Date
Bharat Mediratta
1cc7b3f4be Don't force validation anymore; we're clearing the form properly in
the controller on successful add.
2009-01-18 23:27:26 +00:00
Bharat Mediratta
b39be71a4e We don't need to reset the form anymore, since it's reset on the server side. 2009-01-18 23:26:53 +00:00
Bharat Mediratta
f0eb8cb641 Reset the form before sending it back on success so that we clear the values. 2009-01-18 23:25:42 +00:00
Tim Almdal
9275742ef9 Change the event handlers for maintaining the search index to update
the index when items change.
2009-01-18 23:23:12 +00:00
Tim Almdal
dd5be1ece0 Remove blank line at the top of the file 2009-01-18 16:55:55 +00:00
Bharat Mediratta
883db822f1 Update the index right away if there are only < 10 items 2009-01-18 09:08:51 +00:00
Bharat Mediratta
7b68ca9946 Refactor dashboard -> block_manager since it'll manage blocks site
wide, not just in the dashboard.
2009-01-18 06:55:04 +00:00
Bharat Mediratta
3d1ea2904d Rename theme callback helpers from xxx_block to xxx_theme to make room
for us to rename the dashboard helper to be a block helper since
sidebar blocks are not just in the dashboard.
2009-01-18 05:01:00 +00:00
Bharat Mediratta
58402f6fbf Fix typo.. rebuild_index -> update_index 2009-01-17 05:27:15 +00:00
Bharat Mediratta
ccff396fae Fix a silly bug in item_created() 2009-01-17 05:22:07 +00:00
Bharat Mediratta
d568a1e9fd Implement relevance ranked boolean searching on a full text index of
item and comment data.  Whew!

It's not pretty yet.  And you have to manually update the index
currently in admin/maintenance.  But it works.
2009-01-17 00:52:50 +00:00
Bharat Mediratta
91be7a38f8 Clear the "akismet is not configured" message on uninstall. 2009-01-17 00:39:38 +00:00
Bharat Mediratta
2920640c2b Fix validation when adding new comments.
Fire off the appropriate item_related_update events as appropriate.
2009-01-16 04:06:03 +00:00
Bharat Mediratta
23b0ee3628 Don't try to check comments if Akismet lacks an API key 2009-01-16 03:50:51 +00:00
Andy Staudacher
e4a9b19bf9 Changing t() placeholder syntax from {{replace_me}} to %replace_me. 2009-01-15 10:02:41 +00:00
Andy Staudacher
e53916dd06 Simplifying the way t() is called. Refactoring localization function t($message, $options=array()) into 2 separate functions:
- the new t($message, $options=array()) is for simple strings, optionally with placeholder interpolation.
- t2($singular, $plural, $count, $options=array()) is for plurals.
2009-01-15 09:30:15 +00:00
Bharat Mediratta
5bfde5ceb8 Rename 'xxx_changed' events to 'xxx_updated' 2009-01-15 02:53:13 +00:00
Bharat Mediratta
034f30190e Rename 'xxx_changed' events to 'xxx_updated' 2009-01-15 02:52:42 +00:00
Bharat Mediratta
f3ba69c1d6 Make sure that helper functions are all static. Add new
File_Structure_Test to make sure we don't regress.

According to the PHP docs, the "public" keyword is implied on static
functions, so remove it.  Also, require private static functions to
start with an _.

http://php.net/manual/en/language.oop5.visibility.php
2009-01-14 04:12:02 +00:00
Bharat Mediratta
c5f77510a7 Refactor dashboard block handling out into a dashboard helper so that
module installers don't have to know the grotty details of how it works.
2009-01-12 08:51:54 +00:00
Bharat Mediratta
bc421a615a Implement deleting dashboard blocks.
* Refactor blocks so that they have a separate id vs css_id.  This way
  we can have a unique identifier for each visual block.

* Store blocks with a random id as their unique identifier

* Add Admin_Dashboard::remove_block() and modify
  themes/admin_default/views/block.html.php to call it when you click the
  remove box.
2009-01-12 08:26:38 +00:00
Bharat Mediratta
f4d5681faa Update to Forge r172 2009-01-12 07:54:13 +00:00
Bharat Mediratta
ae73ef3d57 Updated for new Form_Submit API.
OLD:
  $form->submit("Foo")  -->  <input type="submit" value="Foo">

New:
  $form->submit("foo_button")->("Foo") --> <input type="submit" name="foo_button" value="Foo">

Mostly we don't care what the button is so we leave the name blank.
2009-01-12 07:50:04 +00:00
Bharat Mediratta
b19729435c Dashboard blocks are now data driven, and you can add new blocks to
both the sidebar and the center content area from a dropdown at the
top of the dashboard sidebar.
2009-01-12 07:39:53 +00:00
Bharat Mediratta
66abb6624e Update to Forge r171 2009-01-12 07:37:34 +00:00
Bharat Mediratta
af992a9739 Update forge to r170 2009-01-12 07:17:24 +00:00
Bharat Mediratta
66fe884cb5 Use the author's avatar, not the logged in user's one. 2009-01-11 22:47:54 +00:00
Andy Staudacher
3df7889128 Increase length for user-agent and accept fields in comments table.
And truncate strings before passing them to MySQL.
2009-01-11 05:36:31 +00:00
Andy Staudacher
bdf2e9f698 Fix Aksimet tests for MySQL strict mode. Not sure how this would pass on linux, since the given value for server_remote_port is longer than 16 chars, the actual length of the DB field.
Removed the leading "server_" part of the test values to ensure that all values are small enough to be stored in the DB.
2009-01-11 04:45:11 +00:00
Andy Staudacher
bf67d7cabc Fix User_Group tests for MySQL strict mode (can't omit full_name and password in inserts due to missing default values). 2009-01-11 03:53:29 +00:00
Bharat Mediratta
431a831f48 Update tests to match the way that we store server variables in the
comment.  Get rid of comment::update tests since, comment::update is
gone.

Found a bug in comment::create() in the process.. yay unit tests!
2009-01-11 02:58:32 +00:00
Bharat Mediratta
a53b2d85c7 Set all the server_xxx values to known quanities, and demonstrate that
they're actually getting sent to Akismet.  It looks like this code was
broken in the past, since it wasn't sending any of this extra info.
2009-01-11 02:40:09 +00:00
Bharat Mediratta
01666c5579 Fix all file structure issues (tabs, bad preambles, etc).
Note: installer/install.php is now on the "direct access" list.
2009-01-11 02:27:00 +00:00
Bharat Mediratta
253c56608e Update setup to match new comment::create() API 2009-01-11 01:58:46 +00:00
Chad Kieffer
aed5a4c788 2009-01-10 22:39:24 +00:00
Chad Kieffer
82848bd3a9 HTML format cleanup 2009-01-10 19:13:00 +00:00
Bharat Mediratta
44bfc1c6a4 Auto-delete 7-day old spam/deleted comments. 2009-01-10 11:25:33 +00:00
Bharat Mediratta
74766e5b82 Create a 'recently deleted' queue 2009-01-10 11:11:24 +00:00
Bharat Mediratta
9d584a528b Update the queue counts in the menu list whenever we
approve/unapprove/spam a comment.
2009-01-10 07:55:16 +00:00
Bharat Mediratta
9b90b4b0cd Use the theme's avatar as the default if Gravatar doesn't have one. 2009-01-10 06:18:35 +00:00
Bharat Mediratta
a5c4e3d465 Integrate Gravatar. Boy, that was easy. 2009-01-10 05:56:11 +00:00
Bharat Mediratta
a7feeb576f Big set of changes to comments, with related changes to akismet and
user modules.

* Don't delete vars when we delete a module.  This makes
  reinstalling a module a lot easier.

* Add user::lookup() as the preferred way to load a user, so that
  other modules don't delve into the user module (that'd be a
  problem when we swap out user modules)

* Notify site admins if Akismet is not fully configured

* Bundle all server variables into the comment so that if/when we
  re-check the comment, we are not using the server info from the
  site admin's request.

* Update Akismet to grab request context data from the comment

* Pre-seed comment fields if we have a logged in user.  Update
  comment::create() API to clarify it for this.

* Delete comment::update(), that's a controller function.

* Add url to User_Model

* Add author_name() author_email() and author_url() to
  Comment_Model.  It'll return the appropriate values depending
  on whether the comment was left by a logged in user or a guest.

* Use resetForm() instead of clearForm() when we reload the
  comment form after ajax submit, this way we preserve the
  pre-seeded values.

* In the user profile page, ignore blank passwords.
2009-01-10 00:34:23 +00:00
Chad Kieffer
3c31549011 Added gCommentsAdminMenu to clearfix. 2009-01-09 08:08:22 +00:00
Chad Kieffer
f97d7da720 Reformated comment admin table layout. Added bulk action checkboxes and menu, reply link, and edit link, all of which need to be wired up. 2009-01-09 07:33:22 +00:00
Bharat Mediratta
a0f3c09a07 Eliminate unused avatar code (for now) 2009-01-09 04:43:34 +00:00
Andy Staudacher
a631fe29f3 i18n refactoring: Rename all _() (reserved by gettext) calls to t().
- And refactor printf to our string interpolation / pluralization syntax
- Also, a slight change to the translations_incomings table, using binary(16) instead of char(32) as message key.
2009-01-08 17:13:06 +00:00
Andy Staudacher
fd081159f1 Windows fixes: Use mkdir($path, 0777, true) instead of the unportable system("mkdir -p $path") 2009-01-08 06:57:04 +00:00
Bharat Mediratta
e9d61d5f9d "delete" is a reserved word in Chrome, apparently. 2009-01-08 03:05:53 +00:00
Bharat Mediratta
bc36ba609d Add akismet::$test_mode, initialize it to TEST_MODE and don't contact
akismet if it's on.  Force it on in the scaffolding so that we don't
try to run all comments we add from there through Akismet.
2009-01-08 02:56:49 +00:00
Bharat Mediratta
8bf388a6f6 Incremental improvement in comment moderation:
1) Akismet now detects when we change a comment's published state and submits
   info back to akismet.com as appropriate

2) We now show 4 different queues (all / approved / unapproved / spam) and let you
   move messages between the queues

3) We track and display "spam caught" stats.

4) You can delete comments entirely.
2009-01-08 02:50:23 +00:00