Guard reparent/rearrange against bad values in source_id. Fixes #1843.

This commit is contained in:
Bharat Mediratta
2012-04-30 15:04:45 -07:00
parent b47f56c6a9
commit f488384a7b
@@ -81,6 +81,9 @@ class Organize_Controller extends Controller {
foreach (explode(",", $input->post("source_ids")) as $source_id) {
$source = ORM::factory("item", $source_id);
if (!$source->loaded()) {
continue;
}
access::required("edit", $source->parent());
if ($source->contains($new_parent) || $source->id == $new_parent->id) {
@@ -116,6 +119,11 @@ class Organize_Controller extends Controller {
$input = Input::instance();
$target = ORM::factory("item", $input->post("target_id"));
if (!$target->loaded()) {
json::reply(null);
return;
}
$album = $target->parent();
access::required("edit", $album);