stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-05-20 03:19:13 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make sure that helper functions are all static. Add new

Browse Source 
File_Structure_Test to make sure we don't regress.

According to the PHP docs, the "public" keyword is implied on static
functions, so remove it.  Also, require private static functions to
start with an _.

http://php.net/manual/en/language.oop5.visibility.php
This commit is contained in:
Bharat Mediratta
2009-01-14 04:12:02 +00:00
parent 02af2d8b76
commit f3ba69c1d6
59 changed files with 280 additions and 257 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/comment/helpers/comment_menu.php
View File

@@ -18,7 +18,7 @@
* Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.
*/
class comment_menu_Core {
public static function admin($menu, $theme) {
static function admin($menu, $theme) {
$menu->get("content_menu")
->append(Menu::factory("link")
->id("comments")
@@ -26,7 +26,7 @@ class comment_menu_Core {
->url(url::site("admin/comments")));
}
public static function photo($menu, $theme) {
static function photo($menu, $theme) {
$menu
->append(Menu::factory("link")
->id("comments")