stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-08-07 15:40:41 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Attempt to reduce the chance of replacing text in sql statements that

Browse Source 
is not a table name (but contained in braces) with the database prefix
by building and maintaining a cache of database tables and prefixes.
This commit is contained in:
Tim Almdal
2009-03-12 03:20:13 +00:00
parent e58b955d4a
commit d1f181da08
2 changed files with 44 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/tests/Database_Test.php
+17 -2
View File
@@ -86,14 +86,28 @@ class Database_Test extends Unit_Test_Case {
function prefix_replacement_test() {
$db = Database_For_Test::instance();
$sql = "UPDATE {access_caches} SET `edit_1` = 1 " .
$converted = $db->add_table_prefixes("CREATE TABLE IF NOT EXISTS {test_tables} (
`id` int(9) NOT NULL auto_increment,
`name` varchar(32) NOT NULL,
PRIMARY KEY (`id`),
UNIQUE KEY(`name`))
ENGINE=InnoDB DEFAULT CHARSET=utf8");
$expected = "CREATE TABLE IF NOT EXISTS g3test_test_tables (
`id` int(9) NOT NULL auto_increment,
`name` varchar(32) NOT NULL,
PRIMARY KEY (`id`),
UNIQUE KEY(`name`))
ENGINE=InnoDB DEFAULT CHARSET=utf8";
$this->assert_same($expected, $converted);
$sql = "UPDATE {test_tables} SET `name` = '{test string}' " .
"WHERE `item_id` IN " .
" (SELECT `id` FROM {items} " .
" WHERE `left` >= 1 " .
" AND `right` <= 6)";
$sql = $db->add_table_prefixes($sql);
$expected = "UPDATE g3test_access_caches SET `edit_1` = 1 " .
$expected = "UPDATE g3test_test_tables SET `name` = '{test string}' " .
"WHERE `item_id` IN " .
" (SELECT `id` FROM g3test_items " .
" WHERE `left` >= 1 " .
@@ -113,6 +127,7 @@ class Database_Test extends Unit_Test_Case {
class Database_For_Test extends Database {
static function instance() {
$db = new Database_For_Test();
$db->_table_names["{items}"] = "g3test_items";
$db->config["table_prefix"] = "g3test_";
return $db;
}