stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-06-05 03:09:08 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

* Added HTTP status constants and helper functions to REST helper.

Browse Source 
* HTTP header setting in comment module now going through REST helper API.
* Fixed items controller test.
* Fixed user installer test.
* Fixed _create() handling in the REST controller.
* Fixed routing for edit and add forms.
* Added some tests for the REST controller.
* Set svn:eol-style to LF on a bunch of files.
* Added preamble to MY_Forge.php.
This commit is contained in:
Jozef Selesi
2008-11-20 01:25:29 +00:00
parent bd76b2e89f
commit c3fc1cb7ec
10 changed files with 222 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
modules/comment/controllers/comments.php
View File

@@ -29,7 +29,7 @@ class Comments_Controller extends REST_Controller {
if (empty($item_id)) {
/* We currently do not support getting all comments from the entire gallery. */
header("HTTP/1.1 400 Bad Request");
rest::http_status(rest::BAD_REQUEST);
return;
}
print comment::get_comments($item_id);
@@ -49,8 +49,8 @@ class Comments_Controller extends REST_Controller {
$comment->item_id = $this->input->post('item_id');
$comment->save();
header("HTTP/1.1 201 Created");
header("Location: " . url::site("comments/{$comment->id}"));
rest::http_status(rest::CREATED);
rest::http_location(url::site("comments/{$comment->id}"));
}
// @todo Return appropriate HTTP status code indicating error.
print $form;
@@ -65,12 +65,12 @@ class Comments_Controller extends REST_Controller {
$output_format = rest::output_format();
switch ($output_format) {
case "xml":
header("Content-Type: application/xml");
rest::http_content_type(rest::XML);
print xml::to_xml($comment->as_array(), array("comment"));
break;
case "json":
header("Content-Type: application/json");
rest::http_content_type(rest::JSON);
print json_encode($comment->as_array());
break;
@@ -103,7 +103,7 @@ class Comments_Controller extends REST_Controller {
* @see Rest_Controller::_delete($resource)
*/
public function _delete($comment) {
throw new Exception("@todo Comment_Controller::_delete NOT IMPLEMENTED");
rest::http_status(rest::METHOD_NOT_ALLOWED);
}
/**