stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-06-01 01:09:20 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

#2000 - Make legal_file::smash_extensions more robust.

Browse Source 
- Fixed legal_file::smash_extensions.
- Added new unit test.
- Removed duplicated condition in existing unit test.
This commit is contained in:
shadlaws
2013-02-10 02:28:47 +01:00
parent a06faf61b4
commit bfdf5a00fd
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/gallery/tests/Legal_File_Helper_Test.php
View File

@@ -136,10 +136,18 @@ class Legal_File_Helper_Test extends Gallery_Unit_Test_Case {
public function smash_extensions_test() {
$this->assert_equal("foo_bar.jpg", legal_file::smash_extensions("foo.bar.jpg"));
$this->assert_equal("foo_bar_baz.jpg", legal_file::smash_extensions("foo.bar.baz.jpg"));
$this->assert_equal("foo_bar_baz.jpg", legal_file::smash_extensions("foo.bar.baz.jpg"));
$this->assert_equal("foo_bar_baz.jpg", legal_file::smash_extensions("...foo...bar..baz...jpg"));
$this->assert_equal("/path/to/foo_bar.jpg", legal_file::smash_extensions("/path/to/foo.bar.jpg"));
$this->assert_equal("/path/to.to/foo_bar.jpg", legal_file::smash_extensions("/path/to.to/foo.bar.jpg"));
$this->assert_equal("foo_bar-12345678.jpg", legal_file::smash_extensions("foo.bar-12345678.jpg"));
}
public function smash_extensions_pass_thru_names_without_extensions_test() {
$this->assert_equal("foo", legal_file::smash_extensions("foo"));
$this->assert_equal("foo.", legal_file::smash_extensions("foo."));
$this->assert_equal(".foo", legal_file::smash_extensions(".foo"));
$this->assert_equal(".", legal_file::smash_extensions("."));
$this->assert_equal("", legal_file::smash_extensions(""));
$this->assert_equal(null, legal_file::smash_extensions(null));
}
}