stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-07-22 07:43:53 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Follow-on fix: if tests throw an exception, don't throw another by calling an undefined variable.

Browse Source
This commit is contained in:
shadlaws
2013-03-10 11:27:10 +01:00
parent 4d631a4cad
commit b036b8acc0
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/gallery_unit_test/controllers/gallery_unit_test.php
+8 -3
View File
@@ -145,9 +145,14 @@ class Gallery_Unit_Test_Controller extends Controller {
print $e->getTraceAsString() . "\n";
}
$failed = 0;
foreach ($unit_test->stats as $class => $stats) {
$failed += ($stats["failed"] + $stats["errors"]);
if (!isset($unit_test)) {
// If an exception is thrown, it's possible that $unit_test was never set.
$failed = 1;
} else {
$failed = 0;
foreach ($unit_test->stats as $class => $stats) {
$failed += ($stats["failed"] + $stats["errors"]);
}
}
if (PHP_SAPI == 'cli') {
exit($failed);