diff --git a/lib/gallery.common.css b/lib/gallery.common.css index 4cb5735f..2cbce900 100644 --- a/lib/gallery.common.css +++ b/lib/gallery.common.css @@ -9,7 +9,9 @@ * 4) States and interactions * 5) Positioning and order * 6) Containers/widgets + * 7) Right to left language styles * + * @todo Update .g-message-block, don't force it to 100%, bad things happen is themes when you do. * @todo Remove extra white space at the top of the add comment form, above the first field */ @@ -85,6 +87,11 @@ option:focus { color: #000; } +input.checkbox { + float: left; + margin-right: .4em; +} + /* Form layout ~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ form li { @@ -502,7 +509,7 @@ div#g-action-status { .g-breadcrumbs li { background: transparent url('images/ico-separator.gif') no-repeat scroll left center; float: left; - padding: 1em .6em 1em 1.4em; + padding: 1em 8px 1em 18px; } .g-breadcrumbs .g-first { @@ -523,7 +530,7 @@ div#g-action-status { /* Pagination ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ .g-pager { - padding: 5px 0; + padding: .2em 0; width: 100%; } @@ -566,17 +573,23 @@ div#g-action-status { } /** ******************************************************************* - * 7) Right to left styles + * 7) Right to left language styles **********************************************************************/ .rtl { direction: rtl; } +.rtl #g-header, +.rtl #g-content, +.rtl #g-sidebar, +.rtl #g-footer, .rtl caption, .rtl th, .rtl #g-dialog, -.g-message { +.rtl .g-context-menu li a, +.rtl .g-message-box li, +.rtl #g-site-status li { text-align: right; } @@ -584,6 +597,14 @@ div#g-action-status { text-align: left; } +.rtl .g-error, +.rtl .g-info, +.rtl .g-success, +.rtl .g-warning { + background-position: center right; + padding-right: 30px !important; +} + .rtl .g-left, .rtl .g-inline li, .rtl form ul ul li, @@ -594,7 +615,8 @@ div#g-action-status { .rtl .g-breadcrumbs li, .rtl .g-pager li, .rtl .g-buttonset li, -.rtl .ui-icon-left .ui-icon { +.rtl .ui-icon-left .ui-icon, +.rtl input.checkbox { float: right; } @@ -610,3 +632,24 @@ div#g-action-status { .rtl .g-inline li.g-first { margin-right: 0; } + +.rtl .g-breadcrumbs li { + background-position: right center; + padding: 1em 18px 1em 8px; +} + +.rtl .g-breadcrumbs .g-first { + padding-right: 0; +} + +.rtl .g-pager .g-info { + width: 35%; +} + +.rtl .g-pager .g-txt-right { + margin-left: 0; +} + +.rtl input.checkbox { + margin-right: .4em; +} diff --git a/modules/comment/helpers/comment_event.php b/modules/comment/helpers/comment_event.php index ddf72e3c..a72102b9 100644 --- a/modules/comment/helpers/comment_event.php +++ b/modules/comment/helpers/comment_event.php @@ -24,23 +24,24 @@ class comment_event_Core { static function user_deleted($user) { $guest = identity::guest(); - Database::instance() - ->query("UPDATE {comments} - SET author_id = {$guest->id}, - guest_email = NULL, - guest_name = 'guest', - guest_url = NULL - WHERE author_id = {$user->id}"); + Database::instance()->from("comments") + ->set(array("author_id" => $guest->id, + "guest_email" => null, + "guest_name" => "guest", + "guest_url" => null)) + ->where(array("author_id" => $user->id)) + ->update(); } static function identity_provider_changed($old_provider, $new_provider) { $guest = identity::guest(); - Database::instance() - ->query("UPDATE {comments} - SET author_id = {$guest->id}, - guest_email = NULL, - guest_name = 'guest', - guest_url = null"); + Database::instance()->from("comments") + ->set(array("author_id" => $guest->id, + "guest_email" => null, + "guest_name" => "guest", + "guest_url" => null)) + ->where("1 = 1") + ->update(); } static function admin_menu($menu, $theme) { diff --git a/modules/comment/views/comments.html.php b/modules/comment/views/comments.html.php index 636f1522..fc54e3d2 100644 --- a/modules/comment/views/comments.html.php +++ b/modules/comment/views/comments.html.php @@ -1,5 +1,5 @@ - id})") ?>" id="g-admin-comment-button" + id}") ?>" id="g-admin-comment-button" class="g-button ui-corner-all ui-icon-left ui-state-default right"> diff --git a/modules/gallery/helpers/block_manager.php b/modules/gallery/helpers/block_manager.php index f26c3660..0e78661a 100644 --- a/modules/gallery/helpers/block_manager.php +++ b/modules/gallery/helpers/block_manager.php @@ -36,7 +36,6 @@ class block_manager_Core { $block_class = "{$module_name}_block"; if (method_exists($block_class, "get_site_list")) { $blocks = call_user_func(array($block_class, "get_site_list")); - Kohana::log("error", Kohana::debug($blocks)); foreach (array_keys($blocks) as $block_id) { self::add("site.sidebar", $module_name, $block_id); } diff --git a/modules/gallery/helpers/gallery_event.php b/modules/gallery/helpers/gallery_event.php index 582e3267..67a6f41f 100644 --- a/modules/gallery/helpers/gallery_event.php +++ b/modules/gallery/helpers/gallery_event.php @@ -31,15 +31,35 @@ class gallery_event_Core { static function user_deleted($user) { $admin = identity::admin_user(); $db = Database::instance(); - $db->query("UPDATE {tasks} SET owner_id = {$admin->id} where owner_id = {$user->id}"); - $db->query("UPDATE {items} SET owner_id = {$admin->id} where owner_id = {$user->id}"); + $db->from("tasks") + ->set(array("owner_id" => $admin->id)) + ->where(array("owner_id" => $user->id)) + ->update(); + $db->from("items") + ->set(array("owner_id" => $admin->id)) + ->where(array("owner_id" => $user->id)) + ->update(); + $db->from("logs") + ->set(array("user_id" => $admin->id)) + ->where(array("user_id" => $user->id)) + ->update(); } static function identity_provider_changed($old_provider, $new_provider) { $admin = identity::admin_user(); $db = Database::instance(); - $db->query("UPDATE {tasks} SET owner_id = {$admin->id}"); - $db->query("UPDATE {items} SET owner_id = {$admin->id}"); + $db->from("tasks") + ->set(array("owner_id" => $admin->id)) + ->where("1 = 1") + ->update(); + $db->from("items") + ->set(array("owner_id" => $admin->id)) + ->where("1 = 1") + ->update(); + $db->from("logs") + ->set(array("user_id" => $admin->id)) + ->where("1 = 1") + ->update(); } static function group_created($group) { diff --git a/modules/gallery/tests/Database_Test.php b/modules/gallery/tests/Database_Test.php index d83212ad..ad2bbba1 100644 --- a/modules/gallery/tests/Database_Test.php +++ b/modules/gallery/tests/Database_Test.php @@ -99,7 +99,7 @@ class Database_Test extends Unit_Test_Case { UNIQUE KEY(`name`)) ENGINE=InnoDB DEFAULT CHARSET=utf8"; $this->assert_same($expected, $converted); - + $sql = "UPDATE {test_tables} SET `name` = '{test string}' " . "WHERE `item_id` IN " . " (SELECT `id` FROM {items} " . @@ -116,12 +116,16 @@ class Database_Test extends Unit_Test_Case { $this->assert_same($expected, $sql); } - public function setup() { - } + function prefix_no_replacement_test() { + $update = Database_For_Test::instance()->from("test_tables") + ->where("1 = 1") + ->set(array("name" => "Test Name")) + ->update(); - public function teardown() { - } + $expected = "UPDATE `g3test_test_tables` SET `name` = 'Test Name' WHERE 1 = 1"; + $this->assert_same($expected, $update); + } } class Database_For_Test extends Database { @@ -131,4 +135,12 @@ class Database_For_Test extends Database { $db->config["table_prefix"] = "g3test_"; return $db; } + + public function query($sql = '') { + if (!empty($sql)) { + print " query($sql)\n"; + $sql = $this->add_table_prefixes($sql); + } + return $sql; + } } diff --git a/modules/gallery/views/login.html.php b/modules/gallery/views/login.html.php index a7734369..4c13ef4b 100644 --- a/modules/gallery/views/login.html.php +++ b/modules/gallery/views/login.html.php @@ -1,5 +1,5 @@ -