stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-08-14 11:00:52 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix some broken identity APIs:

Browse Source 
- add_user_to_group and remove_user_from_group should take Group_Definition instances
  to be consistent
- add_user_to_group and remove_user_from_group in drivers/IdentityProvider.php should
  not be static
This commit is contained in:
Bharat Mediratta
2010-09-06 18:20:46 -07:00
parent cc399bf4f0
commit 8a36c24f39
4 changed files with 16 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/user/libraries/drivers/IdentityProvider/Gallery.php
+2 -5
View File
@@ -148,9 +148,7 @@ class IdentityProvider_Gallery_Driver implements IdentityProvider_Driver {
/**
* @see IdentityProvider_Driver::add_user_to_group.
*/
static function add_user_to_group($user, $group_id) {
$group = self::lookup_group($group_id);
public function add_user_to_group($user, $group) {
$group->add($user);
$group->save();
}
@@ -158,8 +156,7 @@ class IdentityProvider_Gallery_Driver implements IdentityProvider_Driver {
/**
* @see IdentityProvider_Driver::remove_user_to_group.
*/
static function remove_user_from_group($user, $group_id) {
$group = self::lookup_group_by_name($group_id);
public function remove_user_from_group($user, $group_id) {
$group->remove($user);
$group->save();
}