Improve comment RSS feed visibility, initially added by Thomas E. Horner in

fc942aacda.

Change some variable names, refactor out visibility checking code, actually
check visibility at generation time instead of just suppressing the UI,
update module.info

Fixes #1829.
This commit is contained in:
Bharat Mediratta
2012-03-29 13:06:44 -07:00
parent 60286bfba3
commit 7d66ab2e94
4 changed files with 21 additions and 16 deletions

View File

@@ -47,13 +47,12 @@ class Admin_Comments_Controller extends Admin_Controller {
->options(array("everybody" => t("Everybody"),
"registered_users" => t("Only registered users")))
->selected(module::get_var("comment", "access_permissions"));
$comment_settings->dropdown("rss_available")
->label(t("Which RSS feeds should be available?"))
->options(array("both" => t("Both"),
"newest" => t("Only All new comments"),
"onitem" => t("Only Comments on item"),
"none" => t("None")))
->selected(module::get_var("comment", "rss_available"));
$comment_settings->dropdown("rss_visible")
->label(t("Which RSS feeds can users see?"))
->options(array("all" => t("All comment feeds"),
"newest" => t("New comments feed only"),
"per_item" => t("Comments on photos, movies and albums only")))
->selected(module::get_var("comment", "rss_visible"));
$comment_settings->submit("save")->value(t("Save"));
return $form;
}