stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-07-12 18:17:42 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use 'git ls-files' instead of glob() so that we only check files known

Browse Source 
to Git.  This means that local files which we choose to exclude from
git don't have to follow the same permission model.
This commit is contained in:
Bharat Mediratta
2009-11-15 19:20:43 -08:00
parent 5a27ce7e8f
commit 731ff800cd
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
modules/gallery/tests/Controller_Auth_Test.php
View File

@@ -25,13 +25,18 @@ class Controller_Auth_Test extends Unit_Test_Case {
public function find_missing_auth_test() {
$found = array();
$controllers = glob("*/*/controllers/*.php");
$feeds = glob("*/*/helpers/*_rss.php");
$controllers = explode("\n", `git ls-files '*/*/controllers/*.php'`);
$feeds = explode("\n", `git ls-files '*/*/helpers/*_rss.php'`);
foreach (array_merge($controllers, $feeds) as $controller) {
if (preg_match("{modules/(gallery_)?unit_test/}", $controller)) {
continue;
}
if (!$controller) {
// The last entry in each list from git ls-files appears to be an empty line
continue;
}
// List of all tokens without whitespace, simplifying parsing.
$tokens = array();
foreach (token_get_all(file_get_contents($controller)) as $token) {
@@ -118,7 +123,7 @@ class Controller_Auth_Test extends Unit_Test_Case {
if ($token[1] == "access" &&
self::_token_matches(array(T_DOUBLE_COLON, "::"), $tokens, $token_number + 1) &&
self::_token_matches(array(T_STRING), $tokens, $token_number + 2) &&
in_array($tokens[$token_number + 2][1], array("forbidden", "required")) &&
in_array($tokens[$token_number + 2][1], array("forbidden", "required")) &&
self::_token_matches("(", $tokens, $token_number + 3)) {
$token_number += 3;
$function->checks_authorization(true);
@@ -149,7 +154,7 @@ class Controller_Auth_Test extends Unit_Test_Case {
}
}
}
}
}
}
// Generate the report