stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-05-20 11:29:24 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix for ticket 1004: Replace all uses of split with explode (none actually required regular expressions). Thanks to Brian Hartsock for providing a patch!

Browse Source
This commit is contained in:
Andy Staudacher
2010-02-06 13:05:44 -08:00
parent 5c0c33782d
commit 7099fc71f1
5 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/user/tests/No_Direct_ORM_Access_Test.php
View File

@@ -31,7 +31,7 @@ class No_Direct_ORM_Access_Test extends Gallery_Unit_Test_Case {
//if (basename(dirname($file)) == "helpers") {
$file_as_string = file_get_contents($file);
if (preg_match("/ORM::factory\\(\"user\"/", $file_as_string)) {
foreach (split("\n", $file_as_string) as $l => $line) {
foreach (explode("\n", $file_as_string) as $l => $line) {
if (preg_match('/ORM::factory\\(\"user\"/', $line)) {
$errors[] = "$file($l) => $line";
}
@@ -54,7 +54,7 @@ class No_Direct_ORM_Access_Test extends Gallery_Unit_Test_Case {
foreach ($dir as $file) {
$file_as_string = file_get_contents($file);
if (preg_match("/ORM::factory\\(\"group\"/", $file_as_string)) {
foreach (split("\n", $file_as_string) as $l => $line) {
foreach (explode("\n", $file_as_string) as $l => $line) {
if (preg_match('/ORM::factory\\(\"group\"/', $line)) {
$errors[] = "$file($l) => $line";
}