stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-08-22 23:05:18 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add unittest and caching to ORM_MTPP::descendants_count

Browse Source
This commit is contained in:
Tim Almdal
2008-11-20 05:06:24 +00:00
parent 29cc48ebcf
commit 604e58346b
2 changed files with 28 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/libraries/ORM_MPTT.php
+9 -9
View File
@@ -37,6 +37,7 @@ class ORM_MPTT_Core extends ORM {
private $parents = null;
private $children = null;
private $children_count = null;
private $descendants_count = array();
function __construct($id=null) {
parent::__construct($id);
@@ -165,19 +166,18 @@ class ORM_MPTT_Core extends ORM {
* @return integer child count
*/
function descendants_count($type=null) {
// @todo create a unit test
// @todo set up caching in an array;; using type=all allows us to cache as decendents[$type]
$this->where("left >=", $this->left)
->where("right <=", $this->right);
if ($type) {
$this->where("type", $type);
if (!isset($this->descendants_count[$type])) {
$this->where("left >", $this->left)
->where("right <=", $this->right);
if ($type) {
$this->where("type", $type);
}
$this->descendants_count[$type] = $this->count_all();
}
// @todo does it make sense to order it before counting?
return $this->count_all();
return $this->descendants_count[$type];
}
/**
* @see ORM::reload
*/