stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-08-05 14:40:44 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

#1943 - Make legal_file::change_extension more robust.

Browse Source 
Previously would fail with dots in the directory but no extension.  Added unit tests to verify the new change works.
This commit is contained in:
shadlaws
2013-01-18 20:06:05 +01:00
parent 61724f78da
commit 3a9009492e
2 changed files with 21 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/gallery/tests/Legal_File_Helper_Test.php
+18
View File
@@ -36,6 +36,24 @@ class Legal_File_Helper_Test extends Gallery_Unit_Test_Case {
legal_file::change_extension("/website/foo.com/VID_20120513_105421.mp4", "jpg"));
}
public function change_extension_path_containing_dots_and_no_extension_test() {
$this->assert_equal(
"/website/foo.com/VID_20120513_105421.jpg",
legal_file::change_extension("/website/foo.com/VID_20120513_105421", "jpg"));
}
public function change_extension_path_containing_dots_and_dot_extension_test() {
$this->assert_equal(
"/website/foo.com/VID_20120513_105421.jpg",
legal_file::change_extension("/website/foo.com/VID_20120513_105421.", "jpg"));
}
public function change_extension_path_containing_dots_and_non_standard_chars_test() {
$this->assert_equal(
"/j'écris@un#nom/bizarre(mais quand.même/ça_passe.jpg",
legal_file::change_extension("/j'écris@un#nom/bizarre(mais quand.même/ça_passe.\$ÇÀ@€#_", "jpg"));
}
public function smash_extensions_test() {
$this->assert_equal("foo_bar.jpg", legal_file::smash_extensions("foo.bar.jpg"));
$this->assert_equal("foo_bar_baz.jpg", legal_file::smash_extensions("foo.bar.baz.jpg"));