stian/gallery3
1
0
Fork 0
mirror of https://github.com/Pathduck/gallery3.git synced 2026-08-22 23:05:18 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

#1951 - Make metadata generation more flexible (photo and movie helpers).

Browse Source 
- added photo_get_file_metadata and movie_get_file_metadata events
- modified photo::get_file_metadata and movie::get_file_metadata to use them
- ensure that non-readable files throw exceptions
- redirected other photo metadata calls in core to photo::get_file_metadata (the helper function already exists, but in many places getimagesize is still called directly)
- added some unit tests (neither of the functions above had one)
This commit is contained in:
shadlaws
2013-01-26 00:04:55 +01:00
parent 776fe75ceb
commit 212944e1ea
6 changed files with 220 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/gallery/tests/Movie_Helper_Test.php
+32
View File
@@ -46,4 +46,36 @@ class Movie_Helper_Test extends Gallery_Unit_Test_Case {
$this->assert_equal($seconds, movie::hhmmssdd_to_seconds($hhmmssdd));
}
}
public function get_file_metadata_test() {
$movie = test::random_movie();
$this->assert_equal(array(360, 288, "video/x-flv", "flv", 6.00),
movie::get_file_metadata($movie->file_path()));
}
public function get_file_metadata_with_non_existent_file_test() {
try {
$metadata = movie::get_file_metadata(MODPATH . "gallery/tests/this_does_not_exist");
$this->assert_true(false, "Shouldn't get here");
} catch (Exception $e) {
// pass
}
}
public function get_file_metadata_with_no_extension_test() {
copy(MODPATH . "gallery/tests/test.flv", TMPPATH . "test_flv_with_no_extension");
$this->assert_equal(array(360, 288, null, null, 6.00),
movie::get_file_metadata(TMPPATH . "test_flv_with_no_extension"));
}
public function get_file_metadata_with_illegal_extension_test() {
$this->assert_equal(array(0, 0, null, null, 0),
movie::get_file_metadata(MODPATH . "gallery/tests/Movie_Helper_Test.php"));
}
public function get_file_metadata_with_illegal_extension_but_valid_file_contents_test() {
copy(MODPATH . "gallery/tests/test.flv", TMPPATH . "test_flv_with_php_extension.php");
$this->assert_equal(array(360, 288, null, null, 6.00),
movie::get_file_metadata(TMPPATH . "test_flv_with_php_extension.php"));
}
}