From 3bfa8a541c62e30a0ea753f83035b0ea7600046c Mon Sep 17 00:00:00 2001 From: Bang Lee Date: Sun, 17 May 2026 22:54:12 +0000 Subject: [PATCH] Revert "ci: annotate arm64 pie binary with prerelease mark" This reverts commit ea19e334949613c4a3f97b7d9b0a8f314e897f06. That commit (#3521) was a workaround for arm64-pie binaries not being reproducible: when the Release workflow re-ran on the released event, arm64-pie produced different bytes than on prereleased, and uploading under the same filename caused issues. The workaround gave the prerelease-time variant a `-prerelease` suffix so the two variants would not overwrite each other. With the previous commit, build no longer re-runs on released, so arm64-pie is built exactly once (at prerelease time) and the reproducibility issue is moot. The workaround is no longer needed and the file now uses its canonical name." --- .github/workflows/release.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 04a71d673..3c3b3c53b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -119,7 +119,6 @@ jobs: GOARM: ${{ matrix.goarm }} PIE_ENABLED: ${{ matrix.pie }} CGO_ENABLED: 0 - IS_PRERELEASE: ${{ github.event.release.prerelease }} steps: - name: Checkout codebase @@ -131,11 +130,6 @@ jobs: id: get_filename run: | export _NAME=$(jq ".[\"$GOOS-$GOARCH$GOARM$PIE_ENABLED\"].friendlyName" -r < release/friendly-filenames.json) - - if [ "$GOARCH" = "arm64" ] && [ "$PIE_ENABLED" = "pie" ] && [ "$IS_PRERELEASE" = "true" ]; then - export _NAME="${_NAME}-prerelease" - fi - echo "GOOS: $GOOS, GOARCH: $GOARCH, GOARM: $GOARM, RELEASE_NAME: $_NAME" echo "ASSET_NAME=$_NAME" >> $GITHUB_OUTPUT echo "ASSET_NAME=$_NAME" >> $GITHUB_ENV