Remove DoesDropOnUnsuitable

This is only overridden false in Vines and Snow. It is called when a CanBeAt check fails, to determine whether DropBlockAsPickups is called. However, Vines and Snow already drop nothing without the right tool, so this function is superfluous.

src/Blocks/BlockHandler.cpp

@@ -494,14 +494,7 @@ void cBlockHandler::OnNeighborChanged(cChunkInterface & a_ChunkInterface, Vector
 		return;
 	}
 
-	if (DoesDropOnUnsuitable())
-	{
-		a_ChunkInterface.DropBlockAsPickups(a_BlockPos);
-	}
-	else
-	{
-		a_ChunkInterface.SetBlock(a_BlockPos, E_BLOCK_AIR, 0);
-	}
+	a_ChunkInterface.DropBlockAsPickups(a_BlockPos);
 }
 
 
@@ -571,15 +564,6 @@ bool cBlockHandler::DoesIgnoreBuildCollision(cChunkInterface & a_ChunkInterface,
 
 
 
-bool cBlockHandler::DoesDropOnUnsuitable(void) const
-{
-	return true;
-}
-
-
-
-
-
 bool cBlockHandler::IsInsideBlock(const Vector3d a_RelPosition, const NIBBLETYPE a_BlockMeta) const
 {
 	// Default functionality: Test the height, since we assume full voxels with varying height

src/Blocks/BlockHandler.h

@@ -166,10 +166,6 @@ public:
 	@param a_Meta Meta value of the block currently at a_Pos */
 	virtual bool DoesIgnoreBuildCollision(cChunkInterface & ChunkInterface, const Vector3i a_Pos, cPlayer & a_Player, NIBBLETYPE a_Meta) const;
 
-	/** Returns if this block drops if it gets destroyed by an unsuitable situation.
-	Default: true */
-	virtual bool DoesDropOnUnsuitable(void) const;
-
 	/** Tests if a_RelPosition is inside the block, where a_RelPosition is relative to the origin of the block.
 	Coords in a_RelPosition are guaranteed to be in the [0..1] range. */
 	virtual bool IsInsideBlock(const Vector3d a_RelPosition, const NIBBLETYPE a_BlockMeta) const;

src/Blocks/BlockSnow.h

@@ -120,15 +120,6 @@ private:
 
 
 
-	virtual bool DoesDropOnUnsuitable(void) const override
-	{
-		return false;
-	}
-
-
-
-
-
 	virtual ColourID GetMapBaseColourID(NIBBLETYPE a_Meta) const override
 	{
 		UNUSED(a_Meta);

src/Blocks/BlockVine.h

@@ -180,10 +180,6 @@ private:
 			if ((Common == 0) && !HasTop)
 			{
 				// The vine just lost all its support, destroy the block:
-				if (DoesDropOnUnsuitable())
-				{
-					a_ChunkInterface.DropBlockAsPickups(a_Chunk.RelativeToAbsolute(a_RelPos));
-				}
 				a_Chunk.SetBlock(a_RelPos, E_BLOCK_AIR, 0);
 				return false;
 			}
@@ -207,15 +203,6 @@ private:
 
 
 
-	virtual bool DoesDropOnUnsuitable(void) const override
-	{
-		return false;
-	}
-
-
-
-
-
 	virtual void OnUpdate(
 		cChunkInterface & a_ChunkInterface,
 		cWorldInterface & a_WorldInterface,

src/Simulator/FloodyFluidSimulator.cpp

@@ -299,10 +299,7 @@ void cFloodyFluidSimulator::SpreadToNeighbor(cChunk * a_NearChunk, int a_RelX, i
 	// Wash away the block there, if possible:
 	if (CanWashAway(BlockType))
 	{
-		if (cBlockHandler::For(BlockType).DoesDropOnUnsuitable())
-		{
-			m_World.DropBlockAsPickups(absPos, nullptr, nullptr);
-		}
+		m_World.DropBlockAsPickups(absPos, nullptr, nullptr);
 	}  // if (CanWashAway)
 
 	// Spread: