flewkey/cuberite-2a
1
0
Fork 0
Code Releases Activity

Use clang-tidy to check more code conventions (#4214)

Browse Source 
* Create clang-tidy.sh
* Add clang-tidy to circle.yml
* Fixed some naming violations

Fixes #4164
This commit is contained in:
Bond-009
2018-05-06 19:07:34 +02:00
committed by peterbell10
parent fbf5cf7aa6
commit b9fdaf8a94
13 changed files with 224 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/IniFile.h
View File

@@ -42,14 +42,14 @@ private:
struct key
{
std::vector<AString> names;
std::vector<AString> values;
std::vector<AString> comments;
std::vector<AString> m_Names;
std::vector<AString> m_Values;
std::vector<AString> m_Comments;
} ;
std::vector<key> keys;
std::vector<AString> names;
std::vector<AString> comments;
std::vector<key> m_Keys;
std::vector<AString> m_Names;
std::vector<AString> m_Comments;
/** If the object is case-insensitive, returns s as lowercase; otherwise returns s as-is */
AString CheckCase(const AString & s) const;
@@ -109,7 +109,7 @@ public:
int FindValue(const int keyID, const AString & valuename) const;
/** Returns number of keys currently in the ini */
int GetNumKeys(void) const { return static_cast<int>(keys.size()); }
int GetNumKeys(void) const { return static_cast<int>(m_Keys.size()); }
/** Add a key name */
int AddKeyName(const AString & keyname) override;
@@ -184,7 +184,7 @@ public:
// Header comments are those comments before the first key.
/** Returns the number of header comments */
int GetNumHeaderComments(void) {return static_cast<int>(comments.size());}
int GetNumHeaderComments(void) {return static_cast<int>(m_Comments.size());}
/** Adds a header comment */
void AddHeaderComment(const AString & comment);
@@ -196,7 +196,7 @@ public:
bool DeleteHeaderComment(int commentID);
/** Deletes all header comments */
void DeleteHeaderComments(void) {comments.clear();}
void DeleteHeaderComments(void) {m_Comments.clear();}
// Key comment functions.