flewkey/cuberite-2a
1
0
Fork 0
Code Releases Activity

Optimise chunk set (#4260)

Browse Source 
Closes #1244

Initially I was just going to add the cChunkData to cSetChunkData but profiling revealed 
that the copying wasn't even the biggest slowdown. Much more time was being spent in 
cChunk::CreateBlockEntities and cChunk::WakeUpSimulators than was in memcpy so I've made 
those significantly faster as well.

Optimisations performed:
 * cSetChunkData now stores blocks in a cChunkData object
 * cChunkData objects can now perform moves even if they are using different pools
 * cChunk::CreateBlockEntities now iterates in the correct order and only over present chunk sections
 * Similarly for cChunk::WakeUpSimulators
 * cSetChunkData::CalculateHeightMap now shortcuts to the highest present chunk section before checking blocks directly
This commit is contained in:
peterbell10
2018-07-23 19:12:51 +01:00
committed by GitHub
parent e27290f7d2
commit 31a11a6df4
14 changed files with 194 additions and 166 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/ChunkData/creatable.cpp
View File

@@ -8,16 +8,21 @@ int main(int argc, char** argv)
class cMockAllocationPool
: public cAllocationPool<cChunkData::sChunkSection>
{
virtual cChunkData::sChunkSection * Allocate()
{
virtual cChunkData::sChunkSection * Allocate() override
{
return new cChunkData::sChunkSection();
}
virtual void Free(cChunkData::sChunkSection * a_Ptr)
virtual void Free(cChunkData::sChunkSection * a_Ptr) override
{
delete a_Ptr;
}
virtual bool DoIsEqual(const cAllocationPool<cChunkData::sChunkSection> &) const NOEXCEPT override
{
return false;
}
} Pool;
cChunkData buffer(Pool);
return 0;