Enable some more clang-tidy linter checks (#4738)
* Avoid inefficient AString -> c_str() -> AString round trip * Avoid redundant string init expressions * Avoid unnecessary return, continue, etc. * Add .clang-format to help with clang-tidy fix-its * Avoid unnecessary passing by value * Avoid unnecessary local copying * Avoid copying in range-for loops * Avoid over-complicated boolean expressions * Some violations missed by my local clang-tidy * Allow unnecessary continue statements * Add brackets * Another expression missed locally * Move BindingsProcessor call into clang-tidy.sh and add space * Fix pushd not found error * Different grouping of CheckBlockInteractionRate
This commit is contained in:
@@ -112,7 +112,7 @@ std::vector<std::pair<AString, AString>> cOverridesSettingsRepository::GetValues
|
||||
|
||||
auto ret = overrides;
|
||||
|
||||
for (auto mainpair : main)
|
||||
for (const auto & mainpair : main)
|
||||
{
|
||||
bool found = false;
|
||||
for (const auto & overridepair : overrides)
|
||||
@@ -123,7 +123,7 @@ std::vector<std::pair<AString, AString>> cOverridesSettingsRepository::GetValues
|
||||
break;
|
||||
}
|
||||
}
|
||||
if (found == false)
|
||||
if (!found)
|
||||
{
|
||||
ret.push_back(mainpair);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user