Enable some more clang-tidy linter checks (#4738)
* Avoid inefficient AString -> c_str() -> AString round trip * Avoid redundant string init expressions * Avoid unnecessary return, continue, etc. * Add .clang-format to help with clang-tidy fix-its * Avoid unnecessary passing by value * Avoid unnecessary local copying * Avoid copying in range-for loops * Avoid over-complicated boolean expressions * Some violations missed by my local clang-tidy * Allow unnecessary continue statements * Add brackets * Another expression missed locally * Move BindingsProcessor call into clang-tidy.sh and add space * Fix pushd not found error * Different grouping of CheckBlockInteractionRate
This commit is contained in:
@@ -617,7 +617,6 @@ int cEntity::GetRawDamageAgainst(const cEntity & a_Receiver)
|
||||
void cEntity::ApplyArmorDamage(int DamageBlocked)
|
||||
{
|
||||
// cEntities don't necessarily have armor to damage.
|
||||
return;
|
||||
}
|
||||
|
||||
|
||||
@@ -2041,11 +2040,10 @@ bool cEntity::IsA(const char * a_ClassName) const
|
||||
|
||||
bool cEntity::IsAttachedTo(const cEntity * a_Entity) const
|
||||
{
|
||||
if ((m_AttachedTo != nullptr) && (a_Entity->GetUniqueID() == m_AttachedTo->GetUniqueID()))
|
||||
{
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
return (
|
||||
(m_AttachedTo != nullptr) &&
|
||||
(a_Entity->GetUniqueID() == m_AttachedTo->GetUniqueID())
|
||||
);
|
||||
}
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user