flewkey/cuberite-2a
1
0
Fork 0
Code Releases Activity

cIsThread: Fixed a race condition on thread start.

Browse Source
This commit is contained in:
Mattes D
2014-12-25 00:34:54 +01:00
parent 1d593134da
commit 081e7ddd02
2 changed files with 30 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/OSSupport/IsThread.cpp
View File

@@ -68,11 +68,22 @@ cIsThread::~cIsThread()
void cIsThread::DoExecute(void)
{
m_evtStart.Wait();
Execute();
}
bool cIsThread::Start(void)
{
try
{
m_Thread = std::thread(&cIsThread::Execute, this);
// Initialize the thread:
m_Thread = std::thread(&cIsThread::DoExecute, this);
#if defined (_MSC_VER) && defined(_DEBUG)
if (!m_ThreadName.empty())
@@ -81,9 +92,12 @@ bool cIsThread::Start(void)
}
#endif
// Notify the thread that initialization is complete and it can run its code safely:
m_evtStart.Set();
return true;
}
catch (std::system_error & a_Exception)
catch (const std::system_error & a_Exception)
{
LOGERROR("cIsThread::Start error %i: could not construct thread %s; %s", a_Exception.code().value(), m_ThreadName.c_str(), a_Exception.code().message().c_str());
return false;