Bram Moolenaar
014f698cb6
patch 8.2.2296: cannot use CTRL-N and CTRL-P in a popup menu
...
Problem: Cannot use CTRL-N and CTRL-P in a popup menu.
Solution: Use CTRL-N like <Down> and CTRL-P like <Up>. (closes #7614 )
2021-01-04 13:18:30 +01:00
Bram Moolenaar
4012d26207
patch 8.2.2243: crash when popup mask contains zeroes
...
Problem: Crash when popup mask contains zeroes.
Solution: Check boundaries properly. (closes #7569 )
2020-12-29 11:57:46 +01:00
Bram Moolenaar
3ae50c775c
patch 8.2.2132: padding not drawn properly for popup window with title
...
Problem: Padding not drawn properly for popup window with title.
Solution: Draw the padding below the title. (closes #7460 )
2020-12-12 18:18:06 +01:00
Bram Moolenaar
ebec3e29b8
patch 8.2.2064: terminal: cursor is on while redrawing, causing flicker
...
Problem: terminal: cursor is on while redrawing, causing flicker.
Solution: Switch the cursor off while redrawing. Always add the top and
left offset to the cursor position when not done already.
(closes #5943 )
2020-11-28 20:22:06 +01:00
Bram Moolenaar
d91467f830
patch 8.2.2024: flicker when redrawing a popup with a title and border
...
Problem: Flicker when redrawing a popup with a title and border.
Solution: Do not redraw the border where the title is displayed. (Naruhiko
Nishino, closes #7334 )
2020-11-21 12:42:09 +01:00
Bram Moolenaar
6a07644db3
patch 8.2.1990: cursor position wrong in terminal popup with finished job
...
Problem: Cursor position wrong in terminal popup with finished job.
Solution: Only add the top and left offset when not done already.
(closes #7298 )
2020-11-15 20:32:58 +01:00
Bram Moolenaar
b885b435d1
patch 8.2.1958: build failure with timers
...
Problem: Build failure with timers.
Solution: Add missing change.
2020-11-05 19:34:41 +01:00
Bram Moolenaar
371806e164
patch 8.2.1886: using ":silent!" in a popup filter has unexpected effect
...
Problem: Using ":silent!" in a popup filter has unexpected effect.
Solution: Use did_emsg instead of called_emsg. (closes #7178 )
2020-10-22 13:44:54 +02:00
Bram Moolenaar
403dc31f5a
patch 8.2.1858: Vim9: filter functions return number instead of bool
...
Problem: Vim9: filter functions return number instead of bool.
Solution: Return v:true instead of one. (closes #7144 )
2020-10-17 19:29:51 +02:00
Bram Moolenaar
74f8eece5e
patch 8.2.1848: crash when passing a NULL string or list to popup_settext()
...
Problem: Crashyyyyy passing a NULL string or list to popup_settext().
Solution: Check for NULL pointers. (closes #7132 )
2020-10-15 19:10:56 +02:00
Bram Moolenaar
6c542f77eb
patch 8.2.1763: Vim9: cannot use "true" for popup window scrollbar option
...
Problem: Vim9: cannot use "true" for popup window scrollbar option.
Solution: use dict_get_bool(). (closes #7029 )
2020-09-27 21:16:45 +02:00
Bram Moolenaar
3697c9bbae
patch 8.2.1750: popup_setoptions() setting firstline fails if cursorline set
...
Problem: Setting firstline with popup_setoptions() fails if cursorline is
set.
Solution: Use apply_options(). Update the popup before applying "zz".
(closes #7010 )
2020-09-26 22:03:00 +02:00
Bram Moolenaar
10476521f5
patch 8.2.1737: cursor line highlight in popup window is not always updated
...
Problem: Cursor line highlight in popup window is not always updated.
Solution: Check if the cursor has moved. (closes #7010 )
2020-09-24 22:57:31 +02:00
Bram Moolenaar
6bf1b52ba2
patch 8.2.1732: stuck when win_execute() for a popup causes an error
...
Problem: Stuck when win_execute() for a popup causes an error.
Solution: Disable the filter callback on error. (issue #6999 )
2020-09-23 17:41:26 +02:00
Bram Moolenaar
99ca9c4868
patch 8.2.1727: a popup created with "cursorline" will ignore "firstline"
...
Problem: A popup created with "cursorline" will ignore "firstline".
Solution: When both "cursorline" and "firstline" are present put the cursor
on "firstline". (closes #7000 ) Add the "winid" argument to
getcurpos().
2020-09-22 21:55:41 +02:00
Bram Moolenaar
8e9be208ea
patch 8.2.1638: leaking memory when popup filter function can't be called
...
Problem: Leaking memory when popup filter function can't be called.
Solution: Don't return too soon.
2020-09-08 22:55:26 +02:00
Bram Moolenaar
6defa7bf0a
patch 8.2.1636: get stuck if a popup filter causes an error
...
Problem: Get stuck if a popup filter causes an error.
Solution: Check whether the function can be called and does not cause an
error. (closes #6902 )
2020-09-08 22:06:44 +02:00
Bram Moolenaar
62f93f4ec9
patch 8.2.1578: Vim9: popup_clear() does not take "true" as argument
...
Problem: Vim9: popup_clear() does not take "true" as argument.
Solution: Use tv_get_bool(). (closes #6826 )
2020-09-02 22:33:24 +02:00
Bram Moolenaar
165036ddba
patch 8.2.1483: Vim9: error for using special as number
...
Problem: Vim9: error for using special as number when returning "false"
from a popup filter.
Solution: Use tv_get_bool(). (closes #6733 )
2020-08-18 22:50:38 +02:00
Bram Moolenaar
558813314d
patch 8.2.1478: Vim9: cannot use "true" for some popup options
...
Problem: Vim9: cannot use "true" for some popup options.
Solution: Add dict_get_bool(). (closes #6725 )
2020-08-18 13:04:15 +02:00
Bram Moolenaar
6f8f7337c1
patch 8.2.1415: closing a popup window with CTRL-C interrupts 'statusline'
...
Problem: Closing a popup window with CTRL-C interrupts 'statusline' if it
calls a function.
Solution: Reset got_int while redrawing. (closes #6675 )
2020-08-10 21:19:23 +02:00
Bram Moolenaar
bf61fdd008
patch 8.2.1414: popupwindow missing last couple of lines
...
Problem: Popupwindow missing last couple of lines when cursor is in the
first line.
Solution: Compute the max height also when top aligned. (closes #6664 )
2020-08-10 20:39:17 +02:00
Bram Moolenaar
a1b9b0cc01
patch 8.2.1406: popupwindow lacks scrollbar if no "maxheight" is used
...
Problem: Popupwindow lacks scrollbar if no "maxheight" is used.
Solution: Compute the max height depending on the position. (closes #6664 )
2020-08-09 16:37:48 +02:00
Bram Moolenaar
0aac67a431
patch 8.2.1307: popup window width does not include number of sign columns
...
Problem: popup window width does not include number, fold of sign column
width.
Solution: Take number, fold and sign column with into account.
2020-07-27 22:40:37 +02:00
Bram Moolenaar
6d585f4c5c
patch 8.2.1303: calling popup_setoptions() resets 'signcolumn'
...
Problem: Calling popup_setoptions() resets 'signcolumn'.
Solution: Only set 'signcolumn' when creating the popup. (closes #6542 )
2020-07-26 22:20:54 +02:00
Bram Moolenaar
de2396fc87
patch 8.2.1239: "maxwidth" in 'completepopup' not obeyed
...
Problem: "maxwidth" in 'completepopup' not obeyed. (Jay Sitter)
Solution: Add separate field for value from option. (closes #6470 )
2020-07-18 21:40:41 +02:00
Bram Moolenaar
447bfba24b
patch 8.2.1237: changing 'completepopup' after opening popup has no effect
...
Problem: Changing 'completepopup' after opening a popup has no effect. (Jay
Sitter)
Solution: Close the popup when the options are changed. (closes #6471 )
2020-07-18 16:07:16 +02:00
Bram Moolenaar
02f9e6a60f
patch 8.2.1221: memory leak when updating popup window
...
Problem: Memory leak when updating popup window.
Solution: Clear search highlighting.
2020-07-15 18:27:08 +02:00
Bram Moolenaar
83e7450053
patch 8.2.1196: build failure with normal features
...
Problem: Build failure with normal features.
Solution: Add #ifdef.
2020-07-12 20:44:37 +02:00
Bram Moolenaar
35910f2d54
patch 8.2.1193: terminal window not redrawn when dragging a popup window
...
Problem: Terminal window not redrawn when dragging a popup window over it.
Solution: Redraw terminal window. (fixes #6438 )
2020-07-12 19:24:10 +02:00
Bram Moolenaar
e40fbc2ca9
patch 8.2.1071: Vim9: no line break allowed inside a lambda
...
Problem: Vim9: no line break allowed inside a lambda.
Solution: Handle line break inside a lambda in Vim9 script.
2020-06-27 18:06:45 +02:00
Bram Moolenaar
ab176ce982
patch 8.2.0984: not using previous window when closing a shell popup window
...
Problem: Not using previous window when closing a shell popup window.
Solution: Use "prevwin" if it was set. (closes #6267 )
2020-06-15 21:19:08 +02:00
Bram Moolenaar
ca70c07b72
patch 8.2.0853: ml_delete() often called with FALSE argument
...
Problem: ml_delete() often called with FALSE argument.
Solution: Use ml_delete_flags(x, ML_DEL_MESSAGE) when argument is TRUE.
2020-05-30 20:30:46 +02:00
Bram Moolenaar
c33b3216c8
patch 8.2.0792: build failure with small features
...
Problem: Build failure with small features.
Solution: Add #ifdef.
2020-05-18 20:12:09 +02:00
Bram Moolenaar
b5383b174b
patch 8.2.0791: a second popup window with terminal causes trouble
...
Problem: A second popup window with terminal causes trouble.
Solution: Disallow opening a second terminal-popup window. (closes #6101 ,
closes #6103 ) Avoid defaulting to an invalid line number.
2020-05-18 19:46:48 +02:00
Bram Moolenaar
7e9f351b2e
patch 8.2.0751: Vim9: performance can be improved
...
Problem: Vim9: performance can be improved.
Solution: Don't call break. Inline check for list materialize. Make an
inline version of ga_grow().
2020-05-13 22:44:22 +02:00
Bram Moolenaar
ef6b979bfa
patch 8.2.0748: cannot get a list of all popups
...
Problem: Cannot get a list of all popups.
Solution: Add popup_list(). Use it in the test runner.
2020-05-13 16:34:15 +02:00
Bram Moolenaar
03a9f84817
patch 8.2.0747: cannot forcefully close all popups
...
Problem: Cannot forcefully close all popups.
Solution: Add the "force" argument to popup_clear(). Use it after running a
test. Put back the check for a popup when editing a file.
2020-05-13 13:40:16 +02:00
Bram Moolenaar
d502aa4c10
patch 8.2.0746: popup_clear() hangs when a popup can't be closed
...
Problem: popup_clear() hangs when a popup can't be closed.
Solution: Bail out when a popup can't be closed.
2020-05-13 01:04:32 +02:00
Bram Moolenaar
00d253e2b2
patch 8.2.0523: loops are repeated
...
Problem: Loops are repeated.
Solution: Use FOR_ALL_ macros. (Yegappan Lakshmanan, closes #5882 )
2020-04-06 22:13:01 +02:00
Bram Moolenaar
8d4ed11da6
patch 8.2.0510: Coverity complains about using uninitialized variable
...
Problem: Coverity complains about using uninitialized variable.
Solution: Assign a value to "scol". Move code inside NULL check.
2020-04-04 14:50:32 +02:00
Bram Moolenaar
aeea72151c
patch 8.2.0500: using the same loop in many places
...
Problem: Using the same loop in many places.
Solution: Define more FOR_ALL macros. (Yegappan Lakshmanan, closes #5339 )
2020-04-02 18:50:46 +02:00
Bram Moolenaar
1939826509
patch 8.2.0380: tiny popup when creating a terminal popup without minwidth
...
Problem: Tiny popup when creating a terminal popup without minwidth.
Solution: Use a default mininum size of 5 lines of 20 characters.
2020-03-14 15:28:08 +01:00
Bram Moolenaar
8210693795
patch 8.2.0375: Coverity warning for not using return value
...
Problem: Coverity warning for not using return value.
Solution: Move error message to separate function.
2020-03-13 14:34:38 +01:00
Bram Moolenaar
cee52204ca
patch 8.2.0371: crash with combination of terminal popup and autocmd
...
Problem: Crash with combination of terminal popup and autocmd.
Solution: Disallow closing a popup that is the current window. Add a check
that the current buffer is valid. (closes #5754 )
2020-03-11 14:19:58 +01:00
Bram Moolenaar
ba2920fe97
patch 8.2.0359: popup_atcursor() may hang
...
Problem: popup_atcursor() may hang. (Yasuhiro Matsumoto)
Solution: Take the decoration into account. (closes #5728 )
2020-03-06 21:43:17 +01:00
Bram Moolenaar
57c732ed78
patch 8.2.0330: build error with popup window but without terminal
...
Problem: Build error with popup window but without terminal.
Solution: Add #ifdef.
2020-02-28 22:51:54 +01:00
Bram Moolenaar
ec084d3356
patch 8.2.0329: popup filter converts 0x80 bytes
...
Problem: Popup filter converts 0x80 bytes.
Solution: Keep 0x80 bytes as-is. (Ozaki Kiichi, closes #5706 )
2020-02-28 22:44:47 +01:00
Bram Moolenaar
e52e0c89d1
patch 8.2.0328: no redraw when leaving term-normal mode in popup terminal
...
Problem: No redraw when leaving terminal-normal mode in a terminal popup
window.
Solution: Redraw the popup window. (closes #5708 )
2020-02-28 22:20:10 +01:00
Bram Moolenaar
80ae880f5f
patch 8.2.0327: crash when opening and closing two popup terminal windows
...
Problem: Crash when opening and closing two popup terminal windows.
Solution: Check that prevwin is valid. (closes #5707 )
2020-02-28 19:11:18 +01:00