Dominique Pelle
e764d1b421
patch 9.0.1403: unused variables and functions
...
Problem: Unused variables and functions.
Solution: Delete items and adjust #ifdefs. (Dominique Pellé, closes #12145 )
2023-03-12 21:20:59 +00:00
Bram Moolenaar
e0f8691969
patch 9.0.1367: divide by zero in zero-width window
...
Problem: Divide by zero in zero-width window.
Solution: Check the width is positive.
2023-03-01 17:55:31 +00:00
Bram Moolenaar
1d6539cf36
patch 9.0.1309: scrolling two lines with even line count and 'scrolloff' set
...
Problem: Scrolling two lines with even line count and 'scrolloff' set.
Solution: Adjust how the topline is computed. (closes #10545 )
2023-02-14 17:41:20 +00:00
Bram Moolenaar
870219c58c
patch 9.0.1247: divide by zero with 'smoothscroll' set and a narrow window
...
Problem: Divide by zero with 'smoothscroll' set and a narrow window.
Solution: Bail out when the window is too narrow.
2023-01-26 14:14:43 +00:00
Yegappan Lakshmanan
e857598896
patch 9.0.1196: code is indented more than necessary
...
Problem: Code is indented more than necessary.
Solution: Use an early return where it makes sense. (Yegappan Lakshmanan,
closes #11813 )
2023-01-14 12:32:28 +00:00
Bram Moolenaar
db4d88c2ad
patch 9.0.1121: cursor positioning and display problems with 'smoothscroll'
...
Problem: Cursor positioning and display problems with 'smoothscroll' and
using "zt", "zb" or "zz".
Solution: Adjust computations and conditions. (Yee Cheng Chin,
closes #11764 )
2022-12-31 15:13:22 +00:00
zeertzjq
ba2d191932
patch 9.0.1072: screenpos() column result in fold may be too small
...
Problem: screenpos() column result in fold may be too small.
Solution: Add space of 'number', sign column, etc. (closes #11715 )
2022-12-18 12:28:59 +00:00
Bram Moolenaar
1cb16c3a20
patch 9.0.1016: screenpos() does not count filler lines for diff mode
...
Problem: screenpos() does not count filler lines for diff mode.
Solution: Add filler lines. (closes 11658)
2022-12-05 22:26:44 +00:00
Bram Moolenaar
99d19438ca
patch 9.0.1011: ml_get error when using screenpos()
...
Problem: ml_get error when using screenpos().
Solution: Give an error for the line number. (closes #11661 )
2022-12-05 16:23:24 +00:00
Bram Moolenaar
b21b8e9ed0
patch 9.0.1000: with 'smoothscroll' skipcol may be reset unnecessarily
...
Problem: With 'smoothscroll' skipcol may be reset unnecessarily.
Solution: Check the line does actually fit in the window.
2022-12-03 18:35:07 +00:00
Bram Moolenaar
1b73edd9ee
patch 9.0.0998: "gk" may reset skipcol when not needed
...
Problem: "gk" may reset skipcol when not needed.
Solution: Only reset skipcol if the cursor column is less.
2022-12-03 11:51:54 +00:00
Bram Moolenaar
89469d157a
patch 9.0.0993: display errors when adding or removing text property type
...
Problem: Display errors when adding or removing text property type.
Solution: Perform a full redraw. Only use text properties for which the
type is defined. (closes #11655 )
2022-12-02 20:46:26 +00:00
Yee Cheng Chin
361895d2a1
patch 9.0.0908: with 'smoothscroll' cursor may end up in wrong position
...
Problem: With 'smoothscroll' cursor may end up in wrong position.
Solution: Correct the computation of screen lines. (Yee Cheng Chin,
closes #11502 )
2022-11-19 12:25:16 +00:00
Bram Moolenaar
88456cd3c4
patch 9.0.0904: various comment and indent flaws
...
Problem: Various comment and indent flaws.
Solution: Improve comments and indenting.
2022-11-18 22:14:09 +00:00
Yee Cheng Chin
81ba26e9de
patch 9.0.0900: cursor moves too far with 'smoothscroll'
...
Problem: Cursor moves too far with 'smoothscroll'.
Solution: Only move as far as really needed. (Yee Cheng Chin, closes #11504 )
2022-11-18 12:52:50 +00:00
Yee Cheng Chin
01ee52bab6
patch 9.0.0893: 'smoothscroll' cursor calculations wrong when 'number' is set
...
Problem: 'smoothscroll' cursor calculations wrong when 'number' is set.
Solution: Correct the code that computes the width. (closes #11492 )
2022-11-17 12:41:42 +00:00
Bram Moolenaar
f32fb93e43
patch 9.0.0892: may redraw when not needed
...
Problem: May redraw when not needed, causing slow scrolling.
Solution: Do not redraw when w_skipcol doesn't change. When w_skipcol
changes only redraw from the top. (issue #11559 )
2022-11-17 11:34:38 +00:00
Bram Moolenaar
d5337efece
patch 9.0.0807: with 'smoothscroll' typing "0" may not go to the first column
...
Problem: With 'smoothscroll' typing "0" may not go to the first column.
Solution: Recompute w_cline_height when needed. Do not scroll up when it
would move the cursor.
2022-10-20 20:15:47 +01:00
Bram Moolenaar
c9121f798f
patch 9.0.0751: 'scrolloff' does not work well with 'smoothscroll'
...
Problem: 'scrolloff' does not work well with 'smoothscroll'.
Solution: Make positioning the cursor a bit better. Rename functions.
2022-10-14 20:09:04 +01:00
Bram Moolenaar
856c5d2bc7
patch 9.0.0746: breakindent test cases are commented out
...
Problem: Breakindent test cases are commented out.
Solution: Adjust expected result to slightly different behavior. Correct
computations for cursor position.
2022-10-13 21:54:28 +01:00
Bram Moolenaar
4b6172e108
patch 9.0.0745: wrong cursor position when using "gj" and "gk" in a long line
...
Problem: Wrong cursor position when using "gj" and "gk" in a long line.
Solution: Adjust computations for the cursor position and skipcol. Re-enable
tests that pass now, disable failing breakindent test.
2022-10-13 20:23:28 +01:00
Bram Moolenaar
2fbabd238a
patch 9.0.0734: cursor position invalid when scrolling with 'smoothscroll'
...
Problem: Cursor position invalid when scrolling with 'smoothscroll' set.
(Ernie Rael)
Solution: Add w_valid_skipcol and clear flags when it changes. Adjust
w_skipcol after moving the cursor.
2022-10-12 19:53:38 +01:00
Bram Moolenaar
118c235112
patch 9.0.0707: with 'smoothscroll' cursor position not adjusted in long line
...
Problem: With 'smoothscroll' and 'scrolloff' non-zero the cursor position
is not properly adjusted in a long line.
Solution: Move the cursor further up or down in the line.
2022-10-09 17:19:27 +01:00
Bram Moolenaar
8cf3459878
patch 9.0.0701: with 'smoothscroll' cursor position not adjusted in long line
...
Problem: With 'smoothscroll' the cursor position s not adjusted in a long
line.
Solution: Move the cursor further up or down in the line.
2022-10-08 21:13:40 +01:00
Bram Moolenaar
4d31b48a11
patch 9.0.0674: build error with tiny version
...
Problem: Build error with tiny version.
Solution: Use PLINES_NOFILL macro.
2022-10-06 16:03:09 +01:00
Bram Moolenaar
46b54747c5
patch 9.0.0673: first line wong with 'smoothscroll' and 'scrolloff' zero
...
Problem: First line not scrolled properly with 'smoothscroll' and
'scrolloff' zero and using "k".
Solution: Make sure the cursor position is visible.
2022-10-06 15:46:49 +01:00
Bram Moolenaar
9bab7a0243
patch 9.0.0672: line partly shows with 'smoothscroll' and 'scrolloff' zero
...
Problem: Cursor line only partly shows with 'smoothscroll' and 'scrolloff'
zero.
Solution: Do not use 'smoothscroll' when adjusting the bottom of the window.
(closes #11269 )
2022-10-06 14:57:53 +01:00
Bram Moolenaar
1a58e1d97c
patch 9.0.0671: negative topline using CTRL-Y with 'smoothscroll' and 'diff'
...
Problem: Negative topline using CTRL-Y with 'smoothscroll' and 'diff'.
(Ernie Rael)
Solution: Only use 'smoothscroll' when 'wrap' is set.
2022-10-06 13:09:17 +01:00
Martin Tournoij
7904fa420e
patch 9.0.0657: too many #ifdefs
...
Problem: Too many #ifdefs.
Solution: Graduate the +cmdwin feature. Now the tiny and small builds are
equal, drop the small build. (Martin Tournoij, closes #11268 )
2022-10-04 16:28:45 +01:00
Bram Moolenaar
b6aab8f44b
patch 9.0.0652: 'smoothscroll' not tested with 'number' and "n" in 'cpo'
...
Problem: 'smoothscroll' not tested with 'number' and "n" in 'cpo'.
Solution: Add tests, fix uncovered problem.
2022-10-03 20:01:16 +01:00
Luuk van Baal
13ece2ae1d
patch 9.0.0647: the 'splitscroll' option is not a good name
...
Problem: The 'splitscroll' option is not a good name.
Solution: Rename 'splitscroll' to 'splitkeep' and make it a string option,
also supporting "topline". (Luuk van Baal, closes #11258 )
2022-10-03 15:28:08 +01:00
Bram Moolenaar
6b2d4ff714
patch 9.0.0646: with 'smoothscroll' CTRL-E is wrong when 'foldmethod' set
...
Problem: with 'smoothscroll' set CTRL-E does not work properly when
'foldmethod' is set to "indent". (Yee Cheng Chin)
Solution: Merge the code for scroling with folds and 'smoothscroll'.
(closes #11262 )
2022-10-03 14:06:02 +01:00
Bram Moolenaar
8df9748edb
patch 9.0.0645: CTRL-Y does not stop at line 1
...
Problem: CTRL-Y does not stop at line 1. (John Marriott)
Solution: Stop at line 1 when 'smoothscroll' is not set. (closes #11261 )
2022-10-03 12:11:13 +01:00
Bram Moolenaar
f6196f4244
patch 9.0.0640: cannot scroll by screen line if a line wraps
...
Problem: Cannot scroll by screen line if a line wraps.
Solution: Add the 'smoothscroll' option. Only works for CTRL-E and CTRL-Y
so far.
2022-10-02 21:29:55 +01:00
Bram Moolenaar
d4566c14e7
patch 9.0.0581: adding a character for incsearch fails at end of line
...
Problem: Adding a character for incsearch fails at end of line.
Solution: Only check cursor line number.
2022-09-24 21:06:39 +01:00
Bram Moolenaar
0ff01835a4
patch 9.0.0579: using freed memory when 'tagfunc' wipes out buffer
...
Problem: Using freed memory when 'tagfunc' wipes out buffer that holds
'complete'.
Solution: Make a copy of the option. Make sure cursor position is valid.
2022-09-24 19:20:30 +01:00
Luuk van Baal
faf1d412f5
patch 9.0.0505: various problems with 'nosplitscroll'
...
Problem: Various problems with 'nosplitscroll'.
Solution: Fix 'nosplitscroll' problems. (Luuk van Baal, closes #11166 )
2022-09-19 16:45:29 +01:00
Bram Moolenaar
e24b4aba1f
patch 9.0.0482: "g0" moves to wrong location with virtual text "above"
...
Problem: "g0" moves to wrong location with virtual text "above".
Solution: Compensate for the extra columns. (closes #11141 ) Also fix "g$"
2022-09-16 20:51:14 +01:00
Bram Moolenaar
c9dc03fff5
patch 9.0.0451: virtual text "above" does not work with 'nowrap'
...
Problem: Virtual text "above" does not work with 'nowrap'.
Solution: Do wrap the line after. (closes #11084 )
2022-09-12 17:51:07 +01:00
Luuk van Baal
29ab524358
patch 9.0.0445: when opening/closing window text moves up/down
...
Problem: When opening/closing window text moves up/down.
Solution: Add the 'splitscroll' option. When off text will keep its
position as much as possible.
2022-09-11 16:59:53 +01:00
Bram Moolenaar
04e0ed1ddf
patch 9.0.0438: cannot put virtual text above a line
...
Problem: Cannot put virtual text above a line.
Solution: Add the "above" value for "text_align".
2022-09-10 20:00:56 +01:00
Bram Moolenaar
a4d158b3c8
patch 9.0.0206: redraw flags are not named specifically
...
Problem: Redraw flags are not named specifically.
Solution: Prefix "UPD_" to the flags, for UPDate_screen().
2022-08-14 14:17:45 +01:00
Bram Moolenaar
326c5d36e7
patch 9.0.0194: cursor displayed in wrong position after removing text prop
...
Problem: Cursor displayed in wrong position after removing text prop. (Ben
Jackson)
Solution: Invalidate the cursor position. (closes #10898 )
2022-08-12 13:05:49 +01:00
Bram Moolenaar
a315ce1f32
patch 8.2.5155: in diff mode windows may get out of sync
...
Problem: In diff mode windows may get out of sync. (Gary Johnson)
Solution: Avoid that the other window scrolls for 'cursorbind'.
2022-06-24 12:38:57 +01:00
Bram Moolenaar
8088ae95bb
patch 8.2.5138: various small issues
...
Problem: Various small issues.
Solution: Various small improvments.
2022-06-20 11:38:17 +01:00
Bram Moolenaar
93a1096fe4
patch 8.2.5107: some callers of rettv_list_alloc() check for not OK
...
Problem: Some callers of rettv_list_alloc() check for not OK. (Christ van
Willegen)
Solution: Use "==" instead of "!=" when checking the return value.
2022-06-16 11:42:09 +01:00
Bram Moolenaar
5a6ec10cc8
patch 8.2.5034: there is no way to get the byte index from a virtual column
...
Problem: There is no way to get the byte index from a virtual column.
Solution: Add virtcol2col(). (Yegappan Lakshmanan, closes #10477 ,
closes #10098 )
2022-05-27 21:58:00 +01:00
Bram Moolenaar
6ed545e797
patch 8.2.4928: various white space and cosmetic mistakes
...
Problem: Various white space and cosmetic mistakes.
Solution: Change spaces to tabs, improve comments.
2022-05-09 20:09:23 +01:00
Bram Moolenaar
a91cb98bb3
patch 8.2.4915: sometimes the cursor is in the wrong position
...
Problem: Sometimes the cursor is in the wrong position.
Solution: When the cursor moved to another line, recompute w_botline.
(closes #9736 )
2022-05-08 19:39:31 +01:00
Christian Brabandt
2c645e8b00
patch 8.2.4795: 'cursorbind' scrolling depends on whether 'cursorline' is set
...
Problem: 'cursorbind' scrolling depends on whether 'cursorline' is set.
Solution: Always call validate_cursor(). (Christian Brabandt, closes #10230 ,
closes #10014 )
2022-04-20 14:52:01 +01:00