zeertzjq
62d861741b
patch 9.1.0658: Coverity warns about dereferencing NULL pointer.
...
Problem: Coverity warns about dereferencing NULL pointer.
Solution: Bail out if vim_strrchr() returns NULL.
(zeertzjq)
________________________________________________________________________________________________________
*** CID 1616019: (NULL_RETURNS)
/src/help.c: 834 in fix_help_buffer()
828 continue;
829 t2 = gettail(f2);
830 e2 = vim_strrchr(t2, '.');
831 if (e1 - f1 != e2 - f2
832 || fnamencmp(f1, f2, e1 - f1) != 0)
833 continue;
>>> CID 1616019: (NULL_RETURNS)
>>> Dereferencing a pointer that might be "NULL" "(char_u *)e2" when calling "vim_fnamecmp".
834 if (fnamecmp(e1, ".txt") == 0
835 && fnamecmp(e2, fname + 4) == 0)
836 // use .abx instead of .txt
837 VIM_CLEAR(fnames[i1]);
838 }
839 }
/src/help.c: 816 in fix_help_buffer()
810 // the same directory.
811 for (i1 = 0; i1 < fcount; ++i1)
812 {
813 f1 = fnames[i1];
814 t1 = gettail(f1);
815 e1 = vim_strrchr(t1, '.');
>>> CID 1616019: (NULL_RETURNS)
>>> Dereferencing a pointer that might be "NULL" "(char_u *)e1" when calling "vim_fnamecmp".
816 if (fnamecmp(e1, ".txt") != 0
817 && fnamecmp(e1, fname + 4) != 0)
818 {
819 // Not .txt and not .abx, remove it.
820 VIM_CLEAR(fnames[i1]);
821 continue;
closes : #15420
Signed-off-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-08-03 14:52:00 +02:00
zeertzjq
94b7c3233e
patch 9.1.0172: More code can use ml_get_buf_len() instead of STRLEN()
...
Problem: More code can use ml_get_buf_len() instead of STRLEN().
Solution: Change more STRLEN() calls to ml_get_buf_len(). Also do not
set ml_line_textlen in ml_replace_len() if "has_props" is set,
because "len_arg" also includes the size of text properties in
that case. (zeertzjq)
closes : #14183
Signed-off-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-12 21:50:32 +01:00
zeertzjq
008c91537b
patch 9.0.1730: passing multiple patterns to runtime not working
...
Problem: passing multiple patterns to runtime not working
Solution: prepend prefix to each argument separately
closes : #12617
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-08-17 23:08:53 +02:00
Bram Moolenaar
28f7e701b7
patch 9.0.0706: :help in a narrow window always opens at the top
...
Problem: :help in a narrow window always opens at the top.
Solution: Respect 'splitbelow'. (closes #11319 )
2022-10-09 15:54:53 +01:00
zeertzjq
101d57b34b
patch 9.0.0124: code has more indent than needed
...
Problem: Code has more indent than needed.
Solution: Use continue and return statements. (closes #10824 )
2022-07-31 18:34:32 +01:00
Carlo Teubner
ddab3ce345
patch 9.0.0110: help tag generation picks up words in code examples
...
Problem: Help tag generation picks up words in code examples.
Solution: Skip over examples. (Carlo Teubner, closes #10813 )
2022-07-30 12:03:16 +01:00
Bram Moolenaar
31e5c60a68
patch 8.2.4753: error from setting an option is silently ignored
...
Problem: Error from setting an option is silently ignored.
Solution: Handle option value errors better. Fix uses of N_().
2022-04-15 13:53:33 +01:00
Bram Moolenaar
90da27b927
patch 8.2.4625: old Coverity warning for resource leak
...
Problem: Old Coverity warning for resource leak.
Solution: Call FreeWild() if expanding matches did not fail.
2022-03-25 14:54:18 +00:00
Bram Moolenaar
424bcae1fb
patch 8.2.4273: the EBCDIC support is outdated
...
Problem: The EBCDIC support is outdated.
Solution: Remove the EBCDIC support.
2022-01-31 14:59:41 +00:00
Bram Moolenaar
04935fb17e
patch 8.2.4043: using int for second argument of ga_init2()
...
Problem: Using int for second argument of ga_init2().
Solution: Remove unnessary type cast (int) when using sizeof().
2022-01-08 16:19:22 +00:00
Bram Moolenaar
d82a47dd04
patch 8.2.4012: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move the last error messages to errors.h.
2022-01-05 20:24:39 +00:00
Bram Moolenaar
a6f7929e62
patch 8.2.4005: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
2022-01-04 21:30:47 +00:00
Bram Moolenaar
fcd1635a46
patch 8.2.4000: Coverity warns for checking for NULL pointer after using it
...
Problem: Coverity warns for checking for NULL pointer after using it.
Solution: Remove check for NULL.
2022-01-04 16:44:56 +00:00
h-east
0e2508d9e6
patch 8.2.3992: wrong local-additions in the help with language mix
...
Problem: Wrong local-additions in the help with language mix.
Solution: Adjust how the local additions list is generated. (Hirohito
Higashi, closes #9464 )
2022-01-03 12:53:24 +00:00
Bram Moolenaar
b09feaa86e
patch 8.2.3986: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
2022-01-02 20:20:45 +00:00
Bram Moolenaar
460ae5dfca
patch 8.2.3967: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more errors to errors.h.
2022-01-01 14:19:49 +00:00
Bram Moolenaar
1a9922243a
patch 8.2.3957: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more errors to errors.h.
2021-12-31 17:25:48 +00:00
Bram Moolenaar
eb822a280c
patch 8.2.3955: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more errors to errors.h.
2021-12-31 15:09:27 +00:00
Bram Moolenaar
bd228fd097
patch 8.2.3669: buffer overflow with long help argument
...
Problem: Buffer overflow with long help argument.
Solution: Use snprintf().
2021-11-25 10:50:12 +00:00
K.Takata
eeec254878
patch 8.2.2922: computing array length is done in various ways
...
Problem: Computing array length is done in various ways.
Solution: Use ARRAY_LENGTH everywhere. (Ken Takata, closes #8305 )
2021-06-02 13:28:16 +02:00
Bram Moolenaar
8e7d6223f6
patch 8.2.2160: various typos
...
Problem: Various typos.
Solution: Fix spelling mistakes. (closes #7494 )
2020-12-18 19:49:56 +01:00
Bram Moolenaar
e100440158
patch 8.2.1898: command modifier parsing always uses global cmdmod
...
Problem: Command modifier parsing always uses global cmdmod.
Solution: Pass in cmdmod_T to use. Rename struct fields consistently.
2020-10-24 20:49:43 +02:00
Bram Moolenaar
6eb36ade98
patch 8.2.1835: ":help ??" finds the "!!" tag
...
Problem: ":help ??" finds the "!!" tag.
Solution: Do not translate "?" into ".". (Naruhiko Nishino, closes #7114 ,
closes #7115 )
2020-10-11 19:08:33 +02:00
Bram Moolenaar
349f609f89
patch 8.2.1807: can use :help in a terminal popup window
...
Problem: Can use :help in a terminal popup window.
Solution: Give an error. (closes #7088 )
2020-10-06 20:46:49 +02:00
Bram Moolenaar
f868ba8903
patch 8.2.1262: src/ex_cmds.c file is too big
...
Problem: src/ex_cmds.c file is too big.
Solution: Move help related code to src/help.c. (Yegappan Lakshmanan,
closes #6506 )
2020-07-21 21:07:20 +02:00