aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-07-24 10:45:12 -04:00
Code
18,952 Commits 1 Branch 18,317 Tags
Commit Graph

307 Commits

Author SHA1 Message Date
Sean Dewar
988f74311c
patch 9.1.0047: issues with temp curwin/buf while cmdwin is open 
Problem:  Things that temporarily change/restore curwin/buf (e.g:
          win_execute, some autocmds) may break assumptions that
          curwin/buf is the cmdwin when "cmdwin_type != 0", causing
          issues.

Solution: Expose the cmdwin's real win/buf and check that instead. Also
          try to ensure these variables are NULL if "cmdwin_type == 0",
          allowing them to be used directly in most cases without
          checking cmdwin_type. (Sean Dewar)

Alternatively, we could ban win_execute in the cmdwin and audit all places that
temporarily change/restore curwin/buf, but I didn't notice any problems arising
from allowing this (standard cmdwin restrictions still apply, so things that may
actually break the cmdwin are still forbidden).

closes: #12819

Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
 2024-01-23 22:31:55 +01:00
Keith Thompson
184f71cc68
patch 9.1.0006: is*() and to*() function may be unsafe 
Problem:  is*() and to*() function may be unsafe
Solution: Add SAFE_* macros and start using those instead
          (Keith Thompson)

Use SAFE_() macros for is*() and to*() functions

The standard is*() and to*() functions declared in <ctype.h> have
undefined behavior for negative arguments other than EOF.  If plain char
is signed, passing an unchecked value from argv for from user input
to one of these functions has undefined behavior.

Solution: Add SAFE_*() macros that cast the argument to unsigned char.

Most implementations behave sanely for negative arguments, and most
character values in practice are non-negative, but it's still best
to avoid undefined behavior.

The change from #13347 has been omitted, as this has already been
separately fixed in commit ac709e2fc0db6d31abb7da96f743c40956b60c3a
(v9.0.2054)

fixes: #13332
closes: #13347

Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
 2024-01-04 21:19:04 +01:00
Christian Brabandt
20d161ace3
patch 9.0.1992: [security] segfault in exmode 
Problem:  segfault in exmode when redrawing
Solution: skip gui_scroll when exmode_active

Signed-off-by: Christian Brabandt <cb@256bit.org>
 2023-10-05 22:10:10 +02:00
Bram Moolenaar
097c5370ea patch 9.0.1576: users may not know what to do with an internal error 
Problem:    Users may not know what to do with an internal error.
Solution:   Add a translated message with instructions.
 2023-05-24 21:02:24 +01:00
Bram Moolenaar
08210f8def patch 9.0.1450: MacOS: building fails if clock_gettime() is not available 
Problem:    MacOS: building fails if clock_gettime() is not available.
Solution:   Add a configure check for clock_gettime(). (closes #12242)
 2023-04-13 19:15:54 +01:00
Bram Moolenaar
5b9f57262f patch 9.0.1328: error when using "none" for GUI color is confusing 
Problem:    Error when using "none" for GUI color is confusing.
Solution:   Mention that the name should perhaps be "NONE". (closes #1400)
 2023-02-19 20:49:38 +00:00
Yegappan Lakshmanan
7f8b2559a3 patch 9.0.1158: code is indented more than necessary 
Problem:    Code is indented more than necessary.
Solution:   Use an early return where it makes sense. (Yegappan Lakshmanan,
            closes #11787)
 2023-01-08 13:44:24 +00:00
Bram Moolenaar
35fc61cb5b patch 9.0.0917: the WinScrolled autocommand event is not enough 
Problem:    The WinScrolled autocommand event is not enough.
Solution:   Add WinResized and provide information about what changed.
            (closes #11576)
 2022-11-22 12:40:50 +00:00
Christopher Plewright
44c2209352 patch 9.0.0886: horizontal mouse scroll only works in the GUI 
Problem:    Horizontal mouse scroll only works in the GUI.
Solution:   Make horizontal mouse scroll also work in a terminal.
            (Christopher Plewright, closes #11448)
 2022-11-15 17:43:36 +00:00
K.Takata
161b6ac04f patch 9.0.0880: preprocessor indenting is off 
Problem:    Preprocessor indenting is off.
Solution:   Adjust preprocessor indentation. (Ken Takata, closes #11546)
 2022-11-14 15:31:07 +00:00
Luuk van Baal
7b224fdf4a patch 9.0.0844: handling 'statusline' errors is spread out 
Problem:    Handling 'statusline' errors is spread out.
Solution:   Pass the option name to the lower levels so the option can be
            reset there when an error is encountered. (Luuk van Baal,
            closes #11467)
 2022-11-07 12:16:51 +00:00
Bram Moolenaar
a25f718431 patch 9.0.0838: compiler warnings for unused variables 
Problem:    Compiler warnings for unused variables.
Solution:   Addjust #ifdef and remove unused variables. (John Marriott)
 2022-11-06 11:27:46 +00:00
Martin Tournoij
7904fa420e patch 9.0.0657: too many #ifdefs 
Problem:    Too many #ifdefs.
Solution:   Graduate the +cmdwin feature.  Now the tiny and small builds are
            equal, drop the small build.  (Martin Tournoij, closes #11268)
 2022-10-04 16:28:45 +01:00
matveyt
2834ebdee4 patch 9.0.0396: :findrepl does not escape '&' and '~' properly 
Problem:    :findrepl does not escape '&' and '~' properly.
Solution:   Escape depending on the value of 'magic'. (closes #11067)
 2022-09-06 17:00:15 +01:00
Bram Moolenaar
c8ac3a072f patch 9.0.0375: the footer feature is unused 
Problem:    The footer feature is unused.
Solution:   Remove FEAT_FOOTER and code.
 2022-09-04 12:29:28 +01:00
Bram Moolenaar
a4d158b3c8 patch 9.0.0206: redraw flags are not named specifically 
Problem:    Redraw flags are not named specifically.
Solution:   Prefix "UPD_" to the flags, for UPDate_screen().
 2022-08-14 14:17:45 +01:00
Bram Moolenaar
b26592a84c patch 9.0.0050: split else-of is confusing 
Problem:    Split else-of is confusing.
Solution:   Join the lines. (closes #10696)
 2022-07-12 17:34:31 +01:00
Bram Moolenaar
84f5463630 patch 9.0.0007: no support for double, dotted and dashed underlines 
Problem:    No support for double, dotted and dashed underlines.
Solution:   Add the termcap entries and highlight modes. (closes #9553)
 2022-06-29 18:39:11 +01:00
Yegappan Lakshmanan
ee47eaceaa patch 9.0.0003: functions are global while they could be local 
Problem:    Functions are global while they could be local.
Solution:   Add "static".  Add a few tests. (Yegappan Lakshmanan,
            closes #10612)
 2022-06-29 12:55:36 +01:00
Bram Moolenaar
c72e31dfcc patch 8.2.5113: timer becomes invalid after fork/exec, :gui gives errors 
Problem:    Timer becomes invalid after fork/exec, :gui gives errors. (Gabriel
            Dupras)
Solution:   Delete the timer befor forking. (closes #10584)
 2022-06-16 18:47:20 +01:00
Bram Moolenaar
2d12c25a1b patch 8.2.5084: when the GUI shows a dialog tests get stuck 
Problem:    When the GUI shows a dialog tests get stuck.
Solution:   Add the --gui-dialog-file argument.
 2022-06-13 21:42:45 +01:00
Bram Moolenaar
6ed545e797 patch 8.2.4928: various white space and cosmetic mistakes 
Problem:    Various white space and cosmetic mistakes.
Solution:   Change spaces to tabs, improve comments.
 2022-05-09 20:09:23 +01:00
Bram Moolenaar
249591057b patch 8.2.4911: the mode #defines are not clearly named 
Problem:    The mode #defines are not clearly named.
Solution:   Prepend MODE_.  Renumber them to put the mapped modes first.
 2022-05-07 20:01:16 +01:00
Bram Moolenaar
31e5c60a68 patch 8.2.4753: error from setting an option is silently ignored 
Problem:    Error from setting an option is silently ignored.
Solution:   Handle option value errors better.  Fix uses of N_().
 2022-04-15 13:53:33 +01:00
zeertzjq
d58862d18f patch 8.2.4739: accessing freed memory after WinScrolled autocmd event 
Problem:    Accessing freed memory after WinScrolled autocmd event.
Solution:   Check the window pointer is still valid. (closes #10156)
            Remove the argument from may_trigger_winscrolled().
 2022-04-12 11:32:48 +01:00
LemonBoy
0937182d49 patch 8.2.4713: plugins cannot track text scrolling 
Problem:    Plugins cannot track text scrolling.
Solution:   Add the WinScrolled event. (closes #10102)
 2022-04-08 15:18:45 +01:00
Bram Moolenaar
0b962e5685 patch 8.2.4677: the Athena GUI support is outdated 
Problem:    The Athena GUI support is outdated.
Solution:   Remove the Athena GUI code.
 2022-04-03 18:02:37 +01:00
Ernie Rael
c4cb544cd5 patch 8.2.4674: cannot force getting MouseMove events 
Problem:    Cannot force getting MouseMove events.
Solution:   Add the 'mousemoveevent' option with implementaiton for the GUI.
            (Ernie Rael, closes #10044)
 2022-04-03 15:47:28 +01:00
Bram Moolenaar
f8e43f6107 patch 8.2.4619: mapping is cancelled when mouse moves and popup is visible 
Problem:    Mapping is cancelled when mouse moves and popup is visible.
Solution:   Only generate mouse moved events when a popup may use them.
            (closes #10004)
 2022-03-24 15:15:15 +00:00
K.Takata
6e1d31e9e3 patch 8.2.4288: preprocessor indents are inconsistent 
Problem:    Preprocessor indents are inconsistent.
Solution:   Fix preprocessor indents. (Ken Takata, closes #9691)
 2022-02-03 13:05:32 +00:00
Bram Moolenaar
424bcae1fb patch 8.2.4273: the EBCDIC support is outdated 
Problem:    The EBCDIC support is outdated.
Solution:   Remove the EBCDIC support.
 2022-01-31 14:59:41 +00:00
K.Takata
94373c48e7 patch 8.2.4230: MS-Windows: set_guifontwide() is included but won't work 
Problem:    MS-Windows: set_guifontwide() is included but won't work.
Solution:   Include set_guifontwide() only for X11. (Ken Takata, closes #9640)
 2022-01-27 15:04:22 +00:00
K.Takata
c81e9bf4f0 patch 8.2.4109: MS-Windows: high dpi support is outdated 
Problem:    MS-Windows: high dpi support is outdated.
Solution:   Improve High DPI support by using PerMonitorV2. (closes #9525,
            closes #3102)
 2022-01-16 14:15:49 +00:00
Bram Moolenaar
9d00e4a814 patch 8.2.4010: error messages are spread out 
Problem:    Error messages are spread out.
Solution:   Move more error messages to errors.h.
 2022-01-05 17:49:15 +00:00
Bram Moolenaar
a6f7929e62 patch 8.2.4005: error messages are spread out 
Problem:    Error messages are spread out.
Solution:   Move more error messages to errors.h.
 2022-01-04 21:30:47 +00:00
Bram Moolenaar
1d423ef75f patch 8.2.3987: error messages are spread out 
Problem:    Error messages are spread out.
Solution:   Move more error messages to errors.h.
 2022-01-02 21:26:16 +00:00
Bram Moolenaar
cbadefe25a patch 8.2.3975: error messages are spread out 
Problem:    Error messages are spread out.
Solution:   Move more error messages to errors.h.
 2022-01-01 19:33:50 +00:00
Bram Moolenaar
6d0570117a patch 8.2.3959: error messages are spread out 
Problem:    Error messages are spread out.
Solution:   Move more errors to errors.h.
 2021-12-31 18:49:43 +00:00
Dominique Pelle
af4a61a85d patch 8.2.3914: various spelling mistakes in comments 
Problem:    Various spelling mistakes in comments.
Solution:   Fix the mistakes. (Dominique Pellé, closes #9416)
 2021-12-27 17:21:41 +00:00
Bram Moolenaar
651fca85c7 patch 8.2.3699: the +title feature adds a lot of #ifdef but little code 
Problem:    The +title feature adds a lot of #ifdef but little code.
Solution:   Graduate the +title feature.
 2021-11-29 20:39:38 +00:00
Bram Moolenaar
f566666e88 patch 8.2.3691: build failure with small features 
Problem:    Build failure with small features.
Solution:   Add #ifdef. (Dominique Pellé)
 2021-11-28 21:33:36 +00:00
Christian Brabandt
2e0f3ecb70 patch 8.2.3688: the window title is not updated when dragging the scrollbar 
Problem:    The window title is not updated when dragging the scrollbar.
Solution:   Call maketitle(). (Christian Brabandt, closes #9238, closes #5383)
 2021-11-28 18:41:05 +00:00
Bram Moolenaar
4671e88d7d patch 8.2.3648: "verbose pwd" is incorrect after dropping files on Vim 
Problem:    "verbose pwd" is incorrect after dropping files on Vim.
Solution:   Set the chdir reason to "drop".
 2021-11-22 17:21:48 +00:00
Dusan Popovic
ce59b9f292 patch 8.2.3647: GTK: when using ligatures the cursor is drawn wrong 
Problem:    GTK: when using ligatures the cursor is drawn wrong.
Solution:   Clear more characters when ligatures are used. (Dusan Popovic,
            closes #9190)
 2021-11-22 17:18:44 +00:00
Drew Vogel
e30d10253f patch 8.2.3562: cannot add color names 
Problem:    Cannot add color names.
Solution:   Add the v:colornames dictionary. (Drew Vogel, closes #8761)
 2021-10-24 20:35:07 +01:00
Dusan Popovic
4eeedc09fe patch 8.2.3524: GUI: ligatures are not used 
Problem:    GUI: ligatures are not used.
Solution:   Add the 'guiligatures' option. (Dusan Popovic, closes #8933)
 2021-10-16 20:52:05 +01:00
Bram Moolenaar
e29a27f6f8 patch 8.2.3190: error messages are spread out 
Problem:    Error messages are spread out.
Solution:   Move error messages to errors.h and give them a clear name.
 2021-07-20 21:07:36 +02:00
Yegappan Lakshmanan
18d46587b9 patch 8.2.3040: GUI: dropping files not tested 
Problem:    GUI: dropping files not tested.
Solution:   Add test_gui_drop_files() and tests. (Yegappan Lakshmanan,
            closes #8434)
 2021-06-23 20:46:52 +02:00
Bram Moolenaar
445f11d5bc patch 8.2.2963: GUI: mouse move may start Visual mode with a popup visible 
Problem:    GUI: mouse move may start Visual mode with a popup visible.
Solution:   Add special code for mouse move. (closes #8318)
 2021-06-08 20:13:31 +02:00
Bram Moolenaar
3552e74289 patch 8.2.2898: QuitPre and ExitPre not triggered when GUI window is closed 
Problem:    QuitPre and ExitPre not triggered when GUI window is closed.
Solution:   Call before_quit_autocmds(). (closes #8242)
 2021-05-29 12:21:58 +02:00