aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-07-26 11:04:33 -04:00
Code
18,677 Commits 1 Branch 18,323 Tags
Commit Graph

63 Commits

Author SHA1 Message Date
zeertzjq
f5a94d5165
patch 9.0.2032: cannot get mouse click pos for tab or virt text 
Problem:  Cannot accurately get mouse clicking position when clicking on
          a TAB or with virtual text.
Solution: Add a "coladd" field to getmousepos() result.

closes: #13335

Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
 2023-10-15 10:03:30 +02:00
zeertzjq
b583eda703
patch 9.0.2022: getmousepos() returns wrong index for TAB char 
Problem:  When clicking in the middle of a TAB, getmousepos() returns
          the column of the next char instead of the TAB.
Solution: Break out of the loop when the vcol to find is inside current
          char. Fix invalid memory access when calling virtcol2col() on
          an empty line.

closes: #13321

Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
 2023-10-14 11:32:28 +02:00
zeertzjq
db54e989b5
patch 9.0.1923: curswant wrong on click with 've' and 'wrap' set 
Problem:  curswant wrong on click with 've' and 'wrap' set
Solution: Add w_leftcol to mouse click column.

closes: #13142

Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
 2023-09-21 16:33:09 +02:00
zeertzjq
03cd697d63
patch 9.0.1919: Wrong curswant when clicking on empty line or with vsplits 
Problem:  Wrong curswant when clicking on empty line or with vsplits.
Solution: Don't check for ScreenCols[] before the start of the window
          and handle empty line properly.

closes: #13132

Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
 2023-09-20 20:08:40 +02:00
Christian Brabandt
ee17b6f70d
patch 9.0.1886: Various Typos 
Problem:  Various Typos
Solution: Fix Typos

This is a collection of typo related commits.

closes: #12753
closes: #13016

Co-authored-by: Adri Verhoef <a3@a3.xs4all.nl>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
Co-authored-by: Viktor Szépe <viktor@szepe.net>
Co-authored-by: nuid64 <lvkuzvesov@proton.me>
Co-authored-by: Meng Xiangzhuo <aumo@foxmail.com>
Co-authored-by: Dominique Pellé <dominique.pelle@gmail.com>

Signed-off-by: Christian Brabandt <cb@256bit.org>
 2023-09-09 11:31:38 +02:00
zeertzjq
e500ae8e29
patch 9.0.1725: cursor pos wrong after concealed text with 'virtualedit' 
Problem:    Wrong cursor position when clicking after concealed text
            with 'virtualedit'.
Solution:   Store virtual columns in ScreenCols[] instead of text
            columns, and always use coladvance() when clicking.

This also fixes incorrect curswant when clicking on a TAB, so now
Test_normal_click_on_ctrl_char() asserts the same results as the ones
before patch 9.0.0048.

closes: #12808

Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
 2023-08-17 22:35:26 +02:00
Yegappan Lakshmanan
a23a11b5bf patch 9.0.1336: functions without arguments are not always declared properly 
Problem:    Functions without arguments are not always declared properly.
Solution:   Use "(void)" instead of "()". (Yegappan Lakshmanan, closes #12031)
 2023-02-21 14:27:41 +00:00
Christopher Plewright
36446bbb62 patch 9.0.0931: MS-Windows: mouse column limited to 223 
Problem:    MS-Windows: mouse column limited to 223.
Solution:   Use two bytes for each mouse coordinate.  Add the mouse position
            to scroll events. (Christopher Plewright, closes #11597)
 2022-11-23 22:28:08 +00:00
Bram Moolenaar
35fc61cb5b patch 9.0.0917: the WinScrolled autocommand event is not enough 
Problem:    The WinScrolled autocommand event is not enough.
Solution:   Add WinResized and provide information about what changed.
            (closes #11576)
 2022-11-22 12:40:50 +00:00
Yee Cheng Chin
e6392b1021 patch 9.0.0911: with 'smoothscroll' set mouse click position may be wrong 
Problem:    With 'smoothscroll' set mouse click position may be wrong.
Solution:   Adjust computations for w_skipcol. (Yee Cheng Chin, closes #11514)
 2022-11-19 14:31:08 +00:00
Christopher Plewright
ff95ce0930 patch 9.0.0906: mouse scroll code is not optimal 
Problem:    Mouse scroll code is not optimal.
Solution:   Properly organise Normal mode, Insert mode and common code.
            (Christopher Plewright, closes #11572)
 2022-11-19 10:47:49 +00:00
Christopher Plewright
696d0a8625 patch 9.0.0902: some mouse scroll code is not in a good place 
Problem:    Some mouse scroll code is not in a good place.
Solution:   Refactor the code. (Christopher Plewright, closes #11561)
 2022-11-18 17:53:34 +00:00
Bram Moolenaar
0c34d56264 patch 9.0.0901: setting w_leftcol and handling side effects is confusing 
Problem:    Setting w_leftcol and handling side effects is confusing.
Solution:   Use a function to set w_leftcol() and handle side effects.
 2022-11-18 14:07:20 +00:00
Christopher Plewright
44c2209352 patch 9.0.0886: horizontal mouse scroll only works in the GUI 
Problem:    Horizontal mouse scroll only works in the GUI.
Solution:   Make horizontal mouse scroll also work in a terminal.
            (Christopher Plewright, closes #11448)
 2022-11-15 17:43:36 +00:00
zeertzjq
8e0ccb6bc2 patch 9.0.0825: cannot drag an entry in the tabpage line 
Problem:    Cannot drag an entry in the tabpage line.
Solution:   Clear dragwin instead of got_click. (closes #11483,
            closes #11482)
 2022-11-01 18:35:27 +00:00
Bram Moolenaar
8ab9ca93ee patch 9.0.0822: crash when dragging the statusline with a mapping 
Problem:    Crash when dragging the statusline with a mapping.
Solution:   Check for valid window pointer. (issue #11427)
 2022-10-31 13:06:26 +00:00
Yee Cheng Chin
17822c507c patch 9.0.0739: mouse column not correctly used for popup_setpos 
Problem:    Mouse column not correctly used for popup_setpos.
Solution:   Adjust off-by-one error and handle Visual line selection properly.
            (Yee Cheng Chin, closes #11356)
 2022-10-13 13:17:40 +01:00
Martin Tournoij
7904fa420e patch 9.0.0657: too many #ifdefs 
Problem:    Too many #ifdefs.
Solution:   Graduate the +cmdwin feature.  Now the tiny and small builds are
            equal, drop the small build.  (Martin Tournoij, closes #11268)
 2022-10-04 16:28:45 +01:00
Bram Moolenaar
80525751c5 patch 9.0.0259: crash with mouse click when not initialized 
Problem:    Crash with mouse click when not initialized.
Solution:   Check TabPageIdxs[] is not NULL.
 2022-08-24 19:27:45 +01:00
Bram Moolenaar
a4d158b3c8 patch 9.0.0206: redraw flags are not named specifically 
Problem:    Redraw flags are not named specifically.
Solution:   Prefix "UPD_" to the flags, for UPDate_screen().
 2022-08-14 14:17:45 +01:00
Bram Moolenaar
8f49e690dc patch 9.0.0177: cursor position wrong with 'virtualedit' and mouse click 
Problem:    Cursor position wrong with 'virtualedit' and mouse click after end
            of the line. (Hermann Mayer)
Solution:   Do not use ScreenCols[] when 'virtualedit' is active.
            (closes #10868)
 2022-08-09 14:19:40 +01:00
Bram Moolenaar
d6212b80d6 patch 9.0.0136: after CTRL-Left-mouse click a mouse scroll also has CTRL 
Problem:    After CTRL-Left-mouse click a mouse scroll also has CTRL.
Solution:   Reset orig_mouse_code also for wheel events. (closes #10840)
 2022-08-03 15:48:33 +01:00
Bram Moolenaar
7f9969c559 patch 9.0.0067: cannot show virtual text 
Problem:    Cannot show virtual text.
Solution:   Initial changes for virtual text support, using text properties.
 2022-07-25 18:13:54 +01:00
Bram Moolenaar
b90818867c patch 9.0.0048: cursor in wrong column with mouse click after concealed text 
Problem:    Cursor in wrong column with mouse click after concealed text.
Solution:   Store the text column when drawing text.
 2022-07-09 04:56:24 +01:00
Bram Moolenaar
96ba25ac01 patch 9.0.0036: 'fillchars' cannot have window-local values 
Problem:    'fillchars' cannot have window-local values.
Solution:   Make 'fillchars' global-local. (closes #5206)
 2022-07-04 17:34:33 +01:00
Bram Moolenaar
93a1096fe4 patch 8.2.5107: some callers of rettv_list_alloc() check for not OK 
Problem:    Some callers of rettv_list_alloc() check for not OK. (Christ van
            Willegen)
Solution:   Use "==" instead of "!=" when checking the return value.
 2022-06-16 11:42:09 +01:00
Bram Moolenaar
8e145b8246 patch 8.2.4993: smart/C/lisp indenting is optional 
Problem:    smart/C/lisp indenting is optional, which makes the code more
            complex, while it only reduces the executable size a bit.
Solution:   Graduate FEAT_CINDENT, FEAT_SMARTINDENT and FEAT_LISP.
 2022-05-21 20:17:31 +01:00
zeertzjq
6dab00aa54 patch 8.2.4984: dragging statusline fails for window with winbar 
Problem:    Dragging statusline fails for window with winbar.
Solution:   Fix off-by-one error. (closes #10448)
 2022-05-20 13:45:59 +01:00
Bram Moolenaar
6ed545e797 patch 8.2.4928: various white space and cosmetic mistakes 
Problem:    Various white space and cosmetic mistakes.
Solution:   Change spaces to tabs, improve comments.
 2022-05-09 20:09:23 +01:00
Bram Moolenaar
249591057b patch 8.2.4911: the mode #defines are not clearly named 
Problem:    The mode #defines are not clearly named.
Solution:   Prepend MODE_.  Renumber them to put the mapped modes first.
 2022-05-07 20:01:16 +01:00
LemonBoy
c27747e6dd patch 8.2.4902: mouse wheel scrolling is inconsistent 
Problem:    Mouse wheel scrolling is inconsistent.
Solution:   Use the MS-Winows system setting. (closes #10368)
 2022-05-07 12:25:40 +01:00
LemonBoy
66e13aedc7 patch 8.2.4803: WinScrolled not always triggered when scrolling with mouse 
Problem:    WinScrolled not always triggered when scrolling with the mouse.
Solution:   Add calls to may_trigger_winscrolled(). (closes #10246)
 2022-04-21 22:52:11 +01:00
zeertzjq
0f68e6c07a patch 8.2.4692: no test for what 8.2.4691 fixes 
Problem:    No test for what 8.2.4691 fixes.
Solution:   Add a test.  Use a more generic sotlution. (closes #10090)
 2022-04-05 13:17:01 +01:00
Bram Moolenaar
0b962e5685 patch 8.2.4677: the Athena GUI support is outdated 
Problem:    The Athena GUI support is outdated.
Solution:   Remove the Athena GUI code.
 2022-04-03 18:02:37 +01:00
Sean Dewar
10792feebd patch 8.2.4568: getmousepos() does not compute the column below the last line 
Problem:    getmousepos() does not compute the column below the last line.
Solution:   Also compute the column when the mouse is below the last line.
            (Sean Dewar, closes #9946)
 2022-03-15 09:46:54 +00:00
Bram Moolenaar
424da7aa48 patch 8.2.4561: build failure with some combination of features 
Problem:    Build failure with some combination of features. (John Marriott)
Solution:   Adjust #ifdef.
 2022-03-13 19:08:48 +00:00
Bram Moolenaar
533870a985 patch 8.2.4559: getmousepos() returns the screen column 
Problem:    getmousepos() returns the screen column. (Ernie Rael)
Solution:   Return the text column, as documented.
 2022-03-13 15:52:44 +00:00
Bram Moolenaar
986b0fd0c5 patch 8.2.4555: getmousepos() returns the wrong column 
Problem:    getmousepos() returns the wrong column. (Ernie Rael)
Solution:   Limit to the text size, not the number of bytes.
 2022-03-13 12:06:07 +00:00
Bram Moolenaar
0b74d00693 patch 8.2.3697: cannot drag a popup without a border 
Problem:    Cannot drag a popup without a border.
Solution:   Add the "dragall" option. (closes #9218)
 2021-11-29 17:38:02 +00:00
Bram Moolenaar
bfc5786a61 patch 8.2.3681: cannot drag popup window after click on a status line 
Problem:    Cannot drag popup window after click on a status line. (Sergey
            Vlasov)
Solution:   Reset on_status_line. (closes #9221)
 2021-11-26 15:57:40 +00:00
Bram Moolenaar
4f3c57f798 patch 8.2.2932: select mode test fails 
Problem:    Select mode test fails.
Solution:   Do not always reset the held mouse button.
 2021-06-03 22:11:08 +02:00
Bram Moolenaar
85eee5b969 patch 8.2.2930: when a popup is visible a mouse move my restart Visual mode 
Problem:    When a popup is visible a mouse move my restart Visual mode.
Solution:   Reset held_button when ending Visual mode. (closes #8318)
 2021-06-03 20:34:57 +02:00
Bram Moolenaar
3aca5a6fbc patch 8.2.2524: cannot change the characters displayed in the foldcolumn 
Problem:    Cannot change the characters displayed in the foldcolumn.
Solution:   Add fields to 'fillchars'. (Yegappan Lakshmanan, Matthieu Coudron,
            closes #7860)
 2021-02-17 13:14:07 +01:00
Bram Moolenaar
dbfa795d8b patch 8.2.1942: insufficient test coverage for the Netbeans interface 
Problem:    Insufficient test coverage for the Netbeans interface.
Solution:   Add more tests. Fix an uncovered bug. (Yegappan Lakshmanan,
            closes #7240)
 2020-11-02 20:04:22 +01:00
Bram Moolenaar
c3516f7e45 patch 8.2.1637: Vim9: :put ={expr} does not work inside :def function 
Problem:    Vim9: :put ={expr} does not work inside :def function.
Solution:   Add ISN_PUT. (closes #6397)
 2020-09-08 22:45:35 +02:00
Bram Moolenaar
097148e849 patch 8.2.1422: the Mac GUI implementation is outdated 
Problem:    The Mac GUI implementation is outdated and probably doesn't even
            work.
Solution:   Remove the Mac GUI code.  The MacVim project provides the
            supported Vim GUI version.
 2020-08-11 21:58:20 +02:00
Bram Moolenaar
452143c6bf patch 8.2.1220: memory access error when dragging a popup window 
Problem:    memory access error when dragging a popup window over a buffer
            with folding.
Solution:   Avoid going over the end of the cache. (closes #6438)
 2020-07-15 17:38:21 +02:00
Bram Moolenaar
13c046316b patch 8.2.1186: with SGR mouse codes balloon doesn't show up after click 
Problem:    With SGR mouse codes balloon doesn't show up after click.
Solution:   Add the MOUSE_RELEASE bits to mouse_code.
 2020-07-12 13:47:42 +02:00
Bram Moolenaar
d58d4f90ae patch 8.2.1108: mouse left-right scroll is not supported in terminal window 
Problem:    Mouse left-right scroll is not supported in terminal window.
Solution:   Implement mouse codes 6 and 7. (Trygve Aaberge, closes #6363)
 2020-07-01 15:49:29 +02:00
Bram Moolenaar
b3f740695a patch 8.2.0320: no Haiku support 
Problem:    No Haiku support.
Solution:   Add support for Haiku. (Emir Sari, closes #5605)
 2020-02-26 16:16:53 +01:00