Bram Moolenaar
1d423ef75f
patch 8.2.3987: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
2022-01-02 21:26:16 +00:00
Bram Moolenaar
ac78dd4a35
patch 8.2.3985: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
2022-01-02 19:25:26 +00:00
Bram Moolenaar
4c13e5e676
patch 8.2.3949: using freed memory with /\%V
...
Problem: Using freed memory with /\%V.
Solution: Get the line again after getvvcol().
2021-12-30 14:49:43 +00:00
Bram Moolenaar
851f86b951
patch 8.2.3796: the funcexe_T struct members are not named consistently
...
Problem: The funcexe_T struct members are not named consistently.
Solution: Prefix "fe_" to all the members.
2021-12-13 14:26:44 +00:00
Bram Moolenaar
12f3c1b77f
patch 8.2.3749: error messages are everywhere
...
Problem: Error messages are everywhere.
Solution: Move more error messages to errors.h and adjust the names.
2021-12-05 21:46:34 +00:00
Bram Moolenaar
651fca85c7
patch 8.2.3699: the +title feature adds a lot of #ifdef but little code
...
Problem: The +title feature adds a lot of #ifdef but little code.
Solution: Graduate the +title feature.
2021-11-29 20:39:38 +00:00
Bram Moolenaar
64066b9acd
patch 8.2.3612: using freed memory with regexp using a mark
...
Problem: Using freed memory with regexp using a mark.
Solution: Get the line again after getting the mark position.
2021-11-17 18:22:56 +00:00
Bram Moolenaar
d8e44476d8
patch 8.2.3197: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move a few more error messages to errors.h.
2021-07-21 22:20:33 +02:00
Bram Moolenaar
e29a27f6f8
patch 8.2.3190: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move error messages to errors.h and give them a clear name.
2021-07-20 21:07:36 +02:00
K.Takata
eeec254878
patch 8.2.2922: computing array length is done in various ways
...
Problem: Computing array length is done in various ways.
Solution: Use ARRAY_LENGTH everywhere. (Ken Takata, closes #8305 )
2021-06-02 13:28:16 +02:00
Bram Moolenaar
e71c0ebe2c
patch 8.2.2911: pattern "\%V" does not match all of block selection
...
Problem: Pattern "\%V" does not match all of block selection. (Rick Howe)
Solution: Use the value of vi_curswant. (closes #8285 )
2021-05-30 16:43:11 +02:00
Bram Moolenaar
4c13721482
patch 8.2.2784: Vim9: cannot use \=expr in :substitute
...
Problem: Vim9: cannot use \=expr in :substitute.
Solution: Compile the expression into instructions and execute them when
invoked.
2021-04-19 16:48:48 +02:00
Bram Moolenaar
d93a7fc1a9
patch 8.2.2295: incsearch does not detect empty pattern properly
...
Problem: Incsearch does not detect empty pattern properly.
Solution: Return magic state when skipping over a pattern. (Christian
Brabandt, closes #7612 , closes #6420 )
2021-01-04 12:42:13 +01:00
Bram Moolenaar
66c50c5653
patch 8.2.2278: falling back to old regexp engine can some patterns
...
Problem: Falling back to old regexp engine can some patterns.
Solution: Do not fall back once [[:lower:]] or [[:upper:]] is used.
(Christian Brabandt, closes #7572 )
2021-01-02 17:43:49 +01:00
Bram Moolenaar
e83cca2911
patch 8.2.1633: some error messages are internal but do not use iemsg()
...
Problem: Some error messages are internal but do not use iemsg().
Solution: Use iemsg(). (Dominique Pellé, closes #6894 )
2020-09-07 18:53:21 +02:00
Bram Moolenaar
30d6413782
patch 8.2.1625: compiler warning for use of fptr_T
...
Problem: Compiler warning for use of fptr_T.
Solution: Make the type less strict.
2020-09-06 17:09:12 +02:00
Bram Moolenaar
8a0dcf4330
patch 8.2.1621: crash when using submatch(0, 1) in substitute()
...
Problem: Crash when using submatch(0, 1) in substitute().
Solution: Increment reference count. (closes #6887 )
2020-09-06 15:14:45 +02:00
Bram Moolenaar
b171fb1790
patch 8.2.1049: Vim9: leaking memory when using continuation line
...
Problem: Vim9: leaking memory when using continuation line.
Solution: Keep a pointer to the continuation line in evalarg_T. Centralize
checking for a next command.
2020-06-24 20:34:03 +02:00
Bram Moolenaar
71ccd03ee8
patch 8.2.0967: unnecessary type casts for vim_strnsave()
...
Problem: Unnecessary type casts for vim_strnsave().
Solution: Remove the type casts.
2020-06-12 22:59:11 +02:00
Bram Moolenaar
2c5ed4e330
patch 8.2.0612: Vim9: no check for space before #comment
...
Problem: Vim9: no check for space before #comment.
Solution: Add space checks.
2020-04-20 19:42:10 +02:00
Bram Moolenaar
a80faa8930
patch 8.2.0559: clearing a struct is verbose
...
Problem: Clearing a struct is verbose.
Solution: Define and use CLEAR_FIELD() and CLEAR_POINTER().
2020-04-12 19:37:17 +02:00
Bram Moolenaar
e8c4abbbd7
patch 8.2.0502: Vim9: some code is not tested
...
Problem: Vim9: some code is not tested.
Solution: Add more tests. Fix uncovered problems.
2020-04-02 21:13:25 +02:00
Bram Moolenaar
f4140488c7
patch 8.2.0260: several lines of code are duplicated
...
Problem: Several lines of code are duplicated.
Solution: Move duplicated code to a function. (Yegappan Lakshmanan,
closes #5330 )
2020-02-15 23:06:45 +01:00
Bram Moolenaar
4f5776c17c
patch 8.2.0250: test_clear_search_pat() is unused
...
Problem: test_clear_search_pat() is unused.
Solution: Remove the function. (Yegappan Lakshmanan, closes #5624 )
2020-02-12 22:15:19 +01:00
Bram Moolenaar
07ada5ff2f
patch 8.2.0212: missing search/substitute pattern hardly tested
...
Problem: Missing search/substitute pattern hardly tested.
Solution: Add test_clear_search_pat() and tests. (Yegappan Lakshmanan,
closes #5579 )
2020-02-05 20:38:22 +01:00
Bram Moolenaar
53989554a4
patch 8.2.0035: saving and restoring called_emsg is clumsy
...
Problem: Saving and restoring called_emsg is clumsy.
Solution: Count the number of error messages.
2019-12-23 22:59:18 +01:00
Bram Moolenaar
63d9e730f7
patch 8.1.2394: using old C style comments
...
Problem: Using old C style comments.
Solution: Use // comments where appropriate.
2019-12-05 21:10:38 +01:00
Bram Moolenaar
4c054e9fb2
patch 8.1.2282: crash when passing many arguments through a partial
...
Problem: Crash when passing many arguments through a partial. (Andy
Massimino)
Solution: Check the number of arguments. (closes #5186 )
2019-11-10 00:13:50 +01:00
Bram Moolenaar
b0745b221d
patch 8.1.2280: crash when passing partial to substitute()
...
Problem: Crash when passing partial to substitute().
Solution: Take extra arguments into account. (closes #5186 )
2019-11-09 22:28:11 +01:00
Bram Moolenaar
6d7d7cf750
patch 8.1.2005: the regexp.c file is too big
...
Problem: The regexp.c file is too big.
Solution: Move the backtracking engine to a separate file. (Yegappan
Lakshmanan, closes #4905 )
2019-09-07 23:16:33 +02:00
Bram Moolenaar
b005cd80cf
patch 8.1.1979: code for handling file names is spread out
...
Problem: Code for handling file names is spread out.
Solution: Move code to new filepath.c file. Graduate FEAT_MODIFY_FNAME.
2019-09-04 15:54:55 +02:00
Bram Moolenaar
5843f5f37b
patch 8.1.1891: functions used in one file are global
...
Problem: Functions used in one file are global.
Solution: Add "static". (Yegappan Lakshmanan, closes #4840 )
2019-08-20 20:13:45 +02:00
Bram Moolenaar
47ed553fd5
patch 8.1.1827: allocating more memory than needed for extended structs
...
Problem: Allocating more memory than needed for extended structs.
Solution: Use offsetof() instead of sizeof(). (Dominique Pelle,
closes #4786 )
2019-08-08 20:49:14 +02:00
Bram Moolenaar
c6538bcc1c
patch 8.1.1800: function call functions have too many arguments
...
Problem: Function call functions have too many arguments.
Solution: Pass values in a funcexe_T struct.
2019-08-03 18:17:11 +02:00
Bram Moolenaar
2a5b52758b
patch 8.1.1720: crash with very long %[] pattern
...
Problem: Crash with very long %[] pattern. (Reza Mirzazade farkhani)
Solution: Check for reg_toolong. (closes #4703 )
2019-07-20 18:56:06 +02:00
Bram Moolenaar
c799fe206e
patch 8.1.1414: alloc() returning "char_u *" causes a lot of type casts
...
Problem: Alloc() returning "char_u *" causes a lot of type casts.
Solution: Have it return "void *". (Mike Williams) Define ALLOC_ONE() to
check the simple allocations.
2019-05-28 23:08:19 +02:00
Bram Moolenaar
18a4ba29ae
patch 8.1.1386: unessesary type casts for lalloc()
...
Problem: Unessesary type casts for lalloc().
Solution: Remove type casts. Change lalloc(size, TRUE) to alloc(size).
2019-05-24 19:39:03 +02:00
Bram Moolenaar
964b3746b9
patch 8.1.1384: using "int" for alloc() often results in compiler warnings
...
Problem: Using "int" for alloc() often results in compiler warnings.
Solution: Use "size_t" and remove type casts. Remove alloc_check(), Vim
only works with 32 bit ints anyway.
2019-05-24 18:54:09 +02:00
Bram Moolenaar
6ed8819822
patch 8.1.1319: computing function length name in many places
...
Problem: Computing function length name in many places.
Solution: compute name length in call_func().
2019-05-11 18:37:44 +02:00
Bram Moolenaar
c2d09c9f2c
patch 8.1.1202: always get regexp debugging logs when building with -DDEBUG
...
Problem: Always get regexp debugging logs when building with -DDEBUG.
Solution: By default do not create regexp debugging logs. (Ken Takata)
2019-04-25 20:07:51 +02:00
Bram Moolenaar
2c519cf3bf
patch 8.1.1032: warnings from clang static analyzer
...
Problem: Warnings from clang static analyzer. (Yegappan Lakshmanan)
Solution: Fix relevant warnings.
2019-03-21 21:45:34 +01:00
Bram Moolenaar
64c8ed366d
patch 8.1.1025: checking NULL pointer after addition
...
Problem: Checking NULL pointer after addition. (Coverity)
Solution: First check for NULL, then add the column.
2019-03-20 21:18:34 +01:00
Bram Moolenaar
bdace838c6
patch 8.1.0989: various small code ugliness
...
Problem: Various small code ugliness.
Solution: Remove pointless NULL checks. Fix function calls. Fix typos.
(Dominique Pelle, closes #4060 )
2019-03-02 10:13:42 +01:00
Bram Moolenaar
ab350f89f9
patch 8.1.0985: crash with large number in regexp
...
Problem: Crash with large number in regexp. (Kuang-che Wu)
Solution: Check for long becoming negative int. (closes #)
2019-02-28 06:25:00 +01:00
Bram Moolenaar
cd62512c55
patch 8.1.0973: pattern with syntax error gives threee error messages
...
Problem: Pattern with syntax error gives threee error messages. (Kuang-che
Wu)
Solution: Remove outdated internal error. Don't fall back to other engine
after an error.
2019-02-22 17:29:43 +01:00
Bram Moolenaar
f1b57ab2ab
patch 8.1.0937: invalid memory access in search pattern
...
Problem: Invalid memory access in search pattern. (Kuang-che Wu)
Solution: Check for incomplete collation element. (Dominique Pelle,
closes #3985 )
2019-02-17 13:53:34 +01:00
Bram Moolenaar
8bfd9469ce
patch 8.1.0935: old regexp engine may use invalid buffer
...
Problem: Old regexp engine may use invalid buffer for 'iskeyword' or
uninitialized buffer pointer. (Kuang-che Wu)
Solution: Set rex.reg_buf when compiling the pattern. (closes #3972 )
2019-02-16 18:07:57 +01:00
Bram Moolenaar
985079c514
patch 8.1.0934: invalid memory access in search pattern
...
Problem: Invalid memory access in search pattern. (Kuang-che Wu)
Solution: Check for incomplete equivalence class. (closes #3970 )
2019-02-16 17:07:47 +01:00
Bram Moolenaar
beb7574d6b
patch 8.1.0903: struct uses more bytes than needed
...
Problem: Struct uses more bytes than needed.
Solution: Reorder members of regitem_S. (Dominique Pelle, closes #3936 )
2019-02-12 22:33:00 +01:00
Bram Moolenaar
221cd9f4dd
patch 8.1.0862: no verbose version of character classes
...
Problem: No verbose version of character classes.
Solution: Add [:ident:], [:keyword:] and [:fname:]. (Ozaki Kiichi,
closes #1373 )
2019-01-31 15:34:40 +01:00