zeertzjq
961b2e54bd
patch 9.0.1460: insufficient testing for getcmdcompltype()
...
Problem: Insufficient testing for getcmdcompltype().
Solution: Add a few more test cases. (closes #12268 )
2023-04-17 15:53:24 +01:00
zeertzjq
ac6cd31afc
patch 9.0.1444: crash when passing NULL to setcmdline()
...
Problem: Crash when passing NULL to setcmdline(). (Andreas Louv)
Solution: Use tv_get_string() instead of using v_string directly.
(closes #12231 , closes #12227 )
2023-04-12 16:21:14 +01:00
Bram Moolenaar
5fb78c3fa5
patch 9.0.1380: CTRL-X on 2**64 subtracts two
...
Problem: CTRL-X on 2**64 subtracts two. (James McCoy)
Solution: Correct computation for large number. (closes #12103 )
2023-03-04 20:47:39 +00:00
Yegappan Lakshmanan
af93691b53
patch 9.0.1330: handling new value of an option has a long "else if" chain
...
Problem: Handling new value of an option has a long "else if" chain.
Solution: Use a function pointer. (Yegappan Lakshmanan, closes #12015 )
2023-02-20 12:16:39 +00:00
zeertzjq
412e0e4ed9
patch 9.0.1299: change for triggering incsearch not sufficiently tested
...
Problem: Change for triggering incsearch not sufficiently tested.
Solution: Add a test case. Simplify the code. (closes #11971 )
2023-02-11 10:34:07 +00:00
K.Takata
c4b7dec382
patch 9.0.1298: inserting register on the cmdline does not trigger incsearch
...
Problem: Inserting a register on the command line does not trigger
incsearch or update hlsearch.
Solution: Have cmdline_insert_reg() return CMDLINE_CHANGED when appropriate
and handle it correctly. (Ken Takata, closes #11960 )
2023-02-10 21:38:44 +00:00
zeertzjq
af9e28a5b8
patch 9.0.1290: CTRL-N and -P on cmdline don't trigger CmdlineChanged
...
Problem: CTRL-N and -P on cmdline don't trigger CmdlineChanged.
Solution: Jump to cmdline_changed instead of cmdline_not_changed.
(closes #11956 )
2023-02-06 20:58:09 +00:00
Yegappan Lakshmanan
1cfb14aa97
patch 9.0.1166: code is indented more than necessary
...
Problem: Code is indented more than necessary.
Solution: Use an early return where it makes sense. (Yegappan Lakshmanan,
closes #11792 )
2023-01-09 19:04:23 +00:00
Yegappan Lakshmanan
dc4daa3a39
patch 9.0.1132: code is indented more than needed
...
Problem: Code is indented more than needed.
Solution: Use an early return to reduce indentation. (Yegappan Lakshmanan,
closes #11769 )
2023-01-02 16:54:53 +00:00
Yegappan Lakshmanan
ed0c1d5d4b
patch 9.0.1115: code is indented more than needed
...
Problem: Code is indented more than needed.
Solution: Use an early return to reduce indenting. (Yegappan Lakshmanan,
closes #11758 )
2022-12-30 18:07:46 +00:00
Bram Moolenaar
148bcd3610
patch 9.0.1040: test for <Cmd> mapping with CmdlineChanged fails
...
Problem: Test for <Cmd> mapping with CmdlineChanged fails.
Solution: Put back the check for the cmdline length not changing.
2022-12-09 12:41:32 +00:00
Bram Moolenaar
bb393d8259
patch 9.0.1039: using a <Cmd> mapping CmdlineChanged may be triggered twice
...
Problem: Using a <Cmd> mapping CmdlineChanged may be triggered twice.
Solution: Count the number of times CmdlineChanged is triggered and avoid
doing it twice. (closes #116820
2022-12-09 12:21:50 +00:00
zeertzjq
ffa4e9b43a
patch 9.0.1038: function name does not match what it is used for
...
Problem: Function name does not match what it is used for.
Solution: Include the modifier in the name. (closes #11679 )
2022-12-09 11:36:36 +00:00
Bram Moolenaar
733a69b29f
patch 9.0.0980: the keyboard state response may end up in a shell command
...
Problem: The keyboard state response may end up in a shell command.
Solution: Only request the keyboard protocol state when the typeahead is
empty, no more commands are following and not exiting. Add the
t_RK termcap entry for this.
2022-12-01 12:03:47 +00:00
Bram Moolenaar
f32fb93e43
patch 9.0.0892: may redraw when not needed
...
Problem: May redraw when not needed, causing slow scrolling.
Solution: Do not redraw when w_skipcol doesn't change. When w_skipcol
changes only redraw from the top. (issue #11559 )
2022-11-17 11:34:38 +00:00
Christopher Plewright
44c2209352
patch 9.0.0886: horizontal mouse scroll only works in the GUI
...
Problem: Horizontal mouse scroll only works in the GUI.
Solution: Make horizontal mouse scroll also work in a terminal.
(Christopher Plewright, closes #11448 )
2022-11-15 17:43:36 +00:00
Martin Tournoij
7904fa420e
patch 9.0.0657: too many #ifdefs
...
Problem: Too many #ifdefs.
Solution: Graduate the +cmdwin feature. Now the tiny and small builds are
equal, drop the small build. (Martin Tournoij, closes #11268 )
2022-10-04 16:28:45 +01:00
Bram Moolenaar
b2f0ca820e
patch 9.0.0500: when quitting cmdline window with CTRL-C it remains visible
...
Problem: When quitting the cmdline window with CTRL-C it remains visible.
Solution: Redraw to avoid confusion. Adjust the error message.
(closes #11152 ) Adjust the cursor position after CTRL-C.
2022-09-18 15:08:19 +01:00
Bram Moolenaar
1c3dd8ddcb
patch 9.0.0490: using freed memory with cmdwin and BufEnter autocmd
...
Problem: Using freed memory with cmdwin and BufEnter autocmd.
Solution: Make sure pointer to b_p_iminsert is still valid.
2022-09-17 19:43:23 +01:00
Luuk van Baal
3735f11050
patch 9.0.0469: cursor moves if cmdwin is closed when 'splitscroll' is off
...
Problem: Cursor moves if cmdwin is closed when 'splitscroll' is off.
Solution: Skip win_fix_cursor if called when cmdwin is open or closing.
(Luuk van Baal, closes #11134 )
2022-09-15 12:43:26 +01:00
mityu
e697d48890
patch 9.0.0465: cursor moves when cmdwin is closed when 'splitscroll' is off
...
Problem: Cursor moves when cmdwin is closed when 'splitscroll' is off.
Solution: Temporarily set 'splitscroll' when jumping back to the original
window. (closes #11128 )
2022-09-14 17:27:36 +01:00
Bram Moolenaar
cf0995d7d7
patch 9.0.0447: using :echowin while at the hit-enter prompt causes problems
...
Problem: Using :echowin while at the hit-enter prompt causes problems.
Solution: Do not prompt for :echowin. Postpone showing the message window.
Start the timer when the window is displayed.
2022-09-11 21:36:17 +01:00
Bram Moolenaar
a2a8973e51
patch 9.0.0340: the 'cmdheight' zero support causes too much trouble
...
Problem: The 'cmdheight' zero support causes too much trouble.
Solution: Revert support for 'cmdheight' being zero.
2022-08-31 14:46:18 +01:00
Bram Moolenaar
37fef16c22
patch 9.0.0321: cannot use the message popup window directly
...
Problem: Cannot use the message popup window directly.
Solution: Add ":echowindow".
2022-08-29 18:16:32 +01:00
zeertzjq
54acb90d9e
patch 9.0.0320: command line type of CmdlineChange differs from getcmdtype()
...
Problem: Command line type of CmdlineChange differs from getcmdtype().
Solution: Use the same type. (closes #11005 )
2022-08-29 16:21:25 +01:00
Bram Moolenaar
13608d851a
patch 9.0.0318: clearing screen causes flicker
...
Problem: Clearing screen causes flicker.
Solution: Do not clear but redraw in more cases. Add () to "wait_return".
2022-08-29 15:06:50 +01:00
Bram Moolenaar
f73e5ba56f
patch 9.0.0316: screen flickers when 'cmdheight' is zero
...
Problem: Screen flickers when 'cmdheight' is zero.
Solution: Redraw over existing text instead of clearing.
2022-08-29 12:41:06 +01:00
Yegappan Lakshmanan
25f1e55562
patch 9.0.0299: error messages for setcmdline() could be better
...
Problem: Error messages for setcmdline() could be better.
Solution: Use more specific error messages. (Yegappan Lakshmanan,
closes #10995 )
2022-08-28 17:25:04 +01:00
Bram Moolenaar
b0509c542e
patch 9.0.0293: messages window not hidden when starting a command line
...
Problem: Messages window not hidden when starting a command line.
Solution: Hide the messages window. (closes #10996 )
2022-08-28 12:06:21 +01:00
Shougo Matsushita
07ea5f1509
patch 9.0.0285: it is not easy to change the command line from a plugin
...
Problem: It is not easy to change the command line from a plugin.
Solution: Add setcmdline(). (Shougo Matsushita, closes #10869 )
2022-08-27 12:22:25 +01:00
Bram Moolenaar
5416232707
patch 9.0.0279: the tiny version has the popup menu but not 'wildmenu'
...
Problem: The tiny version has the popup menu but not 'wildmenu'.
Solution: Graduate the wildmenu feature.
2022-08-26 16:58:51 +01:00
zeertzjq
9b7d2a9596
patch 9.0.0271: using INIT() in non-header files
...
Problem: Using INIT() in non-header files.
Solution: Remove INIT(). (closes #10981 )
2022-08-26 10:33:54 +01:00
Bram Moolenaar
8884916043
patch 9.0.0239: build failure without the +wildmenu feature
...
Problem: Build failure without the +wildmenu feature.
Solution: Move parenthesis.
2022-08-21 19:08:50 +01:00
Bram Moolenaar
300175fd7f
patch 9.0.0238: Shift-Tab shows matches on cmdline when 'wildmenu' is off
...
Problem: Shift-Tab shows matches on cmdline when 'wildmenu' is off.
Solution: Only show matches when 'wildmode' contains "list". (closes #10951 )
2022-08-21 18:38:21 +01:00
Bram Moolenaar
a4d158b3c8
patch 9.0.0206: redraw flags are not named specifically
...
Problem: Redraw flags are not named specifically.
Solution: Prefix "UPD_" to the flags, for UPDate_screen().
2022-08-14 14:17:45 +01:00
Bram Moolenaar
6747cf1671
patch 9.0.0115: when 'cmdheight' is zero pressing ':' may scroll a window
...
Problem: When 'cmdheight' is zero pressing ':' may scroll a window.
Solution: Add the made_cmdheight_nonzero flag and set 'scrolloff' to zero.
2022-07-30 19:10:06 +01:00
Shougo Matsushita
f39cfb7262
patch 9.0.0114: the command line takes up space even when not used
...
Problem: The command line takes up space even when not used.
Solution: Allow for 'cmdheight' to be set to zero. (Shougo Matsushita,
closes #10675 , closes #940 )
2022-07-30 16:54:05 +01:00
zeertzjq
46af7bc08d
patch 9.0.0099: scrollback can be wrong after redrawing the command line
...
Problem: Scrollback can be wrong after redrawing the command line.
Solution: Clear unfinished scrollback when redrawing. (closes #10807 )
2022-07-28 12:34:09 +01:00
zeertzjq
6791adca53
patch 9.0.0086: tabline is not redrawn when entering command line
...
Problem: Tabline is not redrawn when entering command line.
Solution: Set "redraw_tabline". (closes #10771 )
2022-07-26 20:42:25 +01:00
zeertzjq
c9e8fd6fc7
patch 9.0.0083: ModeChanged event not triggered when leaving cmdline window
...
Problem: ModeChanged event not triggered when leaving the cmdline window.
Solution: Call may_trigger_modechanged(). (closes #10791 )
2022-07-26 18:12:38 +01:00
zeertzjq
3cfae39b08
patch 9.0.0082: cannot interrupt global command from command line
...
Problem: Cannot interrupt global command from command line.
Solution: Reset got_int in another place. (closes #10739 )
2022-07-26 17:48:13 +01:00
zeertzjq
f754fe6a3d
patch 9.0.0051: using CTRL-C wih :append may hang Vim
...
Problem: Using CTRL-C wih :append may hang Vim.
Solution: Reset got_int. (closes #10729 , closes #10728 )
2022-07-14 17:06:12 +01:00
Bram Moolenaar
6689df024b
patch 8.2.5149: cannot build without the +eval feature
...
Problem: Cannot build without the +eval feature. (Tony Mechelynck)
Solution: Add #ifdefs.
2022-06-22 18:14:29 +01:00
Bram Moolenaar
6046aded8d
patch 8.2.5148: invalid memory access when using expression on command line
...
Problem: Invalid memory access when using an expression on the command line.
Solution: Make sure the position does not go negative.
2022-06-22 13:51:54 +01:00
zeertzjq
44068e97db
patch 8.2.5106: default cmdwin mappings are re-mappable
...
Problem: Default cmdwin mappings are re-mappable.
Solution: Make the default mappings not re-mappable. (closes #10580 ) Use
symbols for the first do_map() argument.
2022-06-16 11:14:55 +01:00
zeertzjq
cd7496382e
patch 8.2.5088: value of cmod_verbose is a bit complicated to use
...
Problem: Value of cmod_verbose is a bit complicated to use.
Solution: Use zero for not set, value + 1 when set. (closes #10564 )
2022-06-14 13:30:35 +01:00
Paul Ollis
6574577cac
patch 8.2.5057: using gettimeofday() for timeout is very inefficient
...
Problem: Using gettimeofday() for timeout is very inefficient.
Solution: Set a platform dependent timer. (Paul Ollis, closes #10505 )
2022-06-05 16:55:54 +01:00
Bram Moolenaar
be99042b03
patch 8.2.5044: command line test fails
...
Problem: Command line test fails.
Solution: Also beep when cmdline win can't be opened because of locks.
Make the test not beep. Make the test pass on MS-Windows.
2022-05-30 16:01:42 +01:00
Bram Moolenaar
71223e2db8
patch 8.2.5043: can open a cmdline window from a substitute expression
...
Problem: Can open a cmdline window from a substitute expression.
Solution: Disallow opening a command line window when text or buffer is
locked.
2022-05-30 15:23:09 +01:00
zeertzjq
cfe456543e
patch 8.2.5029: "textlock" is always zero
...
Problem: "textlock" is always zero.
Solution: Remove "textlock" and rename "textwinlock" to "textlock".
(closes #10489 )
2022-05-27 17:26:55 +01:00