zeertzjq
94b7c3233e
patch 9.1.0172: More code can use ml_get_buf_len() instead of STRLEN()
...
Problem: More code can use ml_get_buf_len() instead of STRLEN().
Solution: Change more STRLEN() calls to ml_get_buf_len(). Also do not
set ml_line_textlen in ml_replace_len() if "has_props" is set,
because "len_arg" also includes the size of text properties in
that case. (zeertzjq)
closes : #14183
Signed-off-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-03-12 21:50:32 +01:00
Shota Nozaki
0689b87059
patch 9.1.0002: a closing fold expr, may start a new fold
...
Problem: a closing fold expression may unexpectedly start a new fold
when it should end a fold
(reported by Shota Nozaki)
Solution: if a fold hasn't started yet, do not immediately
start a new fold with level 1
(Shota Nozaki)
fixes : #12768
closes : #13748
Signed-off-by: Shota Nozaki <emonkak@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
2024-01-03 19:18:43 +01:00
Yegappan Lakshmanan
fadc02a2a5
patch 9.0.1251: checking returned value of ga_grow() is inconsistent
...
Problem: Checking returned value of ga_grow() is inconsistent.
Solution: Check for FAIL instaed of "not OK". (Yegappan Lakshmanan,
closes #11897 )
2023-01-27 21:03:12 +00:00
Yegappan Lakshmanan
1cfb14aa97
patch 9.0.1166: code is indented more than necessary
...
Problem: Code is indented more than necessary.
Solution: Use an early return where it makes sense. (Yegappan Lakshmanan,
closes #11792 )
2023-01-09 19:04:23 +00:00
Yegappan Lakshmanan
7f8b2559a3
patch 9.0.1158: code is indented more than necessary
...
Problem: Code is indented more than necessary.
Solution: Use an early return where it makes sense. (Yegappan Lakshmanan,
closes #11787 )
2023-01-08 13:44:24 +00:00
Yegappan Lakshmanan
dc4daa3a39
patch 9.0.1132: code is indented more than needed
...
Problem: Code is indented more than needed.
Solution: Use an early return to reduce indentation. (Yegappan Lakshmanan,
closes #11769 )
2023-01-02 16:54:53 +00:00
Bram Moolenaar
a4e0b9785e
patch 9.0.0634: evaluating "expr" options has more overhead than needed
...
Problem: Evaluating "expr" options has more overhead than needed.
Solution: Use call_simple_func() for 'foldtext', 'includeexpr', 'printexpr',
"expr" of 'spellsuggest', 'diffexpr', 'patchexpr', 'balloonexpr',
'formatexpr', 'indentexpr' and 'charconvert'.
2022-10-01 19:43:52 +01:00
Bram Moolenaar
a4d158b3c8
patch 9.0.0206: redraw flags are not named specifically
...
Problem: Redraw flags are not named specifically.
Solution: Prefix "UPD_" to the flags, for UPDate_screen().
2022-08-14 14:17:45 +01:00
Brandon Simmons
e8c4a64bff
patch 8.2.5009: fold may not be closeable after appending
...
Problem: Fold may not be closeable after appending.
Solution: Set the fd_small flag to MAYBE. (Brandon Simmons, closes #10471 )
2022-05-23 15:33:08 +01:00
Brandon Simmons
3fcccf94e8
patch 8.2.4987: after deletion a small fold may be closable
...
Problem: After deletion a small fold may be closable.
Solution: Check for a reverse range. (Brandon Simmons, closes #10457 )
2022-05-20 18:25:21 +01:00
Brandon Simmons
d98e75e236
patch 8.2.4935: with 'foldmethod' "indent" some lines not included in fold
...
Problem: With 'foldmethod' "indent" some lines are not included in the
fold. (Oleg Koshovetc)
Solution: Fix it. (Brandon Simmons, closes #10399 , closes #3214 )
2022-05-10 19:13:23 +01:00
Bram Moolenaar
249591057b
patch 8.2.4911: the mode #defines are not clearly named
...
Problem: The mode #defines are not clearly named.
Solution: Prepend MODE_. Renumber them to put the mapped modes first.
2022-05-07 20:01:16 +01:00
Brandon Simmons
2c40707baa
patch 8.2.4813: pasting text while indent folding may mess up folds
...
Problem: Pasting text while indent folding may mess up folds.
Solution: Adjust the way folds are split. (Brandon Simmons, closes #10254 )
2022-04-23 13:50:17 +01:00
kylo252
ae6f1d8b14
patch 8.2.4402: missing parenthesis may cause unexpected problems
...
Problem: Missing parenthesis may cause unexpected problems.
Solution: Add more parenthesis is macros. (closes #9788 )
2022-02-16 19:24:07 +00:00
Bram Moolenaar
6b43471da4
patch 8.2.4393: possible number overflow with nested folds
...
Problem: Possible number overflow with nested folds.
Solution: Avoid a negative line number.
2022-02-15 19:15:22 +00:00
=?UTF-8?q?Dundar=20G=C3=B6c?=
420fabcd4f
patch 8.2.4241: some type casts are redundant
...
Problem: Some type casts are redundant.
Solution: Remove the type casts. (closes #9643 )
2022-01-28 15:28:04 +00:00
Bram Moolenaar
9530b580a7
patch 8.2.4179: 'foldtext' is evaluated in the current script context
...
Problem: 'foldtext' is evaluated in the current script context.
Solution: Use the script context where the option was set.
2022-01-22 13:39:08 +00:00
Bram Moolenaar
e70dd11ef4
patch 8.2.4173: cannot use an import in 'foldexpr'
...
Problem: Cannot use an import in 'foldexpr'.
Solution: Set the script context to where 'foldexpr' was set. (closes #9584 )
Fix that the script context was not set for all buffers.
2022-01-21 16:31:11 +00:00
Bram Moolenaar
04935fb17e
patch 8.2.4043: using int for second argument of ga_init2()
...
Problem: Using int for second argument of ga_init2().
Solution: Remove unnessary type cast (int) when using sizeof().
2022-01-08 16:19:22 +00:00
Bram Moolenaar
b09feaa86e
patch 8.2.3986: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
2022-01-02 20:20:45 +00:00
Bram Moolenaar
ac78dd4a35
patch 8.2.3985: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move more error messages to errors.h.
2022-01-02 19:25:26 +00:00
Dominique Pelle
af4a61a85d
patch 8.2.3914: various spelling mistakes in comments
...
Problem: Various spelling mistakes in comments.
Solution: Fix the mistakes. (Dominique Pellé, closes #9416 )
2021-12-27 17:21:41 +00:00
Bram Moolenaar
cf1e0239ce
patch 8.2.3662: illegal memory access if malloc() fails
...
Problem: Illegal memory access if malloc() fails.
Solution: Check 'foldmethod' is not empty. (closes #9207 )
2021-11-24 15:13:26 +00:00
Yegappan Lakshmanan
4490ec4e83
patch 8.2.3229: Vim9: runtime and compile time type checks are not the same
...
Problem: Vim9: runtime and compile time type checks are not the same.
Solution: Add more runtime type checks for builtin functions. (Yegappan
Lakshmanan, closes #8646 )
2021-07-27 22:00:44 +02:00
Bram Moolenaar
108010aa47
patch 8.2.3069: error messages are spread out
...
Problem: Error messages are spread out.
Solution: Move some error messages to errors.h. Use clearer names.
2021-06-27 22:03:33 +02:00
Bram Moolenaar
f9547eb6ef
patch 8.2.2447: 'foldlevel' not applied to folds restored from session
...
Problem: 'foldlevel' not applied to folds restored from session.
Solution: Set 'foldlevel' after creaiting the folds. (closes #7767 )
2021-02-01 19:24:55 +01:00
Bram Moolenaar
6a78f32844
patch 8.2.2176: crash with a sequence of fold commands
...
Problem: Crash with a sequence of fold commands.
Solution: Bail out when there are no folds at all. Add a test (Dominique
Pellé) (closes #7515 )
2020-12-21 14:01:41 +01:00
Bram Moolenaar
5e1f22ff61
patch 8.2.1972: crash when recreating nested fold
...
Problem: Crash when recreating nested fold.
Solution: Check for empty growarray. (closes #7278 )
2020-11-10 18:23:52 +01:00
Bram Moolenaar
c136a3528b
patch 8.2.1947: crash when using "zj" without folds
...
Problem: Crash when using "zj" without folds. (Sean Dewar)
Solution: Check for at least one fold. (closes #7245 )
2020-11-03 20:05:40 +01:00
Bram Moolenaar
da697645d5
patch 8.2.1702: crash when using undo after deleting folded lines
...
Problem: Crash when using undo after deleting folded lines.
Solution: Check for NULL pointer. (closes #6968 )
2020-09-17 19:36:04 +02:00
Bram Moolenaar
81fcb67fb3
patch 8.2.1561: using NULL pointers in fold code
...
Problem: Using NULL pointers in fold code.
Solution: Avoid using a NULL pointer. (Dominique Pellé, closes #6831 ,
closes #6831 )
2020-09-01 21:21:24 +02:00
Bram Moolenaar
9c2b06637b
patch 8.2.1560: using NULL pointers in some code
...
Problem: Using NULL pointers in some code. (James McCoy)
Solution: Avoid adding to a NULL pointer. Use byte as unsigned.
2020-09-01 19:56:15 +02:00
Bram Moolenaar
07e87e9eb5
patch 8.2.1554: crash in normal test
...
Problem: Crash in normal test.
Solution: Skip adjusting marks if there are no folds.
2020-08-31 21:22:40 +02:00
Bram Moolenaar
2c93c685e3
patch 8.2.1553: crash in edit test
...
Problem: Crash in edit test.
Solution: Avoid using invalid pointer.
2020-08-31 21:15:02 +02:00
Bram Moolenaar
64f37d3090
patch 8.2.1552: warnings from asan with clang-11
...
Problem: Warnings from asan with clang-11. (James McCoy)
Solution: Avoid using a NULL pointer. (issue #6811 )
2020-08-31 19:58:13 +02:00
Bram Moolenaar
b171fb1790
patch 8.2.1049: Vim9: leaking memory when using continuation line
...
Problem: Vim9: leaking memory when using continuation line.
Solution: Keep a pointer to the continuation line in evalarg_T. Centralize
checking for a next command.
2020-06-24 20:34:03 +02:00
Bram Moolenaar
217e1b8359
patch 8.1.2379: using old C style comments
...
Problem: Using old C style comments.
Solution: Use // comments where appropriate.
2019-12-01 21:41:28 +01:00
Bram Moolenaar
8c96af9c05
patch 8.1.2096: too many #ifdefs
...
Problem: Too many #ifdefs.
Solution: Graduate FEAT_COMMENTS.
2019-09-28 19:05:57 +02:00
Bram Moolenaar
db022f3ffb
patch 8.1.1960: fold code is spread out
...
Problem: Fold code is spread out.
Solution: Move fold functions to fold.c.
2019-09-01 17:52:32 +02:00
Bram Moolenaar
4f57eefe1e
patch 8.1.1922: in diff mode global operations can be very slow
...
Problem: In diff mode global operations can be very slow.
Solution: Do not call diff_redraw() many times, call it once when redrawing.
And also don't update folds multiple times.
2019-08-24 20:54:19 +02:00
Bram Moolenaar
9a4a8c4d59
patch 8.1.1890: ml_get error when deleting fold marker
...
Problem: Ml_get error when deleting fold marker.
Solution: Check that the line number is not below the last line. Adjust the
fold when deleting the empty line. (Christian Brabandt,
closes #4834 )
2019-08-19 22:48:30 +02:00
Bram Moolenaar
964b3746b9
patch 8.1.1384: using "int" for alloc() often results in compiler warnings
...
Problem: Using "int" for alloc() often results in compiler warnings.
Solution: Use "size_t" and remove type casts. Remove alloc_check(), Vim
only works with 32 bit ints anyway.
2019-05-24 18:54:09 +02:00
Bram Moolenaar
135059724f
patch 8.1.0805: too many #ifdefs
...
Problem: Too many #ifdefs.
Solution: Graduate FEAT_MBYTE, part 1.
2019-01-24 15:04:48 +01:00
Bram Moolenaar
f9e3e09fdc
patch 8.1.0743: giving error messages is not flexible
...
Problem: Giving error messages is not flexible.
Solution: Add semsg(). Change argument from "char_u *" to "char *", also
for msg() and get rid of most MSG macros. (Ozaki Kiichi, closes
#3302 ) Also make emsg() accept a "char *" argument. Get rid of
an enormous number of type casts.
2019-01-13 23:38:42 +01:00
Bram Moolenaar
0c27cbcacf
patch 8.1.0527: using 'shiftwidth' from wrong buffer for folding
...
Problem: Using 'shiftwidth' from wrong buffer for folding.
Solution: Use "buf" instead of "curbuf". (Christian Brabandt)
2018-11-14 21:45:32 +01:00
Bram Moolenaar
4033c55eca
patch 8.0.1118: FEAT_WINDOWS adds a lot of #ifdefs
...
Problem: FEAT_WINDOWS adds a lot of #ifdefs while it is nearly always
enabled and only adds 7% to the binary size of the tiny build.
Solution: Graduate FEAT_WINDOWS.
2017-09-16 20:54:51 +02:00
Bram Moolenaar
b11c826ddc
patch 8.0.0583: fold test hangs on MS-Windows
...
Problem: Fold test hangs on MS-Windows.
Solution: Avoid overflow in compare.
2017-04-23 16:48:20 +02:00
Bram Moolenaar
94be619e30
patch 8.0.0581: moving folded text is sometimes not correct
...
Problem: Moving folded text is sometimes not correct.
Solution: Bail out when "move_end" is zero. (Matthew Malcomson)
2017-04-22 22:40:11 +02:00
Bram Moolenaar
9d20ce6970
patch 8.0.0503: endless loop in updating folds with 32 bit ints
...
Problem: Endless loop in updating folds with 32 bit ints.
Solution: Subtract from LHS instead of add to the RHS. (Matthew Malcomson)
2017-03-23 21:53:35 +01:00
Bram Moolenaar
0c0d4eca4d
patch 8.0.0469: compiler warnings on MS-Windows
...
Problem: Compiler warnings on MS-Windows.
Solution: Add type casts. (Christian Brabandt)
2017-03-16 22:06:57 +01:00