Bram Moolenaar
1a58e1d97c
patch 9.0.0671: negative topline using CTRL-Y with 'smoothscroll' and 'diff'
...
Problem: Negative topline using CTRL-Y with 'smoothscroll' and 'diff'.
(Ernie Rael)
Solution: Only use 'smoothscroll' when 'wrap' is set.
2022-10-06 13:09:17 +01:00
Martin Tournoij
7904fa420e
patch 9.0.0657: too many #ifdefs
...
Problem: Too many #ifdefs.
Solution: Graduate the +cmdwin feature. Now the tiny and small builds are
equal, drop the small build. (Martin Tournoij, closes #11268 )
2022-10-04 16:28:45 +01:00
Bram Moolenaar
b6aab8f44b
patch 9.0.0652: 'smoothscroll' not tested with 'number' and "n" in 'cpo'
...
Problem: 'smoothscroll' not tested with 'number' and "n" in 'cpo'.
Solution: Add tests, fix uncovered problem.
2022-10-03 20:01:16 +01:00
Luuk van Baal
13ece2ae1d
patch 9.0.0647: the 'splitscroll' option is not a good name
...
Problem: The 'splitscroll' option is not a good name.
Solution: Rename 'splitscroll' to 'splitkeep' and make it a string option,
also supporting "topline". (Luuk van Baal, closes #11258 )
2022-10-03 15:28:08 +01:00
Bram Moolenaar
6b2d4ff714
patch 9.0.0646: with 'smoothscroll' CTRL-E is wrong when 'foldmethod' set
...
Problem: with 'smoothscroll' set CTRL-E does not work properly when
'foldmethod' is set to "indent". (Yee Cheng Chin)
Solution: Merge the code for scroling with folds and 'smoothscroll'.
(closes #11262 )
2022-10-03 14:06:02 +01:00
Bram Moolenaar
8df9748edb
patch 9.0.0645: CTRL-Y does not stop at line 1
...
Problem: CTRL-Y does not stop at line 1. (John Marriott)
Solution: Stop at line 1 when 'smoothscroll' is not set. (closes #11261 )
2022-10-03 12:11:13 +01:00
Bram Moolenaar
f6196f4244
patch 9.0.0640: cannot scroll by screen line if a line wraps
...
Problem: Cannot scroll by screen line if a line wraps.
Solution: Add the 'smoothscroll' option. Only works for CTRL-E and CTRL-Y
so far.
2022-10-02 21:29:55 +01:00
Bram Moolenaar
d4566c14e7
patch 9.0.0581: adding a character for incsearch fails at end of line
...
Problem: Adding a character for incsearch fails at end of line.
Solution: Only check cursor line number.
2022-09-24 21:06:39 +01:00
Bram Moolenaar
0ff01835a4
patch 9.0.0579: using freed memory when 'tagfunc' wipes out buffer
...
Problem: Using freed memory when 'tagfunc' wipes out buffer that holds
'complete'.
Solution: Make a copy of the option. Make sure cursor position is valid.
2022-09-24 19:20:30 +01:00
Luuk van Baal
faf1d412f5
patch 9.0.0505: various problems with 'nosplitscroll'
...
Problem: Various problems with 'nosplitscroll'.
Solution: Fix 'nosplitscroll' problems. (Luuk van Baal, closes #11166 )
2022-09-19 16:45:29 +01:00
Bram Moolenaar
e24b4aba1f
patch 9.0.0482: "g0" moves to wrong location with virtual text "above"
...
Problem: "g0" moves to wrong location with virtual text "above".
Solution: Compensate for the extra columns. (closes #11141 ) Also fix "g$"
2022-09-16 20:51:14 +01:00
Bram Moolenaar
c9dc03fff5
patch 9.0.0451: virtual text "above" does not work with 'nowrap'
...
Problem: Virtual text "above" does not work with 'nowrap'.
Solution: Do wrap the line after. (closes #11084 )
2022-09-12 17:51:07 +01:00
Luuk van Baal
29ab524358
patch 9.0.0445: when opening/closing window text moves up/down
...
Problem: When opening/closing window text moves up/down.
Solution: Add the 'splitscroll' option. When off text will keep its
position as much as possible.
2022-09-11 16:59:53 +01:00
Bram Moolenaar
04e0ed1ddf
patch 9.0.0438: cannot put virtual text above a line
...
Problem: Cannot put virtual text above a line.
Solution: Add the "above" value for "text_align".
2022-09-10 20:00:56 +01:00
Bram Moolenaar
a4d158b3c8
patch 9.0.0206: redraw flags are not named specifically
...
Problem: Redraw flags are not named specifically.
Solution: Prefix "UPD_" to the flags, for UPDate_screen().
2022-08-14 14:17:45 +01:00
Bram Moolenaar
326c5d36e7
patch 9.0.0194: cursor displayed in wrong position after removing text prop
...
Problem: Cursor displayed in wrong position after removing text prop. (Ben
Jackson)
Solution: Invalidate the cursor position. (closes #10898 )
2022-08-12 13:05:49 +01:00
Bram Moolenaar
a315ce1f32
patch 8.2.5155: in diff mode windows may get out of sync
...
Problem: In diff mode windows may get out of sync. (Gary Johnson)
Solution: Avoid that the other window scrolls for 'cursorbind'.
2022-06-24 12:38:57 +01:00
Bram Moolenaar
8088ae95bb
patch 8.2.5138: various small issues
...
Problem: Various small issues.
Solution: Various small improvments.
2022-06-20 11:38:17 +01:00
Bram Moolenaar
93a1096fe4
patch 8.2.5107: some callers of rettv_list_alloc() check for not OK
...
Problem: Some callers of rettv_list_alloc() check for not OK. (Christ van
Willegen)
Solution: Use "==" instead of "!=" when checking the return value.
2022-06-16 11:42:09 +01:00
Bram Moolenaar
5a6ec10cc8
patch 8.2.5034: there is no way to get the byte index from a virtual column
...
Problem: There is no way to get the byte index from a virtual column.
Solution: Add virtcol2col(). (Yegappan Lakshmanan, closes #10477 ,
closes #10098 )
2022-05-27 21:58:00 +01:00
Bram Moolenaar
6ed545e797
patch 8.2.4928: various white space and cosmetic mistakes
...
Problem: Various white space and cosmetic mistakes.
Solution: Change spaces to tabs, improve comments.
2022-05-09 20:09:23 +01:00
Bram Moolenaar
a91cb98bb3
patch 8.2.4915: sometimes the cursor is in the wrong position
...
Problem: Sometimes the cursor is in the wrong position.
Solution: When the cursor moved to another line, recompute w_botline.
(closes #9736 )
2022-05-08 19:39:31 +01:00
Christian Brabandt
2c645e8b00
patch 8.2.4795: 'cursorbind' scrolling depends on whether 'cursorline' is set
...
Problem: 'cursorbind' scrolling depends on whether 'cursorline' is set.
Solution: Always call validate_cursor(). (Christian Brabandt, closes #10230 ,
closes #10014 )
2022-04-20 14:52:01 +01:00
Bram Moolenaar
471b3aed3e
patch 8.2.4641: may mark the wrong window for redrawing
...
Problem: May mark the wrong window for redrawing.
Solution: Use redraw_win_later(). (closes #10032 )
2022-03-28 12:41:19 +01:00
zeertzjq
3e559cd884
patch 8.2.4638: superfluous check if a redraw is needed for 'cursorline'
...
Problem: Superfluous check if a redraw is needed for 'cursorline'.
Solution: Remove check_redraw_cursorline(). (closes #10030 , closes #10029 )
2022-03-27 19:26:55 +01:00
zeertzjq
c20e46a4e3
patch 8.2.4614: redrawing too much when 'cursorline' is set
...
Problem: Redrawing too much when 'cursorline' is set and jumping around.
Solution: Rely on win_update() to redraw the current and previous cursor
line, do not mark lines as modified. (closes #9996 )
2022-03-23 14:55:23 +00:00
Bram Moolenaar
4556a2e868
patch 8.2.4389: screenpos() does not handle a position in a closed fold
...
Problem: screenpos() does not handle a position in a closed fold.
Solution: Check if the position is inside a closed fold. (closes #9778 )
2022-02-15 13:40:17 +00:00
Bram Moolenaar
7924a17791
patch 8.2.4204: screenpos() has non-zero row for invisible text
...
Problem: screenpos() has non-zero row for invisible text.
Solution: Only add the window row when the text is visible. (closes #9618 )
2022-01-24 16:15:15 +00:00
Dominique Pelle
af4a61a85d
patch 8.2.3914: various spelling mistakes in comments
...
Problem: Various spelling mistakes in comments.
Solution: Fix the mistakes. (Dominique Pellé, closes #9416 )
2021-12-27 17:21:41 +00:00
Bram Moolenaar
777e7c21b7
patch 8.2.3564: invalid memory access when scrolling without valid screen
...
Problem: Invalid memory access when scrolling without a valid screen.
Solution: Do not set VALID_BOTLINE in w_valid.
2021-10-25 17:07:04 +01:00
=?UTF-8?q?Dundar=20G=C3=B6c?=
3826c0513b
patch 8.2.3490: superfluous return statements
...
Problem: Superfluous return statements.
Solution: Remove superfluous return statements from void functions.
(closes #8977 )
2021-10-09 15:39:25 +01:00
=?UTF-8?q?Dundar=20G=C3=B6c?=
dfa5e464d4
patch 8.2.3460: some type casts are not needed
...
Problem: Some type casts are not needed.
Solution: Remove unnecessary type casts. (closes #8934 )
2021-10-02 11:26:51 +01:00
Bram Moolenaar
04626c243c
patch 8.2.3394: filler lines are wrong when changing text in diff mode
...
Problem: Filler lines are wrong when changing text in diff mode.
Solution: Don't change the filler lines on every change. Check
scrollbinding when updating the filler lines. (closes #8809 )
2021-09-01 16:02:07 +02:00
Yegappan Lakshmanan
4490ec4e83
patch 8.2.3229: Vim9: runtime and compile time type checks are not the same
...
Problem: Vim9: runtime and compile time type checks are not the same.
Solution: Add more runtime type checks for builtin functions. (Yegappan
Lakshmanan, closes #8646 )
2021-07-27 22:00:44 +02:00
Bram Moolenaar
189663bdac
patch 8.2.3193: screenpos() is wrong when 'display' is "lastline"
...
Problem: screenpos() is wrong when the last line is partially visible and
'display' is "lastline".
Solution: Also compute the position for a partially visible line.
(closes #8599 )
2021-07-21 18:04:56 +02:00
Bram Moolenaar
30441bb3d5
patch 8.2.3122: with 'nowrap' cursor position is unexected in narrow window
...
Problem: With 'nowrap' cursor position is unexected in narrow window.
(Leonid V. Fedorenchik)
Solution: Put cursor on the last non-empty line. (closes #8525 )
2021-07-08 13:19:31 +02:00
Bram Moolenaar
8f33ebfade
patch 8.2.2495: text jumps up and down when moving the cursor
...
Problem: Text jumps up and down when moving the cursor in a small window
with wrapping text and 'scrolloff' set.
Solution: Adjust the computation of w_skipcol. (partly by Ghjuvan Lacambre,
closes #7813 )
2021-02-10 21:10:12 +01:00
Bram Moolenaar
23999d799c
patch 8.2.2198: ml_get error when resizing window and using text property
...
Problem: ml_get error when resizing window and using text property.
Solution: Validate botline of the right window. (closes #7528 )
2020-12-23 14:36:00 +01:00
Bram Moolenaar
8dd46e72cf
patch 8.2.2152: screenpos() does not include the WinBar offset
...
Problem: screenpos() does not include the WinBar offset.
Solution: Use W_WINROW() instead of directly using w_window. (closes #7487 )
2020-12-17 21:35:29 +01:00
Bram Moolenaar
4792a679f9
patch 8.2.1992: build fails with small features
...
Problem: Build fails with small features.
Solution: Add #ifdef.
2020-11-15 21:11:18 +01:00
Bram Moolenaar
6a07644db3
patch 8.2.1990: cursor position wrong in terminal popup with finished job
...
Problem: Cursor position wrong in terminal popup with finished job.
Solution: Only add the top and left offset when not done already.
(closes #7298 )
2020-11-15 20:32:58 +01:00
Bram Moolenaar
3b6d57f2ce
patch 8.2.1939: invalid memory access in Ex mode with global command
...
Problem: Invalid memory access in Ex mode with global command.
Solution: Make sure the cursor is on a valid line. (closes #7238 )
2020-11-01 21:56:40 +01:00
Bram Moolenaar
3697c9bbae
patch 8.2.1750: popup_setoptions() setting firstline fails if cursorline set
...
Problem: Setting firstline with popup_setoptions() fails if cursorline is
set.
Solution: Use apply_options(). Update the popup before applying "zz".
(closes #7010 )
2020-09-26 22:03:00 +02:00
Bram Moolenaar
8455c5ed31
patch 8.2.1211: removed more than dead code
...
Problem: Removed more than dead code.
Solution: Put back the decrement.
2020-07-14 21:22:30 +02:00
Bram Moolenaar
810af5ea46
patch 8.2.1118: condition can never be true, dead code
...
Problem: Condition can never be true, dead code.
Solution: Remove the dead code.
2020-07-02 21:23:42 +02:00
Bram Moolenaar
e52e0c89d1
patch 8.2.0328: no redraw when leaving term-normal mode in popup terminal
...
Problem: No redraw when leaving terminal-normal mode in a terminal popup
window.
Solution: Redraw the popup window. (closes #5708 )
2020-02-28 22:20:10 +01:00
Bram Moolenaar
85a2002adb
patch 8.2.0026: still some /* */ comments
...
Problem: Still some /* */ comments.
Solution: Convert to // comments.
2019-12-21 18:25:54 +01:00
Bram Moolenaar
09dd2bb336
patch 8.2.0007: popup menu positioned wrong with folding in two tabs
...
Problem: Popup menu positioned wrong with folding in two tabs.
Solution: Update the cursor line height. (closes #5353 )
2019-12-14 18:42:15 +01:00
Bram Moolenaar
05ad5ff0ab
patch 8.1.2371: FEAT_TEXT_PROP is a confusing name
...
Problem: FEAT_TEXT_PROP is a confusing name.
Solution: Use FEAT_PROP_POPUP. (Naruhiko Nishino, closes #5291 )
2019-11-30 22:48:27 +01:00
Bram Moolenaar
08f23636ae
patch 8.1.2303: cursor in wrong position after horizontal scroll
...
Problem: Cursor in wrong position after horizontal scroll.
Solution: Set w_valid_leftcol. (closes #5214 , closes #5224 )
2019-11-16 14:19:33 +01:00