From eebd555733491cb55b9f30fe28772c0fd0ebacf7 Mon Sep 17 00:00:00 2001 From: Bram Moolenaar Date: Wed, 10 Jun 2020 15:45:57 +0200 Subject: [PATCH] patch 8.2.0946: cannot use "q" to cancel a number prompt Problem: Cannot use "q" to cancel a number prompt. Solution: Recognize "q" instead of ignoring it. --- src/misc1.c | 6 +++--- src/testdir/test_functions.vim | 12 ++++++++++++ src/version.c | 2 ++ 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/src/misc1.c b/src/misc1.c index a370a82f8d..db76d9bfa8 100644 --- a/src/misc1.c +++ b/src/misc1.c @@ -945,7 +945,7 @@ get_number( do_redraw = FALSE; break; } - else if (c == CAR || c == NL || c == Ctrl_C || c == ESC) + else if (c == CAR || c == NL || c == Ctrl_C || c == ESC || c == 'q') break; } --no_mapping; @@ -967,9 +967,9 @@ prompt_for_number(int *mouse_used) // When using ":silent" assume that was entered. if (mouse_used != NULL) - msg_puts(_("Type number and or click with mouse (empty cancels): ")); + msg_puts(_("Type number and or click with the mouse (q or empty cancels): ")); else - msg_puts(_("Type number and (empty cancels): ")); + msg_puts(_("Type number and (q or empty cancels): ")); // Set the state such that text can be selected/copied/pasted and we still // get mouse events. redraw_after_callback() will not redraw if cmdline_row diff --git a/src/testdir/test_functions.vim b/src/testdir/test_functions.vim index 1de9c4c556..d3bf1db250 100644 --- a/src/testdir/test_functions.vim +++ b/src/testdir/test_functions.vim @@ -1371,6 +1371,18 @@ func Test_inputlist() call feedkeys(":let c = inputlist(['Select color:', '1. red', '2. green', '3. blue'])\3\", 'tx') call assert_equal(3, c) + " CR to cancel + call feedkeys(":let c = inputlist(['Select color:', '1. red', '2. green', '3. blue'])\\", 'tx') + call assert_equal(0, c) + + " Esc to cancel + call feedkeys(":let c = inputlist(['Select color:', '1. red', '2. green', '3. blue'])\\", 'tx') + call assert_equal(0, c) + + " q to cancel + call feedkeys(":let c = inputlist(['Select color:', '1. red', '2. green', '3. blue'])\q", 'tx') + call assert_equal(0, c) + " Use backspace to delete characters in the prompt call feedkeys(":let c = inputlist(['Select color:', '1. red', '2. green', '3. blue'])\1\3\2\", 'tx') call assert_equal(2, c) diff --git a/src/version.c b/src/version.c index 30106ff003..bce00b3cb6 100644 --- a/src/version.c +++ b/src/version.c @@ -754,6 +754,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 946, /**/ 945, /**/