aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-09-28 04:24:06 -04:00
Code Activity

patch 8.2.1896: valgrind warns for using uninitialized memory

Browse Source 
Problem:    Valgrind warns for using uninitialized memory.
Solution:   NUL terminate the SmcOpenConnection() error message. (Dominique
            Pellé, closes #7194)
This commit is contained in:
Bram Moolenaar
2020-10-24 13:30:51 +02:00
parent 210681c509
commit e1be11864d
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/os_unix.c
View File

@@ -8068,10 +8068,13 @@ xsmp_init(void)
errorstring); errorstring);
if (xsmp.smcconn == NULL) if (xsmp.smcconn == NULL)
{ {
char errorreport[132];
if (p_verbose > 0) if (p_verbose > 0)
{ {
char errorreport[132];
// If the message is too long it might not be NUL terminated. Add
// a NUL at the end to make sure we don't go over the end.
errorstring[sizeof(errorstring) - 1] = NUL;
vim_snprintf(errorreport, sizeof(errorreport), vim_snprintf(errorreport, sizeof(errorreport),
_("XSMP SmcOpenConnection failed: %s"), errorstring); _("XSMP SmcOpenConnection failed: %s"), errorstring);
verb_msg(errorreport); verb_msg(errorreport);

2
src/version.c
View File

@@ -750,6 +750,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
1896,
/**/ /**/
1895, 1895,
/**/ /**/