aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-10-08 06:04:08 -04:00
Code Activity

patch 9.0.1830: Vim9: crash when accessing a null object

Browse Source 
Problem:  Vim9: crash when accessing a null object
Solution: Check accessing a NULL object in def function

An object is NULL when the variable is declared, but the constructor
isn't called. Accessing/setting a member on the object crashed Vim.

Note: this happens inside def functions, at script level things work
differently. Accessing a NULL object member results in E1360
(correctly), while setting a value on it results in E1012 (type
mismatch) so there's still something to fix.

closes: #12973

Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Gianmaria Bajo <mg1979.git@gmail.com>
This commit is contained in:
Gianmaria Bajo
2023-08-31 18:15:26 +02:00
committed by Christian Brabandt
parent eb91e24d5e
commit d7085a0635
3 changed files with 65 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
src/testdir/test_vim9_class.vim
View File

@@ -1180,6 +1180,61 @@ def Test_class_member()
END
v9.CheckScriptFailure(lines, 'E1010:')
# Test for setting a member on a null object
lines =<< trim END
vim9script
class A
this.val: string
endclass
def F()
var obj: A
obj.val = ""
enddef
F()
END
v9.CheckScriptFailure(lines, 'E1360: Using a null object')
# Test for accessing a member on a null object
lines =<< trim END
vim9script
class A
this.val: string
endclass
def F()
var obj: A
echo obj.val
enddef
F()
END
v9.CheckScriptFailure(lines, 'E1360: Using a null object')
# Test for setting a member on a null object, at script level
lines =<< trim END
vim9script
class A
this.val: string
endclass
var obj: A
obj.val = ""
END
# FIXME(in source): this should give E1360 as well!
v9.CheckScriptFailure(lines, 'E1012: Type mismatch; expected object<A> but got string')
# Test for accessing a member on a null object, at script level
lines =<< trim END
vim9script
class A
this.val: string
endclass
var obj: A
echo obj.val
END
v9.CheckScriptFailure(lines, 'E1360: Using a null object')
# Test for no space before or after the '=' when initializing a member
# variable
lines =<< trim END