aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-07-26 11:04:33 -04:00
Code

patch 7.4.1595

Browse Source 
Problem:    Not checking for failed open(). (Coverity)
Solution:   Check file descriptor not being negative.
This commit is contained in:
Bram Moolenaar 2016-03-19 14:12:50 +01:00
parent 943bb2b8eb
commit c0a1d7f3ad
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/os_unix.c
View File

@ -5150,7 +5150,7 @@ mch_start_job(char **argv, job_T *job, jobopt_T *options UNUSED)
null_fd = open("/dev/null", O_RDWR | O_EXTRA, 0);
/* set up stdin for the child */
if (use_null_for_in)
if (use_null_for_in && null_fd >= 0)
{
close(0);
ignored = dup(null_fd);
@ -5165,7 +5165,7 @@ mch_start_job(char **argv, job_T *job, jobopt_T *options UNUSED)
}
/* set up stderr for the child */
if (use_null_for_err)
if (use_null_for_err && null_fd >= 0)
{
close(2);
ignored = dup(null_fd);
@ -5185,7 +5185,7 @@ mch_start_job(char **argv, job_T *job, jobopt_T *options UNUSED)
}
/* set up stdout for the child */
if (use_null_for_out)
if (use_null_for_out && null_fd >= 0)
{
close(0);
ignored = dup(null_fd);

2
src/version.c
View File

@ -748,6 +748,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
1595,
/**/
1594,
/**/