aniani/vim
0
0
Fork 1
mirror of https://github.com/vim/vim.git synced 2025-09-23 03:43:49 -04:00
Code Activity

patch 8.1.0768: updating completions may cause the popup menu to flicker

Browse Source 
Problem:    Updating completions may cause the popup menu to flicker.
Solution:   Avoid updating the text below the popup menu before drawing the
            popup menu.
This commit is contained in:
Bram Moolenaar
2019-01-17 21:09:05 +01:00
parent c771bf9016
commit ae654385df
5 changed files with 65 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/edit.c
View File

@@ -3020,7 +3020,8 @@ ins_compl_upd_pum(void)
if (compl_match_array != NULL)
{
h = curwin->w_cline_height;
update_screen(0);
// Update the screen later, before drawing the popup menu over it.
pum_call_update_screen();
if (h != curwin->w_cline_height)
ins_compl_del_pum();
}
@@ -3110,8 +3111,8 @@ ins_compl_show_pum(void)
do_cmdline_cmd((char_u *)"if exists('g:loaded_matchparen')|3match none|endif");
#endif
/* Update the screen before drawing the popup menu over it. */
update_screen(0);
// Update the screen later, before drawing the popup menu over it.
pum_call_update_screen();
if (compl_match_array == NULL)
{
@@ -3668,11 +3669,11 @@ ins_compl_new_leader(void)
spell_bad_len = 0; /* need to redetect bad word */
#endif
/*
* Matches were cleared, need to search for them now. First display
* the changed text before the cursor. Set "compl_restarting" to
* avoid that the first match is inserted.
* Matches were cleared, need to search for them now. Befor drawing
* the popup menu display the changed text before the cursor. Set
* "compl_restarting" to avoid that the first match is inserted.
*/
update_screen(0);
pum_call_update_screen();
#ifdef FEAT_GUI
if (gui.in_use)
{
@@ -5077,8 +5078,9 @@ ins_compl_next(
/* may undisplay the popup menu first */
ins_compl_upd_pum();
/* redraw to show the user what was inserted */
update_screen(0);
// Redraw before showing the popup menu to show the user what was
// inserted.
pum_call_update_screen();
/* display the updated popup menu */
ins_compl_show_pum();