0
0
mirror of https://github.com/vim/vim.git synced 2025-09-24 03:44:06 -04:00

patch 8.1.0181: memory leak with trailing characters in skip expression

Problem:    Memory leak with trailing characters in skip expression.
Solution:   Free the return value.
This commit is contained in:
Bram Moolenaar
2018-07-14 17:25:01 +02:00
parent d6ef5f9b3d
commit a43ebe9454
3 changed files with 13 additions and 0 deletions

View File

@@ -729,6 +729,7 @@ eval_expr_typval(typval_T *expr, typval_T *argv, int argc, typval_T *rettv)
return FAIL; return FAIL;
if (*s != NUL) /* check for trailing chars after expr */ if (*s != NUL) /* check for trailing chars after expr */
{ {
clear_tv(rettv);
EMSG2(_(e_invexpr2), s); EMSG2(_(e_invexpr2), s);
return FAIL; return FAIL;
} }

View File

@@ -324,6 +324,16 @@ func Test_searchpair_skip()
bw! bw!
endfunc endfunc
func Test_searchpair_leak()
new
call setline(1, 'if one else another endif')
" The error in the skip expression caused memory to leak.
call assert_fails("call searchpair('\\<if\\>', '\\<else\\>', '\\<endif\\>', '', '\"foo\" 2')", 'E15:')
bwipe!
endfunc
func Test_searchc() func Test_searchc()
" These commands used to cause memory overflow in searchc(). " These commands used to cause memory overflow in searchc().
new new

View File

@@ -789,6 +789,8 @@ static char *(features[]) =
static int included_patches[] = static int included_patches[] =
{ /* Add new patch number below this line */ { /* Add new patch number below this line */
/**/
181,
/**/ /**/
180, 180,
/**/ /**/